-
Notifications
You must be signed in to change notification settings - Fork 2.1k
End to End TLS SSL step #7 - Add support for user-assigned managed identity #17015
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed response types * Fixed EVERYTHING * Reverted to void * Added default poll interval constant * Purchase methods are now private
* Prepare Azure Core for November 2020 Release * Fix linting issue * Revert updates to release azure-core-test and other Core libraries with dependencies on it
added validation in schedule.
* generate avs 2020 03 * update version to 1.0.0
* mgmt rename session records by azure-core-test changes * rename privatedns records
* Adding verify anonymous peer. * Relax assertions in EventConsumerIntegrationTest.
added check for maxsize for schedule message api
* add MSI usage for service bus multi-binder sample
…chOperationKind, and Option from azure-core public API (#16953)
* Update CommunicationClientCredential.java Non-US locales were creating incompatible date strings. Forcing US to make sure that we get the date string we need for authentication. * Update HmacDateTimeFormatTests.java
* Added release phone number LRO * Made implemented functions private * Refactor private methods and added readme * Fixed style issues * Fixed readme samples * Addressed comments
…re response (#16946) * Fixed diagnostics information and other APIs on cosmos stored procedure response * Code review comments * Fixing conflict resolution policy CRUD test
* Remove resource group asynchronously and do not wait for completion * Verify resource group has reached Deleting state before exiting script * Use $_ instead of $Error[0] for resource group removal handling Co-authored-by: Ben Broderick Phillips <[email protected]>
Also fix BasicDigitalTwinMetadata to use the DigitalTwinPropertyMetadata class
* Addressing SpotBugs issues Co-authored-by: Victor Colin Amador <[email protected]>
Co-authored-by: Mike Harder <[email protected]>
* Shorten test name that is too long for Windows git * Disable long path validation and reverted OS image changes * Reenable length check with different base path length * Remove accidentally added file
Also renamed property and setter/getter in BasicDigitalTwin to match it
* support onedeploy * add live test for onedeploy * changelog
* Increment package version after release of com.azure azure-core * Increment package version after release of com.azure azure-core-test * Increment package version after release of com.azure azure-core-experimental * Increment package version after release of com.azure azure-core-http-okhttp * Increment package version after release of com.azure azure-core-serializer-avro-apache * Increment package version after release of com.azure azure-core-http-netty * Increment package version after release of com.azure azure-core-serializer-json-jackson * Increment package version after release of com.azure azure-core-serializer-json-gson * Removed unreleased azure-core version Co-authored-by: alzimmermsft <[email protected]>
* Close client and check for link id when link is stolen * Fix checkstyle
ErrorSource to populate when autocomplete is on and for processor model.
…into end-to-end-tls-ssl-7
chenrujun
approved these changes
Nov 5, 2020
chenrujun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.