Fixed diagnostics information and other APIs on cosmos stored procedure response #16946
Conversation
kushagraThapar
requested review from
David-Noble-at-work,
kirankumarkolli,
mbhaskar,
milismsft,
moderakh,
simplynaveen20 and
xinlian12
as code owners
ghost
added
the
moderakh
left a comment
moderakh
left a comment
There was a problem hiding this comment.
other than the following suggestion LGTM.
with this change essentially similar to CosmosItemResponse we are implementing all these APIs here instead of relying on the parent class.
So I would like to suggest that we drop the inheritance on the CosmosResponse for this class.
I know that theoretically speaking it can be considered a breaking change but in practice it is not breaking change as you are implementing all the required methods.
| } | ||
|
|
||
| @Override | ||
| public String getMaxResourceQuota() { |
There was a problem hiding this comment.
with this change essentially similar to CosmosItemResponse we are implementing all these APIs here instead of relying on the parent class.
So I would like to suggest that we drop the inheritance on the CosmosResponse for this class.
I know that theoretically speaking it can be considered a breaking change but in practice it is not breaking change as you are implementing all the required methods.
...cosmos/azure-cosmos/src/main/java/com/azure/cosmos/models/CosmosStoredProcedureResponse.java
Show resolved
Hide resolved
| CosmosException dce = Utils.as(e, CosmosException.class); | ||
| if (dce != null && dce.getStatusCode() == 400) { | ||
| assertThat(dce.getMessage()).contains("Invalid path '\\/a\\/b' for last writer wins conflict resolution"); | ||
| assertThat(dce.getMessage()).contains("Invalid path '\\\\\\/a\\\\\\/b' for last writer wins conflict resolution"); |
There was a problem hiding this comment.
is this because of service side message change?
There was a problem hiding this comment.
Yes, that is the reason :)
|
/azp run java cosmos tests |
|
No pipelines are associated with this pull request. |
|
/azp run java - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mbhaskar
left a comment
mbhaskar
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing the multimaster conflict test 👍
|
/check-enforcer override |
3 participants
cosmos diagnosticsand other APIs onCosmosStoredProcedureResponse