DefaultAzureCredential continues past developer tool errors#24956
Merged
chlowell merged 2 commits intoAzure:mainfrom Jul 21, 2025
Merged
DefaultAzureCredential continues past developer tool errors#24956chlowell merged 2 commits intoAzure:mainfrom
chlowell merged 2 commits intoAzure:mainfrom
Conversation
github-project-automation
Bot
moved this to Untriaged
in Azure Identity SDK Improvements
chlowell
requested review from
a team,
RickWinter and
jhendrixMSFT
as code owners
chlowell
requested review from
KarishmaGhiya,
christothes,
g2vinay,
maorleger,
minhanh-phan,
pvaneck and
xiangyan99
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where DefaultAzureCredential was not properly configuring developer tool credentials (AzureCLICredential and AzureDeveloperCLICredential) to continue past errors when used in the default chain.
- Adds the
inDefaultChain: trueoption when creating bothAzureCLICredentialandAzureDeveloperCLICredentialinstances - Includes a test to verify the options are properly set on both credential types
- Updates the changelog to document the behavioral change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| sdk/azidentity/default_azure_credential.go | Sets inDefaultChain: true for CLI credential options |
| sdk/azidentity/default_azure_credential_test.go | Adds test to verify CLI credentials have correct options |
| sdk/azidentity/CHANGELOG.md | Documents the bug fix in Other Changes section |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
jhendrixMSFT
approved these changes
Jul 18, 2025
github-project-automation
Bot
moved this from Untriaged
to In Progress
in Azure Identity SDK Improvements
github-project-automation
Bot
moved this from In Progress
to Done
in Azure Identity SDK Improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#21328 added the
inDefaultChainoption but neglected makingNewDefaultAzureCredentialset it