adding azure developer cli credential #21328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhvb1989
requested review from
RickWinter,
chlowell and
jhendrixMSFT
as code owners
chlowell
reviewed
Aug 10, 2023
Member
chlowell
left a comment
chlowell
left a comment
There was a problem hiding this comment.
I added some test coverage on main. If you rebase onto or merge it, I think this PR can clear the coverage bar now
RickWinter
approved these changes
Aug 18, 2023
vhvb1989
requested review from
KarishmaGhiya,
ahsonkhan,
billwert,
mpodwysocki,
pvaneck and
schaabs
scottaddie
reviewed
Aug 30, 2023
Member
|
@vhvb1989 Can you also please add a row to the table at https://github.com/Azure/azure-sdk-for-go/blob/main/sdk/azidentity/README.md#authenticating-via-development-tools? |
Co-authored-by: Charles Lowell <[email protected]>
Co-authored-by: Charles Lowell <[email protected]>
(will add changelog entry in another PR)
chlowell
force-pushed
the
azd-credential
branch
from
c19ea0b to
30472ef
Compare
jhendrixMSFT
approved these changes
Oct 10, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By adding the azd-credential to the sdk-client, we will be able to use it for tools like
terraform(hashicorp/terraform-provider-azurerm#22827) and kubernetes cli