Skip to content

DefaultAzureCredential continues past developer tool errors #24956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chlowell merged 2 commits into from
Jul 21, 2025
Merged

DefaultAzureCredential continues past developer tool errors #24956

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a5464a
DefaultAzureCredential continues past developer tool errors
chlowell Jul 18, 2025
41df196
thanks, Copilot
chlowell Jul 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions sdk/azidentity/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
### Bugs Fixed

### Other Changes
- `DefaultAzureCredential` tries its next credential when a dev tool credential such as
`AzureCLICredential` returns an error

## 1.11.0-beta.1 (2025-07-15)

Expand Down
7 changes: 6 additions & 1 deletion sdk/azidentity/default_azure_credential.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ func NewDefaultAzureCredential(options *DefaultAzureCredentialOptions) (*Default
}
}
if selected&az != 0 {
azCred, err := NewAzureCLICredential(&AzureCLICredentialOptions{AdditionallyAllowedTenants: additionalTenants, TenantID: options.TenantID})
azCred, err := NewAzureCLICredential(&AzureCLICredentialOptions{
AdditionallyAllowedTenants: additionalTenants,
TenantID: options.TenantID,
inDefaultChain: true,
})
if err == nil {
creds = append(creds, azCred)
} else {
Expand All @@ -178,6 +182,7 @@ func NewDefaultAzureCredential(options *DefaultAzureCredentialOptions) (*Default
azdCred, err := NewAzureDeveloperCLICredential(&AzureDeveloperCLICredentialOptions{
AdditionallyAllowedTenants: additionalTenants,
TenantID: options.TenantID,
inDefaultChain: true,
})
if err == nil {
creds = append(creds, azdCred)
Expand Down
22 changes: 22 additions & 0 deletions sdk/azidentity/default_azure_credential_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,28 @@ func TestDefaultAzureCredential_AZURE_TOKEN_CREDENTIALS(t *testing.T) {
})
}

func TestDefaultAzureCredential_CLICredentialOptions(t *testing.T) {
require := require.New(t)
cred, err := NewDefaultAzureCredential(nil)
require.NoError(err)
var (
az *AzureCLICredential
azd *AzureDeveloperCLICredential
)
for _, s := range cred.chain.sources {
if az == nil {
az, _ = s.(*AzureCLICredential)
}
if azd == nil {
azd, _ = s.(*AzureDeveloperCLICredential)
}
}
require.NotNil(az, "%T should be in the default chain", az)
require.True(az.opts.inDefaultChain)
require.NotNil(azd, "%T should be in the default chain", azd)
Comment thread
chlowell marked this conversation as resolved.
Comment thread
chlowell marked this conversation as resolved.
require.True(azd.opts.inDefaultChain)
}

func TestDefaultAzureCredential_ConstructorErrors(t *testing.T) {
// ensure NewEnvironmentCredential returns an error
t.Setenv(azureTenantID, "")
Expand Down