azblob: fix ListBlob to preserve prefix while paging #16992
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Storage
|
Thank you for your contribution serprex! We will review the pull request and get back to you soon. |
Contributor
Author
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For track 2 SDKs Issue the following command as a pull request comment:
|
serprex
pushed a commit
to citusdata/wal-g
that referenced
this pull request
Feb 8, 2022
Fork has fix for ListBlobsHierarchy: Azure/azure-sdk-for-go#16992 This bug causes wal-g to sometimes claim backup-list is empty, or truncated, causing restoring LATEST to either fail or begin with a very old backup
serprex
pushed a commit
to citusdata/wal-g
that referenced
this pull request
Feb 8, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 8, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 8, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
jhendrixMSFT
approved these changes
Feb 8, 2022
mohsha-msft
approved these changes
Feb 8, 2022
mohsha-msft
changed the base branch from
main
to
mohsha-msft/fix-listing-metadata-parsing
Contributor
|
Thanks for your contribution @serprex . I've merged it with the next release candidate. |
mohsha-msft
added a commit
that referenced
this pull request
Feb 9, 2022
* Manual fixes in generated models to adapt azcore 0.21 * Fix SAS Creation + other issue (#16901) * Fix SAS Creation + other issue * Added README.md + Fix comment * Removed Specification File. * Updated CHANGELOG * Regenerated Recordings + Ran Live Tests (#16990) * [Storage] convert options to take pointer (#16978) * convert to nil * changelog entry * adding a comment about nil, changing o to options for better clarity * Bumped up AzCore to the latest version * azblob: fix ListBlob to preserve prefix while paging (#16992) * [Storage] improving documentation (#16945) * improving documentation * updating changelog * ctx -> context.TODO(), simplifying comments * updating a few more examples * improving docs further * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <[email protected]> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <[email protected]> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <[email protected]> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <[email protected]> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <[email protected]> * finished doc updates * Background -> TODO * valid container name * updating readme * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <[email protected]> * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <[email protected]> * removing todos * more comments and additions * set env vars with bash * Azure Storage Blob -> Azure Blob Storage * Update CHANGELOG.md * forcing a change Co-authored-by: Kim Ying <[email protected]> * Added Release Date in CHANGELOG. Co-authored-by: Sean Kane <[email protected]> Co-authored-by: Philip Dubé <[email protected]> Co-authored-by: Kim Ying <[email protected]>
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 14, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 14, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 14, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
serprex
pushed a commit
to wal-g/wal-g
that referenced
this pull request
Feb 15, 2022
Specific commit used because I'm not sure when a new version will be made, but there's a particularly important fix: Azure/azure-sdk-for-go#16354 fixes ListBlobsHierarchy when paging is necessary which turns out to be a broken fix, so a fork is used in the meantime which includes a proper fix: Azure/azure-sdk-for-go#16992 On some containers paging happens much sooner than MaxResults would imply, causing restoring LATEST to either fail because wal-g can't find backups, or wal-g selects an old backup There are two other notable PRs: Azure/azure-sdk-for-go#16067 fixes a chunk pooling bug Azure/azure-sdk-for-go#15958 removes the need for FakeIoReadCloser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16295 was not fixed by #16354 because all options must be repeated in following requests, not just marker. ie prefix would be dropped when paging
This PR opts to modify the passed in options. It's probably preferable to clone the options to a variable within scope to avoid mutating caller's options