[Storage] convert options to take pointer#16978
Merged
seankane-msft merged 4 commits intoAzure:mohsha-msft/fix-listing-metadata-parsingfrom Feb 7, 2022
Merged
[Storage] convert options to take pointer#16978seankane-msft merged 4 commits intoAzure:mohsha-msft/fix-listing-metadata-parsingfrom
seankane-msft merged 4 commits intoAzure:mohsha-msft/fix-listing-metadata-parsingfrom
Conversation
ghost
added
the
JeffreyRichter
approved these changes
Feb 4, 2022
kimprice
reviewed
Feb 4, 2022
| @@ -50,11 +50,14 @@ type DownloadResponse struct { | |||
| // while reading, it will make additional requests to reestablish a connection and | |||
| // continue reading. Specifying a RetryReaderOption's with MaxRetryRequests set to 0 | |||
| // (the default), returns the original response body and no retries will be performed. | |||
Contributor
There was a problem hiding this comment.
Should this comment include something about passing in 'nil' to accept the default options?
Contributor
Author
There was a problem hiding this comment.
Yes it should, added!
jhendrixMSFT
approved these changes
Feb 4, 2022
kimprice
approved these changes
Feb 4, 2022
Contributor
|
I've created a release candidate for azblob 0.3.0 here. You can merge your branch to this one. |
This was referenced Feb 7, 2022
seankane-msft
changed the base branch from
main
to
mohsha-msft/fix-listing-metadata-parsing
mohsha-msft
added a commit
that referenced
this pull request
Feb 9, 2022
* Manual fixes in generated models to adapt azcore 0.21 * Fix SAS Creation + other issue (#16901) * Fix SAS Creation + other issue * Added README.md + Fix comment * Removed Specification File. * Updated CHANGELOG * Regenerated Recordings + Ran Live Tests (#16990) * [Storage] convert options to take pointer (#16978) * convert to nil * changelog entry * adding a comment about nil, changing o to options for better clarity * Bumped up AzCore to the latest version * azblob: fix ListBlob to preserve prefix while paging (#16992) * [Storage] improving documentation (#16945) * improving documentation * updating changelog * ctx -> context.TODO(), simplifying comments * updating a few more examples * improving docs further * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * finished doc updates * Background -> TODO * valid container name * updating readme * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * removing todos * more comments and additions * set env vars with bash * Azure Storage Blob -> Azure Blob Storage * Update CHANGELOG.md * forcing a change Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Added Release Date in CHANGELOG. Co-authored-by: Sean Kane <68240067+seankane-msft@users.noreply.github.com> Co-authored-by: Philip Dubé <serprex@users.noreply.github.com> Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converts
DownloadResponse.Bodyto take a pointer to an options struct.