Conversation
mohsha-msft
commented
Feb 7, 2022
mohsha-msft
commented
- The purpose of this PR is explained in this or a referenced issue.
- The PR does not update generated files.
- These files are managed by the codegen framework at Azure/autorest.go.
- Tests are included and/or updated for code changes.
- Updates to CHANGELOG.md are included.
- MIT license headers are included in each file.
mohsha-msft
requested review from
jhendrixMSFT and
seankane-msft
as code owners
ghost
added
the
* Fix SAS Creation + other issue * Added README.md + Fix comment
mohsha-msft
requested review from
adreed-msft,
siminsavani-msft and
zezha-msft
* convert to nil * changelog entry * adding a comment about nil, changing o to options for better clarity
|
Fixes #16988 |
* improving documentation * updating changelog * ctx -> context.TODO(), simplifying comments * updating a few more examples * improving docs further * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/zt_examples_test.go Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * finished doc updates * Background -> TODO * valid container name * updating readme * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * Update sdk/storage/azblob/README.md Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com> * removing todos * more comments and additions * set env vars with bash * Azure Storage Blob -> Azure Blob Storage * Update CHANGELOG.md * forcing a change Co-authored-by: Kim Ying <15070078+kimprice@users.noreply.github.com>
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps: For track 2 SDKs Issue the following command as a pull request comment:
|
4 participants
