-
Notifications
You must be signed in to change notification settings - Fork 150
Sequential write in downloading and directory download #3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinming-Hu
reviewed
Jun 29, 2022
Member
Jinming-Hu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add unit test cases
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/blob_folder.hpp
Outdated
Show resolved
Hide resolved
...ure-storage-datamovement/inc/azure/storage/datamovement/tasks/download_blob_to_file_task.hpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Outdated
Show resolved
Hide resolved
...ure-storage-datamovement/inc/azure/storage/datamovement/tasks/download_blob_to_file_task.hpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
Jinming-Hu
reviewed
Jun 29, 2022
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
240cb32 to
fdba052
Compare
Jinming-Hu
approved these changes
Jun 30, 2022
Member
Jinming-Hu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/job_engine_task_generation.cpp
Outdated
Show resolved
Hide resolved
Member
|
/azp run cpp - storage |
1 similar comment
Member
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run cpp - storage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
43 tasks
Jinming-Hu
pushed a commit
to Jinming-Hu/azure-sdk-for-cpp
that referenced
this pull request
Oct 14, 2022
* Sequential write in downloading and directory download * Resolve comments * Resolve test failure.
Jinming-Hu
added a commit
that referenced
this pull request
Oct 16, 2022
* Create Storage DataMovement directory (#3594) * DataMovement library Upload functionalities (#3618) * Add blob downloading. (#3658) * Storage DataMovement: Job suspension/resumption/cancellation Error/Progress handling (#3662) * job suspension/resumption/cancellation/error handling/progress * improve * download * rewrite blobfolder (#3681) * Storage Transfer Manager: Job Engine Implementation (#3742) * Sequential write in downloading and directory download (#3779) * Sequential write in downloading and directory download * Resolve comments * Resolve test failure. * Transfer Manager, copy support & journal for downloading (#3792) Co-authored-by: EmmaZhu-MSFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.