Skip to content

Conversation

@Jinming-Hu
Copy link
Member

Pull Request Checklist

Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:

See the detailed list in the contributing guide.

  • C++ Guidelines
  • Doxygen docs
  • Unit tests
  • No unwanted commits/changes
  • Descriptive title/description
    • PR is single purpose
    • Related issue listed
  • Comments in source
  • No typos
  • Update changelog
  • Not work-in-progress
  • External references or docs updated
  • Self review of PR done
  • Any breaking changes?

Jinming-Hu and others added 14 commits May 2, 2022 23:31
The MD5_Init/Update/Final functions are deprecated in OpenSSL 3.0 and result in
a compile-time warning. Due to the default usage of -Werror during compilation,
these warnings are treated as errors and prevent the SDK from being built on
Ubuntu 22.04, which ships with OpenSSL by default. The deprecated APIs should
be replaced by the EVP APIs, which are already in use for the SHA family of
functions, and supported on all versions of OpenSSL.
* API Review Feedback for Attestation SDK

* Updated changelog to reflect API Review updates
* Remove version pin for OpenSSL

* Gratuitous change to trigger CI pipelines
@Jinming-Hu Jinming-Hu added Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files) labels May 4, 2022
@Jinming-Hu Jinming-Hu self-assigned this May 4, 2022
@check-enforcer

This comment was marked as spam.

@Jinming-Hu
Copy link
Member Author

/check-enforcer override

@Jinming-Hu Jinming-Hu merged commit 83b027d into Azure:feature/dmlib May 6, 2022
default: ''
steps:
- template: /eng/common/pipelines/templates/steps/enable-long-path-support.yml
- ${{ if eq(length(parameters.PackageInfoLocations), 0) }}:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this PR have eng/common changes in it? Those files shouldn't be manually modified/merged per repo since they are shared across languages.
https://github.com/Azure/azure-sdk-tools/blob/main/doc/common/common_engsys.md#updating

Are these just fixes for a previous commit/merge that got us out of sync?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see, this PR includes a bunch of changes to sync between main and the feature branch. That makes sense.

Jinming-Hu added a commit to Jinming-Hu/azure-sdk-for-cpp that referenced this pull request Oct 14, 2022
Jinming-Hu added a commit that referenced this pull request Oct 16, 2022
* Create Storage DataMovement directory (#3594)

* DataMovement library Upload functionalities (#3618)

* Add blob downloading. (#3658)

* Storage DataMovement: Job suspension/resumption/cancellation Error/Progress handling (#3662)

* job suspension/resumption/cancellation/error handling/progress

* improve

* download

* rewrite blobfolder (#3681)

* Storage Transfer Manager: Job Engine Implementation (#3742)

* Sequential write in downloading and directory download (#3779)

* Sequential write in downloading and directory download

* Resolve comments

* Resolve test failure.

* Transfer Manager, copy support & journal for downloading (#3792)

Co-authored-by: EmmaZhu-MSFT <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Client This issue points to a problem in the data-plane of the library. Storage Storage Service (Queues, Blobs, Files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants