Add download/download directory functionality #3658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaZhu
requested review from
Jinming-Hu,
LarryOsterman,
antkmsft,
gearama,
katmsft,
vhvb1989 and
vinjiang
as code owners
This comment was marked as spam.
This comment was marked as spam.
Member
|
Hi @EmmaZhu , please rebase your PR on top of latest commit of |
Member
Author
working on it. |
Jinming-Hu
requested changes
May 20, 2022
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/blob_folder.hpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/blob_folder.hpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/blob_folder.hpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_to_file_task.cpp
Outdated
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_directory_task.cpp
Outdated
Show resolved
Hide resolved
Jinming-Hu
added
Client
43 tasks
Jinming-Hu
approved these changes
May 23, 2022
Member
Jinming-Hu
left a comment
Jinming-Hu
left a comment
There was a problem hiding this comment.
LGTM, please fix CI failure
EmmaZhu
force-pushed
the
feature/dmlib
branch
3 times, most recently
from
274062e to
8739bee
Compare
Jinming-Hu
approved these changes
May 23, 2022
Member
There was a problem hiding this comment.
Hi @EmmaZhu , I noticed CI still failed.
You can ignore the coverage drop and failures on UWP platform. But you'll need to clang-format your code
List of files not formatted correctly:
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/blob_folder.hpp
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/tasks/download_blob_directory_task.hpp
sdk/storage/azure-storage-datamovement/inc/azure/storage/datamovement/tasks/upload_blob_from_file_task.hpp
sdk/storage/azure-storage-datamovement/src/blob_folder.cpp
sdk/storage/azure-storage-datamovement/src/blob_transfer_manager.cpp
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_directory_task.cpp
##[error]Bash exited with code '1'.
Finishing: Validate Clang Format
sdk/storage/azure-storage-datamovement/src/tasks/download_blob_directory_task.cpp
Show resolved
Hide resolved
sdk/storage/azure-storage-datamovement/src/tasks/upload_blob_from_file_task.cpp
Outdated
Show resolved
Hide resolved
Member
|
UWP failed because it's been removed from supporting matrix. I synced the latest code from main in this PR #3663. Please approve. |
EmmaZhu
force-pushed
the
feature/dmlib
branch
2 times, most recently
from
8d5724b to
075a410
Compare
Member
|
/check-enforcer override |
Jinming-Hu
pushed a commit
to Jinming-Hu/azure-sdk-for-cpp
that referenced
this pull request
Oct 14, 2022
Jinming-Hu
added a commit
that referenced
this pull request
Oct 16, 2022
* Create Storage DataMovement directory (#3594) * DataMovement library Upload functionalities (#3618) * Add blob downloading. (#3658) * Storage DataMovement: Job suspension/resumption/cancellation Error/Progress handling (#3662) * job suspension/resumption/cancellation/error handling/progress * improve * download * rewrite blobfolder (#3681) * Storage Transfer Manager: Job Engine Implementation (#3742) * Sequential write in downloading and directory download (#3779) * Sequential write in downloading and directory download * Resolve comments * Resolve test failure. * Transfer Manager, copy support & journal for downloading (#3792) Co-authored-by: EmmaZhu-MSFT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Please leverage this checklist as a reminder to address commonly occurring feedback when submitting a pull request to make sure your PR can be reviewed quickly:
See the detailed list in the contributing guide.