Skip to content

Revert change "fix api-version from method property to client property" for Resources within 2019-08-01 and 2019-10-01#8184

Merged
ArcturusZhang merged 20 commits intoAzure:masterfrom
Grayer123:feature/tagApi-2019-10-01
Jan 22, 2020
Merged

Revert change "fix api-version from method property to client property" for Resources within 2019-08-01 and 2019-10-01#8184
ArcturusZhang merged 20 commits intoAzure:masterfrom
Grayer123:feature/tagApi-2019-10-01

Conversation

@Grayer123
Copy link
Contributor

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

  • I have reviewed the documentation for the workflow.
  • Validation tools were run on swagger spec(s) and have all been fixed in this PR.
  • The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

  • Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
  • adding/removing APIs.
  • adding/removing properties.
  • adding/removing API-version.
  • adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

  • If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
    Please follow the link to find more details on API review process.

Ran Wang and others added 20 commits November 5, 2019 08:45
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@Tiano2017 Tiano2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Grayer123
Copy link
Contributor Author

Hello @ArcturusZhang, could you please help us merge this pr? Also, I noticed there was one task canceled, and one expected (has been in this status for a few days). Is there a way to re-trigger a new round of check or should I check in an empty commit to force it? Many thanks.

@ArcturusZhang
Copy link
Member

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@ArcturusZhang
Copy link
Member

Hello @ArcturusZhang, could you please help us merge this pr? Also, I noticed there was one task canceled, and one expected (has been in this status for a few days). Is there a way to re-trigger a new round of check or should I check in an empty commit to force it? Many thanks.

That is the pipeline of SDK automation. To trigger it will require permission from the Azure organization on github. I have triggered it by leaving a comment. I will merge this once the CI passes.

@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Jan 22, 2020

azure-sdk-for-go - Release

⚠️ warning [Logs] [Expand Details]
  • ⚠️ Generate from 80838d0 with merge commit 398b5e0. SDK Automation 13.0.17.20191226.1
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1791: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"059B:5FC6:1B9216:223ABE:5E27FE76","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4859","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2018-05-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1796: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"059C:82F8:1C056E:22B9DB:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4857","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2019-06-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1797: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"058E:0F03:213859:28B88B:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4856","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2019-07-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1795: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"058F:19C1:FCC14:137096:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4855","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2019-05-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1793: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"05A0:5FC8:22B1A1:2A5545:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4854","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2019-01-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1783: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"059D:4E06:1CD9C6:238AB0:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4852","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2016-06-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1787: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"05A4:85F0:6BE96:871BF:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4851","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2017-05-10@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1785: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0593:7547:2326E7:2B1DD2:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4850","x-ratelimit-reset":"1579682518","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/resources_mgmt_2016-09-01@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
    Failed to close the generation pull request at https://github.com/AzureSDKAutomation/azure-sdk-for-go/pull/1777: HttpError, {"name":"HttpError","status":500,"headers":{"access-control-allow-origin":"*","access-control-expose-headers":"ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type","connection":"close","content-length":"0","content-security-policy":"default-src 'none'","content-type":"application/json; charset=utf-8","date":"Wed, 22 Jan 2020 07:49:18 GMT","referrer-policy":"origin-when-cross-origin, strict-origin-when-cross-origin","server":"GitHub.com","status":"500 Internal Server Error","strict-transport-security":"max-age=31536000; includeSubdomains; preload","x-content-type-options":"nosniff","x-frame-options":"deny","x-github-media-type":"github.machine-man-preview; format=json","x-github-request-id":"0595:7291:24C6FE:2D0A52:5E27FE77","x-ratelimit-limit":"5000","x-ratelimit-remaining":"4848","x-ratelimit-reset":"1579682517","x-xss-protection":"1; mode=block"},"request":{"method":"DELETE","url":"https://api.github.com/repos/AzureSDKAutomation/azure-sdk-for-go/git/refs/heads/sdkAutomation/preview_resources_mgmt_2017-06-01-preview@8184","headers":{"accept":"application/vnd.github.machine-man-preview+json","user-agent":"octokit.js/16.35.0 Node.js/12.14.0 (Linux 5.0; x64)","authorization":"token [REDACTED]","content-length":0},"request":{"validate":{"owner":{"required":true,"type":"string"},"ref":{"required":true,"type":"string"},"repo":{"required":true,"type":"string"}}}}}
  • ️✔️preview/resources/mgmt/2015-10-01-preview [Logs]  [Release SDK Changes]
  • ️✔️preview/resources/mgmt/2016-09-01-preview [Logs]  [Release SDK Changes]
  • ️✔️preview/resources/mgmt/2017-06-01-preview [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2015-01-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2015-11-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2015-12-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-02-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-04-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-06-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-07-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-09-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2016-12-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2017-05-10 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2017-09-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2018-02-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2018-03-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2018-05-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2018-06-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2019-01-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2019-03-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2019-05-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2019-06-01 [Logs]  [Release SDK Changes]
  • ️✔️resources/mgmt/2019-07-01 [Logs]  [Release SDK Changes]
  • ⚠️resources/mgmt/2019-09-01 [Logs
      No file is changed.

    @openapi-sdkautomation
    Copy link

    openapi-sdkautomation bot commented Jan 22, 2020

    azure-sdk-for-python - Release

    ️✔️ succeeded [Logs] [Expand Details]
    • ️✔️ Generate from 80838d0 with merge commit 398b5e0. SDK Automation 13.0.17.20191226.1
    • ️✔️azure-mgmt-resource [Logs]  [Release SDK Changes]
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [after_scripts|python] WARNING:__main__:Found too much API version: {'2017-06-01-preview', '2016-12-01'} in label v2017_06_01_preview
      [after_scripts|python] WARNING:__main__:Guessing you want 2017-06-01-preview based on label v2017_06_01_preview
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [after_scripts|python] WARNING:__main__:Patching multi-api client basic files
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)
      [build_package] /usr/lib/python3.6/distutils/dist.py:261: UserWarning: Unknown distribution option: 'long_description_content_type'
      [build_package]   warnings.warn(msg)

    This was referenced Jan 22, 2020
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Labels

    None yet

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    4 participants