Skip to content

Revert change "fix api-version from method property to client property" for Resources within 2019-08-01 and 2019-10-01 #8184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArcturusZhang merged 20 commits into from
Jan 22, 2020
Merged

Revert change "fix api-version from method property to client property" for Resources within 2019-08-01 and 2019-10-01 #8184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
b5ce443
Added previous version spec as initial commit.
Nov 5, 2019
32ccceb
Modified all the api-version for the existing example files.
Nov 5, 2019
f15fc00
Added tag related api spec to resource file as well add example files.
Nov 5, 2019
f81a841
Modified readme related files.
Nov 5, 2019
e4929b3
Execute prettier to reorganize the file.
Nov 5, 2019
562d32f
Pull request comments related fixes.
Nov 6, 2019
fb809c0
Use scope to support nested resources for tags.
Nov 9, 2019
8dae465
Update examples based on scope change.
Nov 9, 2019
fd4f9f1
Remove first slash to resolve model validation error.
Nov 9, 2019
7ca5f73
Combine tracked resource and subscription apis for tags.
Nov 12, 2019
dc232bd
Modifed the examples to match the changes in resource.json.
Nov 12, 2019
a256604
Utilize the shared parameters, and update the examples.
Nov 14, 2019
96c0059
Removing "required" from TagPatchRequest as getting R2016 error.
Nov 14, 2019
d12d046
Collapse TagRequest and TagResponse into TagsResource.
Nov 14, 2019
21886c6
Removed 404 response as covered in default scenario, as well updated …
Nov 18, 2019
6809fa4
Merge remote-tracking branch 'upstream/master' into feature/tagApi-20…
Dec 28, 2019
b2fad0b
Apply fix api-version from method property to client property for 201…
Dec 28, 2019
2b3c9c1
Merge remote-tracking branch 'upstream/master' into feature/tagApi-20…
Jan 17, 2020
1408036
Revert "Resources: fix api-version from method property to client pro…
Grayer123 Jan 17, 2020
80838d0
Revert changes "fix api-version from method property to client proper…
Grayer123 Jan 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 50 additions & 10 deletions ...ification/resources/resource-manager/Microsoft.Resources/stable/2019-08-01/resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2726,7 +2726,11 @@
"description": "The name of the resource to check whether it exists."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -2795,7 +2799,11 @@
"description": "The name of the resource to delete."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -2868,7 +2876,11 @@
"description": "The name of the resource to create."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -2956,7 +2968,11 @@
"description": "The name of the resource to update."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3038,7 +3054,11 @@
"description": "The name of the resource to get."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -3077,7 +3097,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down Expand Up @@ -3111,7 +3135,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down Expand Up @@ -3149,7 +3177,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3202,7 +3234,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3249,7 +3285,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down
60 changes: 50 additions & 10 deletions ...ification/resources/resource-manager/Microsoft.Resources/stable/2019-10-01/resources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2726,7 +2726,11 @@
"description": "The name of the resource to check whether it exists."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -2795,7 +2799,11 @@
"description": "The name of the resource to delete."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -2868,7 +2876,11 @@
"description": "The name of the resource to create."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -2956,7 +2968,11 @@
"description": "The name of the resource to update."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3038,7 +3054,11 @@
"description": "The name of the resource to get."
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"$ref": "#/parameters/SubscriptionIdParameter"
Expand Down Expand Up @@ -3077,7 +3097,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down Expand Up @@ -3111,7 +3135,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down Expand Up @@ -3149,7 +3177,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3202,7 +3234,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
},
{
"name": "parameters",
Expand Down Expand Up @@ -3249,7 +3285,11 @@
"x-ms-skip-url-encoding": true
},
{
"$ref": "#/parameters/ApiVersionParameter"
"name": "api-version",
"in": "query",
"required": true,
"type": "string",
"description": "The API version to use for the operation."
}
],
"responses": {
Expand Down