Resources: fix api-version from method property to client property#7753
Merged
Resources: fix api-version from method property to client property#7753
Conversation
Automation for azure-sdk-for-pythonA PR has been created for you: |
Automation for azure-sdk-for-goNothing to generate for azure-sdk-for-go |
ChenTanyi
added
the
WaitForARMFeedback
Contributor
|
Can one of the admins verify this patch? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ravbhatnagar
added
ARMSignedOff
Contributor
Author
|
@anthony-c-martin I noticed you are reviewer of ARM 2019-10-01. Can you please help verify if my changes make sense? If so, please also advise whether these changes should apply to package 2019-10-01. Thanks. |
anthony-c-martin
approved these changes
Nov 21, 2019
Tiano2017
approved these changes
Nov 21, 2019
ChenTanyi
approved these changes
Nov 21, 2019
TalluriAnusha
pushed a commit
to AsrOneSdk/azure-rest-api-specs
that referenced
this pull request
Dec 11, 2019
Grayer123
added a commit
to Grayer123/azure-rest-api-specs
that referenced
this pull request
Jan 17, 2020
…perty (Azure#7753)" This reverts commit 1551635.
ArcturusZhang
pushed a commit
that referenced
this pull request
Jan 22, 2020
…y" for Resources within 2019-08-01 and 2019-10-01 (#8184) * Added previous version spec as initial commit. * Modified all the api-version for the existing example files. * Added tag related api spec to resource file as well add example files. * Modified readme related files. * Execute prettier to reorganize the file. * Pull request comments related fixes. * Use scope to support nested resources for tags. * Update examples based on scope change. * Remove first slash to resolve model validation error. * Combine tracked resource and subscription apis for tags. * Modifed the examples to match the changes in resource.json. * Utilize the shared parameters, and update the examples. * Removing "required" from TagPatchRequest as getting R2016 error. * Collapse TagRequest and TagResponse into TagsResource. * Removed 404 response as covered in default scenario, as well updated corresponding examples. * Apply fix api-version from method property to client property for 2019-10-01. * Revert "Resources: fix api-version from method property to client property (#7753)" This reverts commit 1551635. * Revert changes "fix api-version from method property to client property" for resources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Latest improvements:
MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.
Contribution checklist:
ARM API Review Checklist
Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.
Please follow the link to find more details on API review process.