Skip to content

Conversation

@xuto2
Copy link
Contributor

@xuto2 xuto2 commented Aug 3, 2019

If you are a MSFT employee you can view your work branch via this link.

Contribution checklist:

NOTE for reviewer
The net change is in this commit: 76e4398

The rest are copied from the previous version (2019-06-01) as base.

@xuto2 xuto2 requested a review from mboersma as a code owner August 3, 2019 06:57
@openapi-sdkautomation
Copy link

openapi-sdkautomation bot commented Aug 3, 2019

In Testing, Please Ignore

[Logs] (Generated from 2307de0, Iteration 5)

Succeeded Python: test-repo-billy/azure-sdk-for-python [Logs] [Diff]
Failed Java: test-repo-billy/azure-sdk-for-java [Logs]
  • No packages generated.
Failed Go: test-repo-billy/azure-sdk-for-go [Logs] [Diff]
Warning JavaScript: test-repo-billy/azure-sdk-for-js [Logs] [Diff]
  • Warning @azure/arm-containerservice [Logs]
Failed .NET: test-repo-billy/azure-sdk-for-net [Logs] [Diff]
Warning Ruby: test-repo-billy/azure-sdk-for-ruby [Logs] [Diff]
  • No packages generated.

@AutorestCI
Copy link

AutorestCI commented Aug 3, 2019

Automation for azure-sdk-for-python

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-python#6756

@AutorestCI
Copy link

AutorestCI commented Aug 3, 2019

Automation for azure-sdk-for-go

The initial PR has been merged into your service PR:
Azure/azure-sdk-for-go#5492

@azuresdkci
Copy link
Contributor

Can one of the admins verify this patch?

@sergey-shandar sergey-shandar added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 5, 2019
Copy link
Member

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@ravbhatnagar ravbhatnagar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xuto2 couple of comments. please take a look.

@weinong
Copy link
Contributor

weinong commented Aug 8, 2019

@xuto2 let's remove the private link resource. We will add it as a sub resource like SQL does in next iteration.
@ravbhatnagar we will remove private link resources

@xuto2 xuto2 force-pushed the dev-containerservice-Microsoft.ContainerService-2019-08-01 branch from 2307de0 to 9e6d4ac Compare August 8, 2019 18:15
@ravbhatnagar
Copy link
Contributor

Great, signing off from ARM side.

@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 8, 2019
@xuto2
Copy link
Contributor Author

xuto2 commented Aug 10, 2019

@sergey-shandar Can you take a look? The net change is just one commit: 76e4398

@sergey-shandar sergey-shandar merged commit 98e6b89 into Azure:master Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants