Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #5233

anpint · 2019-02-19T23:51:21Z

Latest improvements:

MSFT employees can try out our new experience at OpenAPI Hub - one location for using our validation tools and finding your workflow.

Contribution checklist:

I have reviewed the documentation for the workflow.
Validation tools were run on swagger spec(s) and have all been fixed in this PR.
The OpenAPI Hub was used for checking validation status and next steps.

ARM API Review Checklist

Service team MUST add the "WaitForARMFeedback" label if the management plane API changes fall into one of the below categories.
adding/removing APIs.
adding/removing properties.
adding/removing API-version.
adding a new service in Azure.

Failure to comply may result in delays for manifest application. Note this does not apply to data plane APIs.

If you are blocked on ARM review and want to get the PR merged urgently, please get the ARM oncall for reviews (RP Manifest Approvers team under Azure Resource Manager service) from IcM and reach out to them.
Please follow the link to find more details on API review process.

… activity

AutorestCI · 2019-02-19T23:51:51Z

Automation for azure-sdk-for-ruby

Nothing to generate for azure-sdk-for-ruby

AutorestCI · 2019-02-19T23:52:00Z

Automation for azure-sdk-for-js

Encountered an unknown error: (azure-sdk-for-js)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01
  stderr: 'remote: Permission to Azure/azure-sdk-for-js.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-js.git/': The requested URL returned error: 403'

AutorestCI · 2019-02-19T23:52:05Z

Automation for azure-sdk-for-python

A PR has been created for you:
Azure/azure-sdk-for-python#4391

AutorestCI · 2019-02-19T23:54:06Z

Automation for azure-sdk-for-go

Nothing to generate for azure-sdk-for-go

AutorestCI · 2019-02-19T23:54:25Z

Automation for azure-sdk-for-node

Encountered an unknown error: (azure-sdk-for-node)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(1)
  cmdline: git push --set-upstream origin restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01
  stderr: 'To https://github.com/Azure/azure-sdk-for-node.git
 ! [rejected]            restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01 -> restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01 (fetch first)
error: failed to push some refs to 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-node.git'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.'

azuresdkci · 2019-02-20T00:34:15Z

Can one of the admins verify this patch?

AutorestCI · 2019-02-20T01:32:41Z

Automation for azure-sdk-for-java

Encountered an unknown error: (azure-sdk-for-java)

Traceback (most recent call last):
  File "/usr/local/lib/python3.6/dist-packages/azure_devtools/ci_tools/github_tools.py", line 33, in exception_to_github
    yield context
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 170, in rest_handle_action
    return rest_pull_close(body, restapi_repo, sdk_pr_target_repo, sdkbase, sdk_tag)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github.py", line 185, in rest_pull_close
    rest_pr_management(rest_pr, sdk_pr_target_repo, sdk_tag, sdk_default_base)
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/restapi/github_handler.py", line 151, in rest_pr_management
    sdk_tag=sdk_tag
  File "/usr/local/lib/python3.6/dist-packages/swaggertosdk/SwaggerToSdkNewCLI.py", line 309, in generate_sdk_from_git_object
    sdk_repo.git.push('origin', base_branch, set_upstream=True)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 548, in <lambda>
    return lambda *args, **kwargs: self._call_process(name, *args, **kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 1014, in _call_process
    return self.execute(call, **exec_kwargs)
  File "/usr/local/lib/python3.6/dist-packages/git/cmd.py", line 825, in execute
    raise GitCommandError(command, status, stderr_value, stdout_value)
git.exc.GitCommandError: Cmd('git') failed due to: exit code(128)
  cmdline: git push --set-upstream origin restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01
  stderr: 'remote: Permission to Azure/azure-sdk-for-java.git denied to AutorestCI.
fatal: unable to access 'https://AutorestCI:[email protected]/Azure/azure-sdk-for-java.git/': The requested URL returned error: 403'

anpint · 2019-02-20T17:03:59Z

@praries880 could you please take a look at the PR?

praries880 · 2019-02-20T22:55:31Z

@ravbhatnagar Can you review the PR?

…areName

ravbhatnagar · 2019-02-22T01:09:09Z

@anpint - looks like there are breaking changes to the preview api-version. Customers on this version can be broken. Are you aware and ok with that?

ravbhatnagar · 2019-02-22T01:10:17Z

@praries880 - Why doesnt the breaking change tool catch the property name changes as breaking change?

anpint · 2019-02-22T06:44:21Z

@anpint - looks like there are breaking changes to the preview api-version. Customers on this version can be broken. Are you aware and ok with that?

Hi Gaurav. This API version (2019-02-01) is brand-new. The current state of this branch (dev-storagesync-Microsoft.StorageSync-2019-02-01) is that it contains the new API version 2019-02-01 as a copy of the previous API version. In this PR, we are introducing the actual protocol changes that will be in this new API version.

Currently, there are no publicly released clients using this API version, so I don't think there is any breaking change issue. Please let me know if anything needs more clarification.

ravbhatnagar · 2019-02-22T07:22:16Z

ok, sounds good and thanks for confirming! Signing off from ARM side!

…on 2019-02-01 (#5210) * Adds base for updating Microsoft.StorageSync from version stable/2018-10-01 to version 2019-02-01 * Updates readme * Updates API version in new specs and examples * Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking (#5233) * Modify sync status properties to support parallel upload and download activity * Fix a typo in storagesync.json * Fix a linter issue with ErrorCode property in FilesNotSyncingError * Fix a validation error with SyncActivityState enum usage * Fix "integer" types in ServerEndpointSyncStatus to specify format * rename cloud endpoint property storageAccountShareName to azureFileShareName * update required properties for server endpoint sync status objects * remove "required" from some server endpoint health properties (didn't have the desired outcome) * Update description of azureFileShareName property * Move 2019-02-01 to stable, clean up readme files

* resolving s360 item * added prettier-fix changes Co-authored-by: Gaurav Bang <[email protected]>

anpint added 4 commits February 19, 2019 15:27

Modify sync status properties to support parallel upload and download…

ca2054d

… activity

Fix a typo in storagesync.json

0afd904

Fix a linter issue with ErrorCode property in FilesNotSyncingError

3d36349

Fix a validation error with SyncActivityState enum usage

70a663c

anpint requested a review from ankushbindlish2 as a code owner February 19, 2019 23:51

AutorestCI mentioned this pull request Feb 19, 2019

[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking Azure/azure-sdk-for-js#1295

Closed

AutorestCI mentioned this pull request Feb 19, 2019

[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking Azure/azure-sdk-for-python#4391

Closed

anpint added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Feb 19, 2019

azuresdkci assigned praries880 Feb 19, 2019

azuresdkci requested a review from praries880 February 19, 2019 23:52

AutorestCI mentioned this pull request Feb 19, 2019

[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking Azure/azure-sdk-for-node#4709

Closed

anpint requested a review from afedyashov February 20, 2019 00:01

Fix "integer" types in ServerEndpointSyncStatus to specify format

1bede55

ankushbindlish2 approved these changes Feb 20, 2019

View reviewed changes

rename cloud endpoint property storageAccountShareName to azureFileSh…

9e00831

…areName

ravbhatnagar added the ARMChangesRequested label Feb 22, 2019

ravbhatnagar added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Feb 22, 2019

ravbhatnagar removed ARMChangesRequested WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Feb 22, 2019

praries880 approved these changes Feb 22, 2019

View reviewed changes

praries880 merged commit b841e72 into dev-storagesync-Microsoft.StorageSync-2019-02-01 Feb 22, 2019

anpint deleted the storagesync-2019-02-01-protocolchanges branch March 26, 2019 23:02

mccleanp pushed a commit that referenced this pull request Mar 23, 2022

resolving s360 item (#5233)

e57e6fe

* resolving s360 item * added prettier-fix changes Co-authored-by: Gaurav Bang <[email protected]>

Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #5233

Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #5233

Uh oh!

Conversation

anpint commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Latest improvements:

Contribution checklist:

ARM API Review Checklist

Uh oh!

AutorestCI commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-ruby

Uh oh!

AutorestCI commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-js

Uh oh!

AutorestCI commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-python

Uh oh!

AutorestCI commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-go

Uh oh!

AutorestCI commented Feb 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-node

Uh oh!

azuresdkci commented Feb 20, 2019

Uh oh!

AutorestCI commented Feb 20, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Automation for azure-sdk-for-java

Uh oh!

anpint commented Feb 20, 2019

Uh oh!

praries880 commented Feb 20, 2019

Uh oh!

ravbhatnagar commented Feb 22, 2019

Uh oh!

ravbhatnagar commented Feb 22, 2019

Uh oh!

anpint commented Feb 22, 2019

Uh oh!

ravbhatnagar commented Feb 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

anpint commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 19, 2019 •

edited

Loading

AutorestCI commented Feb 20, 2019 •

edited

Loading