Skip to content

[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #4391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
AutorestCI wants to merge 8 commits into from
Closed

[AutoPR storagesync/resource-manager] Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #4391

AutorestCI wants to merge 8 commits into from

Conversation

@AutorestCI
Copy link
Contributor

@AutorestCI AutorestCI commented Feb 19, 2019

Brandon Siegel and others added 5 commits February 15, 2019 13:56
Remove appveyor badge (#4373)
1bf587b
@scbedd
Added .docsettings file with omitted paths. (#4365)
ea80a89 
Added readme check to CI.
@AutorestCI @lmazuel
[AutoPR] network/resource-manager (#4193)
f68c120 
* Generated from 16e344b5cc1a34fb370e58df07d07976efd44ffb (#4192)

typo: Fix network/resource-manager/Microsoft.Network/network

- resrources -> resources
- retreive -> retrieve
- opertion -> operation
- Various stuck together words
- Pering -> Peering
- curcuit -> circuit
- Various "network" typo variations
- specifed -> specified
- conenction -> connection
- appliation -> application
- mircosoft -> Microsoft
- wher -> where
- addresseses -> addresses
- compotnent -> component
- emlement -> element
- endponints -> endpoints
- potocol -> protocol
- servive -> service
- outcoming -> outgoing
- Sests -> Sets
- Gateay -> Gateway
- Maxium -> Maximum
- Double word "curcuit"
- Prodiver -> Provider
- Spepcified -> Specified
- Succeded -> Succeeded
- crossconnection -> cross connection
- retriving -> retrieving
- Etherype -> Ether type
- seperator -> separator
- asterix -> asterisk
- Aure -> Azure
- Prefx -> Prefix
- profilees -> profiles
- conatinaer -> container
- configruation -> configuration
- outcoming -> outgoing
- snaphots -> snapshots
- Traffice -> Traffic
- Policys -> Policies
- specificed -> specified
- VPNsite -> VPN site
- provisisoning -> provisioning
- Double word "for"
- vpnclients -> VPN clients

* [AutoPR network/resource-manager] Cherry pick AppGw changes into master (#4189)

* Generated from 1d2275aed8e02f03916ac0c8498a7f8ae96a4517

add max bound for application gateway autoscale config (#4996)

* Generated from 1d2275aed8e02f03916ac0c8498a7f8ae96a4517

add max bound for application gateway autoscale config (#4996)

* Generated from 4b0852e488d067ebda51a62c3f9b4845901f2f67 (#4356)

typo: network/resource-manager/Microsoft.Network/stable/2018-12-01

- Maxium -> Maximum
- retriving -> retrieving
- Ethertype -> Ether type
- asterix -> asterisk

* Packaging update of azure-mgmt-network

* Rebuild by #4193

* Network 2.6.0rc1

* Check DNS update
@AutorestCI
Generated from 0afd9049139e4fff0b0ea012c5943d03b76877bb
54ebfb6 
Fix a typo in storagesync.json
@AutorestCI
Generated from 3d3634985ded755ac9219900e9d0c38b52502202
4dd50b5 
Fix a linter issue with ErrorCode property in FilesNotSyncingError
@AutorestCI AutorestCI requested a review from lmazuel as a code owner February 19, 2019 23:52
@AutorestCI AutorestCI mentioned this pull request Feb 19, 2019
Merged
5 tasks
@codecov-io
Copy link

codecov-io commented Feb 19, 2019 •
edited
Loading

Codecov Report

Merging #4391 into restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01 will decrease coverage by 0.03%.
The diff coverage is 2.12%.

Impacted file tree graph

@@                                        Coverage Diff                                        @@
##           restapi_auto_dev-storagesync-Microsoft.StorageSync-2019-02-01    #4391      +/-   ##
=================================================================================================
- Coverage                                                          53.41%   53.38%   -0.04%     
=================================================================================================
  Files                                                              10455    10458       +3     
  Lines                                                             219323   219465     +142     
=================================================================================================
+ Hits                                                              117148   117152       +4     
- Misses                                                            102175   102313     +138
Impacted Files Coverage Δ
...8_01/models/effective_network_security_rule_py3.py 20% <ø> (ø) ⬆️
...t/network/v2018_08_01/models/express_route_port.py 27.77% <ø> (ø) ⬆️
...08_01/models/virtual_network_gateway_connection.py 19.23% <ø> (ø) ⬆️
...18_08_01/models/container_network_interface_py3.py 38.46% <ø> (ø) ⬆️
.../v2018_11_01/models/container_network_interface.py 38.46% <ø> (ø) ⬆️
...ls/network_configuration_diagnostic_profile_py3.py 45.45% <ø> (ø) ⬆️
.../network/v2018_08_01/models/p2_svpn_gateway_py3.py 38.46% <ø> (ø) ⬆️
...twork/v2018_08_01/models/express_route_port_py3.py 27.77% <ø> (ø) ⬆️
..._11_01/operations/public_ip_prefixes_operations.py 17.46% <ø> (ø) ⬆️
.../v2018_08_01/models/container_network_interface.py 38.46% <ø> (ø) ⬆️
... and 57 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3603670...b0bf18a. Read the comment docs.

azuresdkci and others added 2 commits February 19, 2019 23:56
@AutorestCI
Copy link
Contributor Author

AutorestCI commented Feb 20, 2019 •
edited
Loading

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-network

You can install the package azure-mgmt-network of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storagesync-2019-02-01-protocolchanges#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storagesync-2019-02-01-protocolchanges#egg=azure-mgmt-network&subdirectory=azure-mgmt-network"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_storagesync-2019-02-01-protocolchanges
  • pip install -e ./azure-mgmt-network

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_storagesync-2019-02-01-protocolchanges
  • pip wheel --no-deps ./azure-mgmt-network

Package azure-mgmt-storagesync

You can install the package azure-mgmt-storagesync of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storagesync-2019-02-01-protocolchanges#egg=azure-mgmt-storagesync&subdirectory=azure-mgmt-storagesync"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_storagesync-2019-02-01-protocolchanges#egg=azure-mgmt-storagesync&subdirectory=azure-mgmt-storagesync"

If you have a local clone of this repository, you can also do:

  • git checkout restapi_auto_storagesync-2019-02-01-protocolchanges
  • pip install -e ./azure-mgmt-storagesync

Or build a wheel file to distribute for testing:

  • git checkout restapi_auto_storagesync-2019-02-01-protocolchanges
  • pip wheel --no-deps ./azure-mgmt-storagesync

Direct download

Your files can be directly downloaded here:

@AutorestCI
Generated from 9e008310b0716e87a0fb554cf42a92c2ff8e8404
1f07a8d 
rename cloud endpoint property storageAccountShareName to azureFileShareName
@lmazuel
Copy link
Member

lmazuel commented Mar 7, 2019

Broken PR

@lmazuel lmazuel closed this Mar 7, 2019
@lmazuel lmazuel deleted the restapi_auto_storagesync-2019-02-01-protocolchanges branch March 7, 2019 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lmazuel lmazuel Awaiting requested review from lmazuel

Assignees

No one assigned

Labels

RestPRMerged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AutorestCI @codecov-io @lmazuel @scbedd @azuresdkci