Skip to content

Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #5233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
praries880 merged 6 commits into from
Feb 22, 2019
Merged

Review request for Microsoft.StorageSync to update 2019-02-01 with support for parallel upload and download sync status tracking #5233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ca2054d
Modify sync status properties to support parallel upload and download…
anpint Feb 19, 2019
0afd904
Fix a typo in storagesync.json
anpint Feb 19, 2019
3d36349
Fix a linter issue with ErrorCode property in FilesNotSyncingError
anpint Feb 19, 2019
70a663c
Fix a validation error with SyncActivityState enum usage
anpint Feb 19, 2019
1bede55
Fix "integer" types in ServerEndpointSyncStatus to specify format
anpint Feb 20, 2019
9e00831
rename cloud endpoint property storageAccountShareName to azureFileSh…
anpint Feb 21, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...urce-manager/Microsoft.StorageSync/preview/2019-02-01/examples/CloudEndpoints_Create.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"parameters": {
"properties": {
"storageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/tminienv59svc/providers/Microsoft.Storage/storageAccounts/tminienv59storage",
"storageAccountShareName": "cvcloud-afscv-0719-058-a94a1354-a1fd-4e9a-9a50-919fad8c4ba4",
"azureFileShareName": "cvcloud-afscv-0719-058-a94a1354-a1fd-4e9a-9a50-919fad8c4ba4",
"storageAccountTenantId": "\"72f988bf-86f1-41af-91ab-2d7cd011db47\"",
"friendlyName": "ankushbsubscriptionmgmtmab"
},
Expand All @@ -28,7 +28,7 @@
"backupEnabled" : "false",
"provisioningState": "Succeeded",
"storageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/tminienv59svc/providers/Microsoft.Storage/storageAccounts/tminienv59storage",
"storageAccountShareName": "cvcloud-afscv-0719-058-a94a1354-a1fd-4e9a-9a50-919fad8c4ba4",
"azureFileShareName": "cvcloud-afscv-0719-058-a94a1354-a1fd-4e9a-9a50-919fad8c4ba4",
"storageAccountTenantId": "\"72f988bf-86f1-41af-91ab-2d7cd011db47\"",
"friendlyName": "ankushbsubscriptionmgmtmab",
"lastWorkflowId": "storageSyncServices/GATest/workflows/24ba0c4a-348e-419b-8f7a-091d0d9f07a4",
Expand Down
2 changes: 1 addition & 1 deletion ...esource-manager/Microsoft.StorageSync/preview/2019-02-01/examples/CloudEndpoints_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"properties": {
"provisioningState": "Succeeded",
"storageAccountResourceId": "",
"storageAccountShareName": "",
"azureFileShareName": "",
"storageAccountTenantId": "\"a4d1b191-c1af-4cef-a14b-f670e0beea52\"",
"lastWorkflowId": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/workflows/a377fdd5-949a-40ab-9629-06cd0e9852f9",
"friendlyName": "SampleAzureFileShareName_1",
Expand Down
2 changes: 1 addition & 1 deletion ...ger/Microsoft.StorageSync/preview/2019-02-01/examples/CloudEndpoints_ListBySyncGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"properties": {
"provisioningState": "Succeeded",
"storageAccountResourceId": "",
"storageAccountShareName": "",
"azureFileShareName": "",
"storageAccountTenantId": "\"a4d1b191-c1af-4cef-a14b-f670e0beea52\"",
"lastWorkflowId": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/workflows/a377fdd5-949a-40ab-9629-06cd0e9852f9",
"friendlyName": "SampleAzureFileShareName_1",
Expand Down
31 changes: 27 additions & 4 deletions ...source-manager/Microsoft.StorageSync/preview/2019-02-01/examples/ServerEndpoints_Get.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,44 @@
"downloadHealth": "Healthy",
"uploadHealth": "Error",
"combinedHealth": "Error",
"syncActivity": "UploadAndDownload",
"totalPersistentFilesNotSyncingCount": null,
"lastUpdatedTimestamp": "2018-06-11T23:32:51.1057915Z",
"uploadStatus": {
"lastSyncResult": -2134351810,
"lastSyncTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncSuccessTimestamp": null,
"lastSyncPerItemErrorCount": 69
"lastSyncPerItemErrorCount": 1000,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"downloadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"currentProgress": null,
"offlineDataTransferStatus": "NotRunning"
"uploadActivity": {
"timestamp": "2018-06-11T23:32:51.1057915Z",
"perItemErrorCount": 300,
"appliedItemCount": 1000,
"totalItemCount": 2300,
"appliedBytes": 57348983,
"totalBytes": 1958367412
},
"downloadActivity": {
"timestamp": "2018-06-11T23:32:51.1057915Z",
"perItemErrorCount": 0,
"appliedItemCount": 100,
"totalItemCount": 300,
"appliedBytes": 94805587,
"totalBytes": 19583674
},
"offlineDataTransferStatus": "InProgress"
},
"offlineDataTransfer": "on",
"offlineDataTransferStorageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/myRG/providers/Microsoft.Storage/storageAccounts/mysa",
Expand Down
43 changes: 34 additions & 9 deletions ...er/Microsoft.StorageSync/preview/2019-02-01/examples/ServerEndpoints_ListBySyncGroup.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,21 +29,30 @@
"downloadHealth": "Healthy",
"uploadHealth": "Error",
"combinedHealth": "Error",
"syncActivity": null,
"totalPersistentFilesNotSyncingCount": null,
"lastUpdatedTimestamp": "2018-06-11T23:32:51.1057915Z",
"uploadStatus": {
"lastSyncResult": -2134351810,
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncSuccessTimestamp": null,
"lastSyncPerItemErrorCount": 69
"lastSyncSuccessTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"downloadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0
"lastSyncPerItemErrorCount": 1000,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"currentProgress": null,
"offlineDataTransferStatus": "NotRunning"
"uploadActivity": null,
"downloadActivity": null,
"offlineDataTransferStatus": "Complete"
},
"offlineDataTransfer": "on",
"offlineDataTransferStorageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/myRG/providers/Microsoft.Storage/storageAccounts/mysa",
Expand All @@ -68,20 +77,36 @@
"downloadHealth": "Healthy",
"uploadHealth": "Healthy",
"combinedHealth": "Healthy",
"syncActivity": "Upload",
"totalPersistentFilesNotSyncingCount": null,
"lastUpdatedTimestamp": "2018-06-11T23:32:51.1057915Z",
"uploadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"downloadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"uploadActivity": {
"timestamp": "2018-06-11T23:32:51.1057915Z",
"perItemErrorCount": 300,
"appliedItemCount": 1000,
"totalItemCount": 2300,
"appliedBytes": 57348983,
"totalBytes": 1958367412
},
"currentProgress": null,
"downloadActivity": null,
"offlineDataTransferStatus": "NotRunning"
},
"offlineDataTransfer": "off"
Expand Down
73 changes: 41 additions & 32 deletions ...rce-manager/Microsoft.StorageSync/preview/2019-02-01/examples/ServerEndpoints_Update.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,40 +25,49 @@
"body": {
"name": "SampleServerEndpoint_1",
"properties": {
"serverLocalPath": "C:\\data_quota2",
"cloudTiering": "off",
"volumeFreeSpacePercent": 20,
"tierFilesOlderThanDays": 0,
"friendlyName": "somemachine2.redmond.corp.microsoft.com",
"serverResourceId": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/anpintDemoRG/providers/kailanitest07.one.microsoft.com/storageSyncServices/healthdemo1/registeredServers/f94e2944-b48d-4e5b-bdc7-c48ab3712659",
"provisioningState": "Succeeded",
"lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11b",
"lastOperationName": "ICreateServerEndpointWorkflow",
"syncStatus": {
"downloadHealth": "Healthy",
"uploadHealth": "Error",
"combinedHealth": "Error",
"lastUpdatedTimestamp": "2018-06-11T23:32:51.1057915Z",
"uploadStatus": {
"lastSyncResult": -2134351810,
"lastSyncTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncSuccessTimestamp": null,
"lastSyncPerItemErrorCount": 69
},
"downloadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0
},
"currentProgress": null,
"offlineDataTransferStatus": "NotRunning"
"serverLocalPath": "C:\\data_quota2",
"cloudTiering": "off",
"volumeFreeSpacePercent": 20,
"tierFilesOlderThanDays": 0,
"friendlyName": "somemachine2.redmond.corp.microsoft.com",
"serverResourceId": "/subscriptions/3a048283-338f-4002-a9dd-a50fdadcb392/resourceGroups/anpintDemoRG/providers/kailanitest07.one.microsoft.com/storageSyncServices/healthdemo1/registeredServers/f94e2944-b48d-4e5b-bdc7-c48ab3712659",
"provisioningState": "Succeeded",
"lastWorkflowId": "storageSyncServices/healthDemo1/workflows/569afb5c-7172-4cf8-a8ea-d987f727f11b",
"lastOperationName": "ICreateServerEndpointWorkflow",
"syncStatus": {
"downloadHealth": "Healthy",
"uploadHealth": "Error",
"combinedHealth": "Error",
"syncActivity": null,
"totalPersistentFilesNotSyncingCount": null,
"lastUpdatedTimestamp": "2018-06-11T23:32:51.1057915Z",
"uploadStatus": {
"lastSyncResult": -2134351810,
"lastSyncTimestamp": "2018-06-11T23:32:51.1057915Z",
"lastSyncSuccessTimestamp": null,
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"offlineDataTransfer": "off",
"offlineDataTransferStorageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/myRG/providers/Microsoft.Storage/storageAccounts/mysa",
"offlineDataTransferStorageAccountTenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47",
"offlineDataTransferShareName": "myfileshare"
"downloadStatus": {
"lastSyncResult": 0,
"lastSyncTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncSuccessTimestamp": "2018-06-11T23:28:33.9217334Z",
"lastSyncPerItemErrorCount": 0,
"persistentFilesNotSyncingCount": null,
"transientFilesNotSyncingCount": null,
"filesNotSyncingErrors": null
},
"uploadActivity": null,
"downloadActivity": null,
"offlineDataTransferStatus": "Stopping"
},
"offlineDataTransfer": "off",
"offlineDataTransferStorageAccountResourceId": "/subscriptions/744f4d70-6d17-4921-8970-a765d14f763f/resourceGroups/myRG/providers/Microsoft.Storage/storageAccounts/mysa",
"offlineDataTransferStorageAccountTenantId": "72f988bf-86f1-41af-91ab-2d7cd011db47",
"offlineDataTransferShareName": "myfileshare"
},
"id": "/subscriptions/52b8da2f-61e0-4a1f-8dde-336911f367fb/resourceGroups/SampleResourceGroup_1/providers/Microsoft.StorageSync/storageSyncServices/SampleStorageSyncService_1/syncGroups/SampleSyncGroup_1/serverEndpoints/SampleServerEndpoint_1",
"type": "Microsoft.StorageSync/storageSyncServices/syncGroups/serverEndpoints"
}
Expand Down
Loading