Skip to content

Merge Nginx TypeSpec migration changes from RPSaaSMaster of private repo#37743

Merged
SpencerOfwiti merged 5 commits into
mainfrom
sofwiti/nginx-typespec-migration
Sep 25, 2025
Merged

Merge Nginx TypeSpec migration changes from RPSaaSMaster of private repo#37743
SpencerOfwiti merged 5 commits into
mainfrom
sofwiti/nginx-typespec-migration

Conversation

@SpencerOfwiti
Copy link
Copy Markdown
Member

ARM (Control Plane) API Specification Update Pull Request

This PR migrates the latest version, package-preview-2025-03-01, of Nginx swagger to TypeSpec. The original migration is: https://github.com/Azure/azure-rest-api-specs-pr/pull/24013.

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
  • A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
  • For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 25, 2025

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

@github-actions github-actions Bot added ARMReview new-api-version resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required NotReadyForARMReview and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 25, 2025
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Sep 25, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
TypeSpec Nginx.NginxPlus
Go sdk/resourcemanager/nginx/armnginx
C# Azure.ResourceManager.Nginx
JavaScript @azure/arm-nginx
Java com.azure.resourcemanager:azure-resourcemanager-nginx
Swagger Nginx.NginxPlus

@pshao25 pshao25 added Approved-LintDiff BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. labels Sep 25, 2025
@github-actions github-actions Bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 25, 2025
@pshao25 pshao25 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Sep 25, 2025
@github-actions github-actions Bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 25, 2025
@pshao25 pshao25 added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 25, 2025
@SpencerOfwiti SpencerOfwiti merged commit e9da2de into main Sep 25, 2025
74 of 77 checks passed
@SpencerOfwiti SpencerOfwiti deleted the sofwiti/nginx-typespec-migration branch September 25, 2025 08:07
pmoana-ms pushed a commit that referenced this pull request Oct 23, 2025
…epo (#37743)

* Pull TypeSpec changes from RPSaaSMaster of private repo

* Update folder to Pascal case

* Remove old namespace in all caps
qiaozha pushed a commit to Azure/azure-sdk-for-js that referenced this pull request Feb 12, 2026
…36151)

Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml',
API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA:
'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo:
'https://github.com/Azure/azure-rest-api-specs' Pipeline run:
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433740
Refer to
https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites
to prepare for SDK release. **Release plan link:**
[https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68](https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68)
**Submitted by**: briankimutai@microsoft.com
## Release Plan Details
- Release Plan:
https://aka.ms/sdk-release-planner?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68
Spec pull request:
Azure/azure-rest-api-specs#37743
Spec API version: 2025-03-01-preview

---------

Co-authored-by: kazrael2119 <98569699+kazrael2119@users.noreply.github.com>
Co-authored-by: ZiWei Chen <v-ziweichen@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-LintDiff ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version new-rp-namespace PublishToCustomers Acknowledgement the changes will be published to Azure customers. resource-manager RPaaS TypeSpec Authored with TypeSpec

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants