Skip to content

[AutoPR @azure-arm-nginx]-generated-from-SDK Generation - JS-5433740#36151

Merged
qiaozha merged 12 commits into
Azure:mainfrom
azure-sdk:sdkauto/@azure-arm-nginx-5433740
Feb 12, 2026
Merged

[AutoPR @azure-arm-nginx]-generated-from-SDK Generation - JS-5433740#36151
qiaozha merged 12 commits into
Azure:mainfrom
azure-sdk:sdkauto/@azure-arm-nginx-5433740

Conversation

@azure-sdk
Copy link
Copy Markdown
Collaborator

@azure-sdk azure-sdk commented Oct 9, 2025

Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433740 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68 Submitted by: briankimutai@microsoft.com

Release Plan Details

@github-actions github-actions Bot added the Mgmt This issue is related to a management-plane library. label Oct 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Oct 9, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

@azure/arm-nginx

@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Oct 31, 2025

@briankimutai let me know if your release is urgent and currently the release is blocked by some JS internal decisions.

@briantkim93 briantkim93 marked this pull request as ready for review November 7, 2025 10:50
Copilot AI review requested due to automatic review settings November 7, 2025 10:50
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR represents a major architectural migration of the @azure/arm-nginx SDK from an AutoRest-generated implementation to a modern Rest Level Client (RLC) architecture with modular structure. The changes introduce new API versioning (2025-03-01-preview), restructure the codebase with separate api/, classic/, and static-helpers/ layers, and implement improved patterns for long-running operations and pagination.

Key Changes:

  • Migration from AutoRest code generation to RLC-based modular architecture
  • Introduction of static helper modules for URL templating, polling, paging, and cloud settings
  • Complete restructuring of client initialization and operation interfaces
  • Updated TypeScript configuration to use new test base structure
  • Addition of WAF policy operations and updated API models

Reviewed Changes

Copilot reviewed 162 out of 164 changed files in this pull request and generated no comments.

Show a summary per file
File Description
sdk/nginx/ci.mgmt.yml Removed trailing whitespace and blank lines for cleaner formatting
sdk/nginx/arm-nginx/vitest.esm.config.ts Added ESM-specific Vitest configuration
sdk/nginx/arm-nginx/vitest.config.ts Removed leading blank line
sdk/nginx/arm-nginx/tsp-location.yaml Added TypeSpec location metadata for code generation
sdk/nginx/arm-nginx/tsconfig.test.node.json Removed - consolidated into base test config
sdk/nginx/arm-nginx/tsconfig.test.json Simplified to extend from base test configuration
sdk/nginx/arm-nginx/tsconfig.samples.json Reformatted path array for consistency
sdk/nginx/arm-nginx/tsconfig.json Removed empty files array
sdk/nginx/arm-nginx/test/snippets.spec.ts Reordered variable declarations for better code organization
sdk/nginx/arm-nginx/src/static-helpers/urlTemplate.ts Added RFC 6570 URI template expansion implementation
sdk/nginx/arm-nginx/src/static-helpers/pollingHelpers.ts Added LRO polling helper using core-lro primitives
sdk/nginx/arm-nginx/src/static-helpers/pagingHelpers.ts Added pagination helper implementation
sdk/nginx/arm-nginx/src/static-helpers/cloudSettingHelpers.ts Added Azure cloud endpoint resolution utility
sdk/nginx/arm-nginx/src/restorePollerHelpers.ts Added poller restoration functionality for LROs
sdk/nginx/arm-nginx/src/pagingHelper.ts Removed - replaced by static-helpers/pagingHelpers.ts
sdk/nginx/arm-nginx/src/operationsInterfaces/* Removed - replaced by classic/* layer
sdk/nginx/arm-nginx/src/operations/* Removed - replaced by api/* layer
sdk/nginx/arm-nginx/src/nginxManagementClient.ts Completely refactored to use new RLC architecture
sdk/nginx/arm-nginx/src/models/parameters.ts Removed - no longer needed with RLC approach
sdk/nginx/arm-nginx/src/models/models.ts Complete rewrite with serializer/deserializer functions
sdk/nginx/arm-nginx/src/models/mappers.ts Removed - replaced by models.ts serialization
sdk/nginx/arm-nginx/src/models/index.ts Updated to export from new models.ts structure
sdk/nginx/arm-nginx/src/lroImpl.ts Removed - replaced by static-helpers/pollingHelpers.ts
sdk/nginx/arm-nginx/src/logger.ts Added client logger using @azure/logger
sdk/nginx/arm-nginx/src/index.ts Updated exports for new architecture and API surface
sdk/nginx/arm-nginx/src/classic/* Added classic operation interface layer
sdk/nginx/arm-nginx/src/api/* Added new API operation layer
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

@MaryGao
Copy link
Copy Markdown
Member

MaryGao commented Nov 14, 2025

@briankimutai let me know if your release is urgent and currently the release is blocked by some JS internal decisions.

This should be unblocked now since we decided generating from swagger in Nov.

@kazrael2119
Copy link
Copy Markdown
Member

have generated sdk with the generated swagger, @briantkim93, please help review this pr and enable auto-merge if this pr is good to you

Comment thread sdk/nginx/arm-nginx/CHANGELOG.md
Comment thread sdk/nginx/arm-nginx/CHANGELOG.md
@kazrael2119 kazrael2119 added the typespec-based-generated-from-swagger package should be generated based on the generated swagger from typespec label Nov 24, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Hi @azure-sdk. Thank you for your interest in helping to improve the Azure SDK experience and for your contribution. We've noticed that there hasn't been recent engagement on this pull request. If this is still an active work stream, please let us know by pushing some changes or leaving a comment. Otherwise, we'll close this out in 7 days.

@github-actions github-actions Bot added the no-recent-activity There has been no recent activity on this issue. label Jan 30, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 6, 2026

Hi @azure-sdk. Thank you for your contribution. Since there hasn't been recent engagement, we're going to close this out. Feel free to respond with a comment containing /reopen if you'd like to continue working on these changes. Please be sure to use the command to reopen or remove the no-recent-activity label; otherwise, this is likely to be closed again with the next cleanup pass.

@github-actions github-actions Bot closed this Feb 6, 2026
@briantkim93 briantkim93 reopened this Feb 10, 2026
@github-actions github-actions Bot removed the no-recent-activity There has been no recent activity on this issue. label Feb 10, 2026
Comment thread sdk/nginx/arm-nginx/CHANGELOG.md Outdated
Comment thread sdk/nginx/arm-nginx/package.json Outdated
@kazrael2119 kazrael2119 added first-typespec-migration first time to migrate to typespec and removed typespec-based-generated-from-swagger package should be generated based on the generated swagger from typespec labels Feb 12, 2026
@kazrael2119
Copy link
Copy Markdown
Member

LGTM

cc @qiaozha

@qiaozha qiaozha merged commit 9a9fbdf into Azure:main Feb 12, 2026
16 checks passed
@azure-sdk azure-sdk deleted the sdkauto/@azure-arm-nginx-5433740 branch March 22, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

first-typespec-migration first time to migrate to typespec Mgmt This issue is related to a management-plane library. Self-Service Release PR for self-service release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants