[AutoPR sdk-resourcemanager/nginx/armnginx]-generated-from-SDK Generation - Go-5433790#25391
Merged
briantkim93 merged 4 commits intoFeb 9, 2026
Conversation
…, API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433790 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
github-actions
Bot
added
the
Mgmt
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
briantkim93
requested review from
JiaqiZhang-Dev,
lirenhe and
tadelesh
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for WAF (Web Application Firewall) policy management to the Azure NGINX SDK. The changes are primarily focused on adding new client functionality for managing WAF policies in NGINX deployments.
Key changes:
- Addition of
WafPolicyClientandDefaultWafPolicyClientfor managing WAF policies - New models for WAF policy metadata, properties, and status tracking
- Updated API version from 2024-11-01-preview to 2025-03-01-preview across all clients
- Code generator migration from AutoRest to Go Code Generator
Reviewed Changes
Copilot reviewed 38 out of 39 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| wafpolicy_client.go | Implements CRUD operations for WAF policies |
| wafpolicy_client_example_test.go | Example usage of WAF policy client methods |
| defaultwafpolicy_client.go | Client for listing default WAF policies |
| defaultwafpolicy_client_example_test.go | Example for default WAF policy listing |
| models.go | New data structures for WAF policies and status |
| constants.go | Enum types for WAF policy status codes |
| client_factory.go | Factory methods for new WAF policy clients |
| version.go | Updated module version to v3.1.0-beta.3 |
| responses.go | Response types for WAF policy operations |
| options.go | Option types for WAF policy client methods |
| models_serde.go | JSON serialization for WAF policy types |
| fake/* | Test fakes for WAF policy servers |
| go.mod | Dependency updates (Go 1.24.0, updated packages) |
Member
|
/azp run |
|
You have several pipelines (over 10) configured to build pull requests in this repository. Specify which pipelines you would like to run by using /azp run [pipelines] command. You can specify multiple pipelines using a comma separated list. |
Member
|
/azp run go - pullrequest |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tadelesh
approved these changes
Nov 26, 2025
tadelesh
approved these changes
Nov 26, 2025
tadelesh
approved these changes
Jan 14, 2026
Member
|
/azp run prepare-pipelines |
azure-sdk
deleted the
sdkauto/sdk-resourcemanager-nginx/armnginx-5433790
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/nginx/Nginx.Management/tspconfig.yaml', API Version: 2025-03-01-preview, SDK Release Type: beta, and CommitSHA: 'aae85aa3e7e4fda95ea2d3abac0ba1d8159db214' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5433790 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=1ac7ac4d-41a4-f011-bbd3-6045bd07ef68 Submitted by: briankimutai@microsoft.com
Release Plan Details
Spec pull request: Merge Nginx TypeSpec migration changes from RPSaaSMaster of private repo azure-rest-api-specs#37743
Spec API version: 2025-03-01-preview