Add `2025-11-01-preview` version to Microsoft.Subscription by ComradeCow · Pull Request #37722 · Azure/azure-rest-api-specs

ComradeCow · 2025-09-24T15:48:21Z

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

New resource provider.
New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
Update existing version to fix OpenAPI spec quality issues in S360.
Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
Other, please clarify:
- edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
I have reviewed following Resource Provider guidelines, including
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
and https://aka.ms/ci-fix.
For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

github-actions · 2025-09-24T15:48:39Z

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

ComradeCow · 2025-09-24T15:49:14Z

Waiting to merge this until #37575 is merged.

github-actions · 2025-09-24T15:50:49Z

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Swagger	Microsoft.Subscription
Go	sdk/resourcemanager/subscription/armsubscription
C#	Azure.ResourceManager.Subscription
JavaScript	@azure/arm-subscriptions

mikekistler · 2025-09-25T01:10:29Z

Breaking changes previously reviewed and approved in #29912.

sandipsh · 2025-09-26T00:25:19Z

...iption/resource-manager/Microsoft.Subscription/preview/2025-11-01-preview/subscriptions.json

+          "description": "Subscription Changed Target Directory response properties."
+        },
+        "systemData": {
+          "$ref": "../../../../../common-types/resource-management/v5/types.json#/definitions/systemData",


v5

v6 is latest #Resolved

Updated all the shared type references to v6.

sandipsh · 2025-09-26T00:26:25Z

...iption/resource-manager/Microsoft.Subscription/preview/2025-11-01-preview/subscriptions.json

+          "format": "date-time",
+          "x-nullable": true
+        },
+        "sourceOwnerEmail": {


sourceOwnerEmail

could this use a pattern as well?

Is there a pattern for email? I couldn't find examples in the repository.

me neither, low pri/ nice to have.

sandipsh · 2025-09-26T00:27:05Z

...iption/resource-manager/Microsoft.Subscription/preview/2025-11-01-preview/subscriptions.json

+          "description": "The id of the subscription being transferred.",
+          "readOnly": true,
+          "type": "string",
+          "pattern": "^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"


"^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$"

not sure if there is something common for this.

I'm not either, and I'd love to hear if there is. Doing a search through the repo there's a 1001 different ways guids get specified. I originally had "format": "uuid" but was told not to use that because of how it gets interpreted for some SDKs to use a guid type rather than string? Not sure what the best pattern is.

sandipsh · 2025-09-26T00:27:48Z

...iption/resource-manager/Microsoft.Subscription/preview/2025-11-01-preview/subscriptions.json

+          "enum": [
+            "Initialized",
+            "InProgress",
+            "Completed"


pretty self explanatory, but might be helpful to add description to add more context/info for doc purpose. #Resolved

Added the values in x-ms-enum.

sandipsh · 2025-09-26T00:28:48Z

please take a look at the avocado failure as well.

ComradeCow · 2025-09-26T15:40:12Z

The Avocado current errors should be resolved with #37575 as that resolves the MULTIPLE_API_ERROR code. There will be errors remaining for the deprecated apis that we will need the Approved-Avocado tag.

sandipsh · 2025-09-26T19:42:26Z

@ComradeCow are you handling the avocado error? I still see it.

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Updated the API version from preview/2024-08-01-preview to preview/2025-11-01-preview.

ComradeCow · 2025-09-30T02:15:30Z

#37575 has now been merged which cleans up the Avocado errors.

ComradeCow · 2025-10-08T21:17:29Z

(poking to keep this pr from going stale)

ComradeCow · 2025-10-27T15:42:44Z

(poking to keep this pr from going stale)

ComradeCow · 2025-11-17T14:46:53Z

(poking to keep this pr from going stale)

github-actions bot added brownfield Brownfield services will soon be required to convert to TypeSpec. See https://aka.ms/azsdk/typespec. ARMReview new-api-version resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2025

github-actions bot added the BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required label Sep 24, 2025

ComradeCow added the PublishToCustomers Acknowledgement the changes will be published to Azure customers. label Sep 24, 2025

github-actions bot added NotReadyForARMReview BreakingChange-JavaScript-Sdk and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 24, 2025

ComradeCow force-pushed the comradecow/subscription-add-2025-11-01 branch 2 times, most recently from 867dc16 to d6ac262 Compare September 24, 2025 16:11

mikekistler added the BreakingChange-Approved-Previously Changes were reviewed and approved in a previous PR label Sep 25, 2025

github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Sep 25, 2025

sandipsh reviewed Sep 26, 2025

View reviewed changes

sandipsh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2025

ComradeCow force-pushed the comradecow/subscription-add-2025-11-01 branch from d6ac262 to a0ee0b6 Compare September 26, 2025 14:28

ComradeCow removed the ARMChangesRequested label Sep 26, 2025

github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 26, 2025

sandipsh added ARMChangesRequested and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 26, 2025

Scott Kool added 4 commits September 29, 2025 21:03

Copy files from preview/2024-08-01-preview

9bafdd2

Copied the files in a separate commit. This allows reviewers to easily diff subsequent changes against the previous spec.

Update version to preview/2025-11-01-preview

0f50135

Updated the API version from preview/2024-08-01-preview to preview/2025-11-01-preview.

Added tag for 2025-11-01-preview in readme file

ccc90ad

Adding changes for 2025-11-01-preview

9a21c61

ComradeCow force-pushed the comradecow/subscription-add-2025-11-01 branch from a0ee0b6 to 9a21c61 Compare September 30, 2025 02:06

ComradeCow removed the ARMChangesRequested label Sep 30, 2025

github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 30, 2025

github-actions bot removed the BreakingChange-JavaScript-Sdk label Sep 30, 2025

ravimeda added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 30, 2025

ravimeda approved these changes Sep 30, 2025

View reviewed changes

microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Oct 27, 2025

microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Nov 17, 2025

microsoft-github-policy-service bot added no-recent-activity There has been no recent activity on this issue. and removed no-recent-activity There has been no recent activity on this issue. labels Dec 8, 2025

ComradeCow merged commit 2fc7fcc into main Dec 8, 2025
120 of 122 checks passed

ComradeCow deleted the comradecow/subscription-add-2025-11-01 branch December 8, 2025 15:13

Conversation

ComradeCow commented Sep 24, 2025

ARM (Control Plane) API Specification Update Pull Request

PR review workflow diagram

Purpose of this PR

Due diligence checklist

Additional information

Getting help

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

ComradeCow commented Sep 24, 2025

Uh oh!

github-actions bot commented Sep 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

API Change Check

Uh oh!

mikekistler commented Sep 25, 2025

Uh oh!

sandipsh Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ComradeCow Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

sandipsh Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

ComradeCow Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

sandipsh Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

sandipsh Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

ComradeCow Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

sandipsh Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ComradeCow Sep 26, 2025

Choose a reason for hiding this comment

Uh oh!

sandipsh commented Sep 26, 2025

Uh oh!

ComradeCow commented Sep 26, 2025

Uh oh!

sandipsh commented Sep 26, 2025

Uh oh!

ComradeCow commented Sep 30, 2025

Uh oh!

ComradeCow commented Oct 8, 2025

Uh oh!

ComradeCow commented Oct 27, 2025

Uh oh!

ComradeCow commented Nov 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Sep 24, 2025 •

edited

Loading

github-actions bot commented Sep 24, 2025 •

edited

Loading

sandipsh Sep 26, 2025 •

edited

Loading

sandipsh Sep 26, 2025 •

edited

Loading