Skip to content

Add Initiate, Get and Accept Subscription Change Directory Api with new version.#29912

Merged
gary-x-li merged 28 commits intoAzure:mainfrom
abhaygill338:new-version-init-sub-change-request
Aug 16, 2024
Merged

Add Initiate, Get and Accept Subscription Change Directory Api with new version.#29912
gary-x-li merged 28 commits intoAzure:mainfrom
abhaygill338:new-version-init-sub-change-request

Conversation

@abhaygill338
Copy link
Contributor

@abhaygill338 abhaygill338 commented Jul 18, 2024

Add Initiate, Get and Accept Subscription Change Directory Api with new version

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 18, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 18, 2024

PR validation pipeline restarted successfully. This comment will be populated with the 'Swagger Generation Artifacts' report

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jul 18, 2024

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@gary-x-li
Copy link
Contributor

Note to reviewers: The base version of subscriptions.json is 2021-10-01 according to the author.

@abhaygill338 abhaygill338 requested a review from gary-x-li August 14, 2024 22:48
@abhaygill338 abhaygill338 force-pushed the new-version-init-sub-change-request branch from 2b790da to 178d6b3 Compare August 14, 2024 23:41
@openapi-pipeline-app
Copy link

PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts.

@gary-x-li gary-x-li added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Aug 15, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 15, 2024
@gary-x-li gary-x-li added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required Approved-Suppression labels Aug 15, 2024
@gary-x-li gary-x-li removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 15, 2024
@abhaygill338
Copy link
Contributor Author

/pr RequestMerge

@gary-x-li gary-x-li added MergeRequested PublishToCustomers Acknowledgement the changes will be published to Azure customers. labels Aug 16, 2024
@gary-x-li gary-x-li merged commit 546e565 into Azure:main Aug 16, 2024
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
…ew version. (#29912)

* Resolving S320 Item - Missing Get SubscriptionOperations for 2021-10-01 version.

* Fix pipeline suggestions.

* Minor fix.

* Make Get Subscription operations sync in this version.

* Added suppress rules for failing lint errors.

* Fix suppression Issues.

* Minor fix suppression GetOperation200.

* Address minor fixes.

* Address GetOperation200 changes.

* Update readme.md: attempt suppression fix by adding ["202"] to "responses" to path

* Add Initiate, Get and Accept Subscription Change Directory Api with new version.

* Cleaning up the changes in the add-ons inside swagger files.

* Add or modified readme file.

* Fix pipeline issues.

* Fixes on lint errors, model errors.

* Address PR changes.

* Address swagger PR fixes.

* Fixing swagger changes.

* Fix breaking changes paths to include into this new version.

* Fix Prettier Checks.

* Add or Update the parameter location in the swagger.

* Add suppressions for the lint errors + plus request schema changes.

* Suppress lint errors.

* Adding changes to revert initiate and accept subscription changed directory existing behavior swagger.

* Add new version, destination tenant and owner id for subscription initiate and accept change directory.

* Reorder new preview version changes with the latest GA version.

* Adding v5 type error response body.

---------

Co-authored-by: Abhay Pratap <abhaypratap@microsoft.com>
Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved-Suppression ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review BreakingChange-Approved-Benign Changes are not breaking at the REST API level and have at most minor impact to generated SDKs. BreakingChangeReviewRequired <valid label in PR review process>add this label when breaking change review is required new-api-version PublishToCustomers Acknowledgement the changes will be published to Azure customers. ReadyForApiTest <valid label in PR review process>add this label when swagger and service APIs are ready for test resource-manager SuppressionReviewRequired

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants