Removes the 2016 API surface and consolidates specification files

[ComradeCow]

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

• New resource provider.
• New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
• Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
• Update existing version to fix OpenAPI spec quality issues in S360.
• Convert existing OpenAPI spec to TypeSpec spec (do not combine this with implementing changes for a new API version).
• Other, please clarify:
  • Resolving MULTIPLE_API_VERSION error

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

• I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
• I have reviewed following Resource Provider guidelines, including
  ARM resource provider contract and
  REST guidelines (estimated time: 4 hours).
  I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
• A release plan has been created. If not, please create one as it will help guide you through the REST API and SDK creation process.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

• First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
• If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
• To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
• For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
  and https://aka.ms/ci-fix.
• For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
• If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
  This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
• If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.
• For guidance on SDK breaking change review, refer to https://aka.ms/ci-fix.

[github-actions]

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

Comment generated by summarize-checks workflow run.

[github-actions]

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language	API Review for Package
Go	sdk/resourcemanager/subscription/armsubscription
C#	Azure.ResourceManager.Subscription
JavaScript	@azure/arm-subscriptions

[qiaozha]

@mikekistler these APIs already exist in https://github.com/Azure/azure-rest-api-specs/blob/main/specification/resources/resource-manager/Microsoft.Resources/stable/2016-06-01/subscriptions.json and it doesn't belong to Subscription service here.

[sandipsh]

@qiaozha this one seems more recent though? both files are not same. shouldn't they be brought in sync before deleting these?

[sandipsh]

also some examples are mutually exclusive between 2 locations for this version.

[ComradeCow]

@sandipsh I don't understand what you're looking for. It's more recent because it was added when we created the specification for the 2018-03-01-preview API in #2535. I don't see any comments in that PR for why it came in, which is surprising.

At any rate, the Subscription RP isn't serving the /subscription, /subscriptions/{subscriptionId}, /tenants calls for ARM like this spec says. The Microsoft.Subscription version of /tenants says it returns additional properties that are not returned by ARM today. The Subscription RP has no code to handle calls for a 2016-06-01 API, and its manifest doesn't specify a 2016-06-01 api either. These specs are wrong and need to be cleaned up.

[sandipsh]

there are differences as I mentioned above, but as long as these APIs are not already being served by that's a moot point. I am going to approve the PR.

[ComradeCow]

The Avocado Checks are all caused by APIs we previously deprecated. The LintDiff checks are failing on the existing errors for those versions. This PR is ready for review.

[ComradeCow]

@qiaozha , @sandipsh could one of you apply the Approved-Avocado tag on the PR? The check is failing because of previously deprecated APIs.

[qiaozha]

Are those new APIs really being supported in this specific version?

[ComradeCow]

They were APIs originally implemented in 2018-11-01-preview. For 2019-03-01-preview we included this path by referencing that 2018-11-01-preview in the readme here. Adding those operations manually to help resolve the MULTIPLE_API_ERROR Avocado error.

[ComradeCow]

Adding the Approved-Avocado tag on Ravi Eda's advice as the existing errors are all referencing deprecated APIs. We have to manually suppress these issues because of Azure/avocado#150