migrate to LRO APIs for vmware#34243
Merged
cataggar merged 12 commits intoAzure:release-vmware-Microsoft.AVS/2024-09-01from Apr 29, 2025
Merged
migrate to LRO APIs for vmware#34243cataggar merged 12 commits intoAzure:release-vmware-Microsoft.AVS/2024-09-01from
cataggar merged 12 commits intoAzure:release-vmware-Microsoft.AVS/2024-09-01from
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
cataggar
commented
Apr 25, 2025
specification/vmware/resource-manager/Microsoft.AVS/stable/2023-09-01/vmware.json
Outdated
Show resolved
Hide resolved
@extension("x-ms-long-running-operation" for vmware
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
This was referenced Apr 25, 2025
[AutoPR azure-resourcemanager-avs] migrate to LRO APIs for vmware
azure-sdk/azure-sdk-for-java#15969
Closed
8 tasks
cataggar
commented
Apr 25, 2025
markcowl
previously requested changes
Apr 25, 2025
specification/vmware/Microsoft.AVS.Management/privateClouds.tsp
Outdated
Show resolved
Hide resolved
specification/vmware/Microsoft.AVS.Management/placementPolicies.tsp
Outdated
Show resolved
Hide resolved
| "x-ms-long-running-operation-options", | ||
| #{ `final-state-via`: "location" } | ||
| ) | ||
| @armResourceDelete(WorkloadNetworkDnsService) |
Member
There was a problem hiding this comment.
nit, delete as LRO seems to work as the response is
| ArmDeletedResponse
| ArmDeleteAcceptedLroResponse
| ArmDeletedNoContentResponse
| ErrorResponse;
Member
Author
There was a problem hiding this comment.
@weidongxu-microsoft , I'm not sure what you mean.
Member
Author
There was a problem hiding this comment.
As this is a nit, I'm going to merge the PR without this change, but I would still like to know in case it can improve our spec.
weidongxu-microsoft
approved these changes
Apr 27, 2025
Member
weidongxu-microsoft
left a comment
There was a problem hiding this comment.
LGTM. Please wait for Mark's feedback as well. I am not the expert on templates on ARM.
Member
Author
|
I really need to get #32946 merged, so I am unable to wait more. |
1b8c833
into
Azure:release-vmware-Microsoft.AVS/2024-09-01
39 of 44 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is for:
It removes all usage of
x-ms-long-running-operationin the TypeSpec. The resulting OpenAPI is the same. Specifically, it addresses #32946 (comment).ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.