Release vmware Microsoft.AVS/2024-09-01#32946
Conversation
Next Steps to Merge✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge. |
|
PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment. |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews
|
|
The SDK azure-sdk-for-net failure looks like it may be due to: I am not able to reproduce locally with: |
|
SDK azure-sdk-for-java is failing with an error about I am unable to reproduce locally with: Where do we see the version of |
|
There is older issue that make the TypeSpec invalid for SDK. E.g. the LRO is written as This is not a valid LRO in TypeSpec. |
The error is not from the emitter. It is a "checkstyle" check when running the The reason was in my comment above. The related API is not correctly written as LRO. You may choose to ignore this CI failure in this PR (this is not a "required" CI). But you will have to fix it before any SDK release request. |
|
Thanks @weidongxu-microsoft. To address the LRO issues, I created: |
|
It looks like merging requires |
These changes were previously reviewed in PRs linked from https://github.com/Azure/azure-rest-api-specs-pr/pull/19667.
ARM (Control Plane) API Specification Update Pull Request
Tip
Overwhelmed by all this guidance? See the
Getting helpsection at the bottom of this PR description.PR review workflow diagram
Please understand this diagram before proceeding. It explains how to get your PR approved & merged.
Purpose of this PR
What's the purpose of this PR? Check the specific option that applies. This is mandatory!
Due diligence checklist
To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:
ARM resource provider contract and
REST guidelines (estimated time: 4 hours).
I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.
Additional information
Viewing API changes
For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the
Generated ApiViewcomment added to this PR. You can use ApiView to show API versions diff.Suppressing failures
If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.
Getting help
Purpose of this PRandDue diligence checklist.write accessper aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositoriesNext Steps to Mergecomment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.and https://aka.ms/ci-fix.
queuedstate, please add a comment with contents/azp run.This should result in a new comment denoting a
PR validation pipelinehas started and the checks should be updated after few minutes.