Azure · cataggar · Apr 29, 2025 · Apr 25, 2025 · Apr 25, 2025 · Apr 25, 2025
diff --git a/specification/vmware/Microsoft.AVS.Management/authorizations.tsp b/specification/vmware/Microsoft.AVS.Management/authorizations.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface Authorizations {

diff --git a/specification/vmware/Microsoft.AVS.Management/client.tsp b/specification/vmware/Microsoft.AVS.Management/client.tsp
@@ -2,8 +2,6 @@ import "./main.tsp";
 import "@azure-tools/typespec-client-generator-core";
 
 using Azure.ClientGenerator.Core;
-using Azure.ResourceManager.CommonTypes;
-using Microsoft.AVS;
 
 @@clientName(Microsoft.AVS, "AzureVMwareSolutionAPI", "javascript");
 @@clientName(Microsoft.AVS, "AVS", "python");
diff --git a/specification/vmware/Microsoft.AVS.Management/cloudLinks.tsp b/specification/vmware/Microsoft.AVS.Management/cloudLinks.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface CloudLinks {

diff --git a/specification/vmware/Microsoft.AVS.Management/clusters.tsp b/specification/vmware/Microsoft.AVS.Management/clusters.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface Clusters {
@@ -25,34 +24,16 @@ interface Clusters {
     LroHeaders = Azure.Core.Foundations.RetryAfterHeader
   >;
 
-  // This could be modeled with ArmCustomPatchAsync if a 202 response with no body is used instead of a 201.
-  // update is ArmCustomPatchAsync<Cluster, ClusterUpdate>;
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "DO NOT COPY - TODO migrate to LRO apis"
-  @doc("Update a Cluster")
-  @extension("x-ms-long-running-operation", true)
-  @extension(
-    "x-ms-long-running-operation-options",
-    #{ `final-state-via`: "location" }
-  )
-  @armResourceUpdate(Cluster)
-  @patch
-  update(
-    ...ResourceInstanceParameters<Cluster>,
-
-    @bodyRoot
-    @doc("The cluster properties to be updated.")
-    clusterUpdate: ClusterUpdate,
-  ): ArmResponse<Cluster> | {
-    // @doc("Resource update request created.")
-    ...CreatedResponse;
-
-    ...Azure.Core.Foundations.RetryAfterHeader;
-    ...LocationHeader;
-
-    @bodyRoot
-    @doc("The updated cluster.")
-    cluster: Cluster;
-  } | ErrorResponse;
+  @Azure.Core.useFinalStateVia("location")
+  update is ArmCustomPatchAsync<
+    Cluster,
+    ClusterUpdate,
+    Response = Cluster | ArmResourceCreatedResponse<
+      Cluster,
+      LroHeaders = ArmLroLocationHeader<FinalResult = Cluster> &
+        Azure.Core.Foundations.RetryAfterHeader
+    >
+  >;
 
   #suppress "deprecated"
   #suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes"
@@ -63,6 +44,7 @@ interface Clusters {
 }
 
 @@clientName(Clusters.createOrUpdate::parameters.resource, "cluster");
+@@clientName(Clusters.update::parameters.properties, "clusterUpdate");
 
 @doc("Cluster provisioning state")
 union ClusterProvisioningState {

diff --git a/specification/vmware/Microsoft.AVS.Management/common.tsp b/specification/vmware/Microsoft.AVS.Management/common.tsp
@@ -1,9 +1,7 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
 using TypeSpec.Versioning;
 
@@ -37,12 +35,10 @@ model ResourceList<
   FriendlyNameFormat extends valueof string = "{name}List"
 > is Azure.Core.Page<Resource>;
 
-// use { @bodyRoot _: void } with the next version of typespec-azure
-// https://github.com/Azure/typespec-azure/issues/3759
-
-// Just like ArmResourceActionSync, but with no request body.
+/**
+ * Just like ArmResourceActionSync, but with no request body.
+ */
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation"
-#suppress "@azure-tools/typespec-azure-core/documentation-required" "MUST fix in next update"
 @autoRoute
 @armResourceAction(TResource)
 @post
@@ -54,34 +50,32 @@ op ArmResourceActionSyncNoRequestBody<
   ...ResourceInstanceParameters<TResource, TBaseParameters>,
 ): ArmResponse<TResponse> | ErrorResponse;
 
-// Just like ArmResourceActionAsync, but with no request body.
+/**
+ * Like ArmResourceActionAsync, but with no request body and ArmNoContentResponse.
+ */
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation"
-#suppress "@azure-tools/typespec-azure-core/documentation-required" "MUST fix in next update"
 op ArmResourceActionNoContentAsyncNoRequestBody<
   TResource extends Azure.ResourceManager.Foundations.Resource,
   TBaseParameters extends TypeSpec.Reflection.Model = Foundations.BaseParameters<TResource>
-> is ArmResourceActionAsyncBaseNoRequestBody<
+> is ArmResourceActionAsyncBase<
   TResource,
+  void,
   ArmAcceptedLroResponse | ArmNoContentResponse<"Action completed successfully.">,
   TBaseParameters
 >;
 
-// Just like ArmResourceActionAsyncBase, but with no request body.
+/**
+ * Just like ArmAcceptedLroResponse, but with a ResponseBody.
+ */
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-operation"
-#suppress "@azure-tools/typespec-azure-core/documentation-required" "MUST fix in next update"
-#suppress "@azure-tools/typespec-azure-core/no-openapi" "DO NOT COPY - TODO migrate to LRO apis"
-@autoRoute
-@extension("x-ms-long-running-operation", true)
-@extension(
-  "x-ms-long-running-operation-options",
-  #{ `final-state-via`: "location" }
-)
-@armResourceAction(TResource)
-@post
-op ArmResourceActionAsyncBaseNoRequestBody<
-  TResource extends Azure.ResourceManager.Foundations.Resource,
-  TResponse,
-  TBaseParameters extends TypeSpec.Reflection.Model
->(
-  ...ResourceInstanceParameters<TResource, TBaseParameters>,
-): TResponse | ErrorResponse;
+@doc(Description)
+model ArmAcceptedLroResponseWithResponseBody<
+  ResponseBody,
+  Description extends valueof string = "Resource operation accepted.",
+  LroHeaders extends TypeSpec.Reflection.Model = ArmLroLocationHeader &
+    Azure.Core.Foundations.RetryAfterHeader
+> {
+  ...AcceptedResponse;
+  ...LroHeaders;
+  ...Body<ResponseBody>;
+}
diff --git a/specification/vmware/Microsoft.AVS.Management/globalReachConnections.tsp b/specification/vmware/Microsoft.AVS.Management/globalReachConnections.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface GlobalReachConnections {

diff --git a/specification/vmware/Microsoft.AVS.Management/hcxEnterpriseSites.tsp b/specification/vmware/Microsoft.AVS.Management/hcxEnterpriseSites.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface HcxEnterpriseSites {

diff --git a/specification/vmware/Microsoft.AVS.Management/hosts.tsp b/specification/vmware/Microsoft.AVS.Management/hosts.tsp
@@ -1,9 +1,7 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
 using TypeSpec.Versioning;
 

diff --git a/specification/vmware/Microsoft.AVS.Management/iscsiPaths.tsp b/specification/vmware/Microsoft.AVS.Management/iscsiPaths.tsp
@@ -1,11 +1,8 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface IscsiPaths {

diff --git a/specification/vmware/Microsoft.AVS.Management/locations.tsp b/specification/vmware/Microsoft.AVS.Management/locations.tsp
@@ -1,11 +1,8 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
-using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface Locations {

diff --git a/specification/vmware/Microsoft.AVS.Management/placementPolicies.tsp b/specification/vmware/Microsoft.AVS.Management/placementPolicies.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface PlacementPolicies {
@@ -28,33 +27,12 @@ interface PlacementPolicies {
     LroHeaders = Azure.Core.Foundations.RetryAfterHeader
   >;
 
-  // 202 response has a body, but it should not to match ArmCustomPatchAsync.
-  // update is ArmCustomPatchAsync<PlacementPolicy, PlacementPolicyUpdate>;
   #suppress "@azure-tools/typespec-azure-resource-manager/no-response-body"
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "DO NOT COPY - TODO migrate to LRO apis"
-  @doc("Update a PlacementPolicy")
-  @extension("x-ms-long-running-operation", true)
-  @extension(
-    "x-ms-long-running-operation-options",
-    #{ `final-state-via`: "location" }
-  )
-  @armResourceUpdate(PlacementPolicy)
-  @patch
-  update(
-    ...ResourceInstanceParameters<PlacementPolicy>,
-
-    @bodyRoot
-    @doc("The placement policy properties to be updated.")
-    placementPolicyUpdate: PlacementPolicyUpdate,
-  ): ArmResponse<PlacementPolicy> | {
-    ...AcceptedResponse;
-    ...Azure.Core.Foundations.RetryAfterHeader;
-    ...LocationHeader;
-
-    @bodyRoot
-    @doc("The updatd placement policy.")
-    placementPolicy: PlacementPolicy;
-  } | ErrorResponse;
+  update is ArmCustomPatchAsync<
+    PlacementPolicy,
+    PlacementPolicyUpdate,
+    Response = ArmResponse<PlacementPolicy> | ArmAcceptedLroResponseWithResponseBody<PlacementPolicy>
+  >;
 
   #suppress "deprecated"
   #suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes"
@@ -65,6 +43,10 @@ interface PlacementPolicies {
   "placementPolicy"
 );
 
+@@clientName(PlacementPolicies.update::parameters.properties,
+  "placementPolicyUpdate"
+);
+
 @doc("Placement Policy state")
 union PlacementPolicyState {
   string,

diff --git a/specification/vmware/Microsoft.AVS.Management/privateClouds.tsp b/specification/vmware/Microsoft.AVS.Management/privateClouds.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 alias PrivateCloudList = ResourceList<PrivateCloud>;
 @armResourceOperations
@@ -31,34 +30,16 @@ interface PrivateClouds {
     LroHeaders = Azure.Core.Foundations.RetryAfterHeader
   >;
 
-  // This could be modeled with ArmCustomPatchAsync if a 202 response with no body is used instead of a 201.
-  // update is ArmCustomPatchAsync<PrivateCloud, PrivateCloudUpdate>;
-  #suppress "@azure-tools/typespec-azure-core/no-openapi" "DO NOT COPY - TODO migrate to LRO apis"
-  @doc("Update a PrivateCloud")
-  @extension("x-ms-long-running-operation", true)
-  @extension(
-    "x-ms-long-running-operation-options",
-    #{ `final-state-via`: "location" }
-  )
-  @armResourceUpdate(PrivateCloud)
-  @patch
-  update(
-    ...ResourceInstanceParameters<PrivateCloud>,
-
-    @bodyRoot
-    @doc("The private cloud properties to be updated.")
-    privateCloudUpdate: PrivateCloudUpdate,
-  ): ArmResponse<PrivateCloud> | {
-    // @doc("Resource update request created.")
-    ...CreatedResponse;
-
-    ...Azure.Core.Foundations.RetryAfterHeader;
-    ...LocationHeader;
-
-    @bodyRoot
-    @doc("The updated private cloud.")
-    placementPolicy: PrivateCloud;
-  } | ErrorResponse;
+  @Azure.Core.useFinalStateVia("location")
+  update is ArmCustomPatchAsync<
+    PrivateCloud,
+    PrivateCloudUpdate,
+    Response = PrivateCloud | ArmResourceCreatedResponse<
+      PrivateCloud,
+      LroHeaders = ArmLroLocationHeader<FinalResult = PrivateCloud> &
+        Azure.Core.Foundations.RetryAfterHeader
+    >
+  >;
 
   #suppress "deprecated"
   #suppress "@azure-tools/typespec-azure-resource-manager/arm-delete-operation-response-codes"
@@ -80,6 +61,7 @@ interface PrivateClouds {
 }
 
 @@clientName(PrivateClouds.createOrUpdate::parameters.resource, "privateCloud");
+@@clientName(PrivateClouds.update::parameters.properties, "privateCloudUpdate");
 
 @doc("private cloud provisioning state")
 union PrivateCloudProvisioningState {

diff --git a/specification/vmware/Microsoft.AVS.Management/scriptCmdlets.tsp b/specification/vmware/Microsoft.AVS.Management/scriptCmdlets.tsp
@@ -1,11 +1,9 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface ScriptCmdlets {

diff --git a/specification/vmware/Microsoft.AVS.Management/scriptExecutions.tsp b/specification/vmware/Microsoft.AVS.Management/scriptExecutions.tsp
@@ -5,7 +5,6 @@ using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface ScriptExecutions {

diff --git a/specification/vmware/Microsoft.AVS.Management/scriptPackages.tsp b/specification/vmware/Microsoft.AVS.Management/scriptPackages.tsp
@@ -1,11 +1,9 @@
 namespace Microsoft.AVS;
 
-using Azure.ClientGenerator.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
 using TypeSpec.Rest;
-using TypeSpec.Versioning;
 
 @armResourceOperations
 interface ScriptPackages {

diff --git a/specification/vmware/Microsoft.AVS.Management/skus.tsp b/specification/vmware/Microsoft.AVS.Management/skus.tsp
@@ -4,7 +4,6 @@ using Azure.Core;
 using Azure.ResourceManager;
 using TypeSpec.Http;
 using TypeSpec.OpenAPI;
-using TypeSpec.Rest;
 using TypeSpec.Versioning;
 
 #suppress "@azure-tools/typespec-azure-resource-manager/arm-resource-interface-requires-decorator"