Skip to content

[Microsoft.App] Fix managedEnvironments resource type refer and make duration property required for maintenance configuration#31164

Merged
jijohn14 merged 4 commits intoAzure:release-app-Microsoft.App-2024-10-02-previewfrom
jijohn14:jitin/fix-duration-planned-maintenance
Oct 25, 2024
Merged

[Microsoft.App] Fix managedEnvironments resource type refer and make duration property required for maintenance configuration#31164
jijohn14 merged 4 commits intoAzure:release-app-Microsoft.App-2024-10-02-previewfrom
jijohn14:jitin/fix-duration-planned-maintenance

Conversation

@jijohn14
Copy link
Member

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified.
Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
Swagger-Suppression-Process
to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!

The Azure API Review Board is dedicated to helping you create amazing APIs. You can read about our mission and learn more about our process on our wiki.

Click here for links to tools, specs, guidelines & other good stuff

Tooling

Guidelines & Specifications

Helpful Links

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@jijohn14 jijohn14 requested a review from Juliehzl as a code owner October 23, 2024 02:28
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 23, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Oct 23, 2024

@jijohn14 jijohn14 changed the title [Microsoft.App] Make duration property required for maintenance configuration [Microsoft.App] Fix managedEnvironments resource type refer and make duration property required for maintenance configuration Oct 23, 2024
@ramoka178
Copy link
Contributor

Data Plane API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

API Info: The Basics

Most of the information about your service should be captured in the issue that serves as your API Spec engagement record.

  • Link to API Spec engagement record issue:

Is this review for (select one):

  • a private preview
  • a public preview
  • GA release

Change Scope

This section will help us focus on the specific parts of your API that are new or have been modified. Please share a link to the design document for the new APIs, a link to the previous API Spec document (if applicable), and the root paths that have been updated.

  • Design Document:
  • Previous API Spec Doc:
  • Updated paths:

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the Swagger-Suppression-Process to get approval.

❔Got questions? Need additional info?? We are here to help!

Contact us!
Click here for links to tools, specs, guidelines & other good stuff

Getting help

  • First, please carefully read through this PR description, from top to bottom.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

Is this a data plane API?. Please fix form.

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 23, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@ramoka178 ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@ramoka178 ramoka178 removed the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@ramoka178 ramoka178 added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Oct 24, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Oct 24, 2024
@jijohn14 jijohn14 merged commit 6ed0980 into Azure:release-app-Microsoft.App-2024-10-02-preview Oct 25, 2024
Juliehzl added a commit that referenced this pull request Nov 18, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (#31100)

* update

* fix check

* Run prettier for json files (#31142)

* Move java component suppression to global position (#31165)

* FIx AppLogsConfiguration property description (#31185)

* [Microsoft.App] Add running status property for container apps (#31096)

* Add running status

* prettier fix

* fix pretier issues (#31196)

* Make duration a required property (#31164)

* Add jijohn14 as owner (#31183)

* Fix prettier issues (#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (#31389)

* [Microsoft.App] Add private link default domain for managed environment (#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…1066)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (Azure#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (Azure#30700)

* Fix default value property error for keda properties - 08.2024 release (Azure#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (Azure#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (Azure#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (Azure#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (Azure#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (Azure#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (Azure#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (Azure#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (Azure#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (Azure#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (Azure#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (Azure#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (Azure#31100)

* update

* fix check

* Run prettier for json files (Azure#31142)

* Move java component suppression to global position (Azure#31165)

* FIx AppLogsConfiguration property description (Azure#31185)

* [Microsoft.App] Add running status property for container apps (Azure#31096)

* Add running status

* prettier fix

* fix pretier issues (Azure#31196)

* Make duration a required property (Azure#31164)

* Add jijohn14 as owner (Azure#31183)

* Fix prettier issues (Azure#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (Azure#31389)

* [Microsoft.App] Add private link default domain for managed environment (Azure#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(Azure#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants