Skip to content

Support spring cloud gateway#29591

Merged
Caoxuyang merged 3 commits intoAzure:release-app-Microsoft.App-2024-08-02-previewfrom
Caoxuyang:xuyang/0802preview-scg
Jul 4, 2024
Merged

Support spring cloud gateway#29591
Caoxuyang merged 3 commits intoAzure:release-app-Microsoft.App-2024-08-02-previewfrom
Caoxuyang:xuyang/0802preview-scg

Conversation

@Caoxuyang
Copy link
Contributor

@Caoxuyang Caoxuyang commented Jun 26, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

Note

As of January 2024 there is no PR assignee. This is expected. See https://aka.ms/azsdk/pr-arm-review.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

diagram

Click here to see the details of Step 1

Breaking changes review (Diagram Step 1)

If the automation determines you have breaking changes, i.e. Step 1 from the diagram applies to you,
you must follow the breaking changes process.
IMPORTANT This applies even if:

  • The tool fails while it shouldn't, e.g. due to runtime exception, or incorrect detection of breaking changes.
  • You believe there is no need for you to request breaking change approval, for any reason.
    Such claims must be reviewed, and the process is the same.
Click here to see the details of Step 2

ARM API changes review (Diagram Step 2)

Click here to see the diagram footnotes

Diagram footnotes

[1] See ARM review queue (for PR merge queues, see [2]).
[2] public repo merge queue, private repo merge queue (for ARM review queue, [1])
The ARM reviewer on-call engineer visits the merge queue twice a day, so the approximate ETA for merges is 12 - 24 hours.

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been generated using OpenAPI Hub).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with PR workflow diagram Step 2 (ARM review), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@Caoxuyang Caoxuyang requested a review from Juliehzl as a code owner June 26, 2024 07:01
@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 26, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 26, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]
There are no breaking changes.
Compared specs (v0.10.12) new version base version
JavaComponents.json 2024-08-02-preview(eb37940) 2024-02-02-preview(main)
️⚠️LintDiff: 0 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-08 package-preview-2024-08(eb37940) package-preview-2024-08(release-app-Microsoft.App-2024-08-02-preview)

The following errors/warnings exist before current PR submission:

Rule Message
PatchBodyParametersSchema Properties of a PATCH request body must not be required, property:componentType.
Location: Microsoft.App/preview/2024-08-02-preview/JavaComponents.json#L260
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.App/preview/2024-08-02-preview/JavaComponents.json#L36
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.App/preview/2024-08-02-preview/JavaComponents.json#L297
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 26, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from 9c52533ffcab6d7737512600542851e2955f284c. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-appcontainers [Preview SDK Changes]
️🔄 azure-sdk-for-java inProgress [Detail]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 9c52533ffcab6d7737512600542851e2955f284c. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 9c52533ffcab6d7737512600542851e2955f284c. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-appcontainers [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from 9c52533ffcab6d7737512600542851e2955f284c. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️️✔️ azure-powershell succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from 9c52533ffcab6d7737512600542851e2955f284c. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    command	pwsh ./tools/SwaggerCI/psci.ps1 ../azure-powershell_tmp/generateInput.json ../azure-powershell_tmp/generateOutput.json
  • ️✔️Az.app.DefaultTag [Preview SDK Changes]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 26, 2024

@openapi-pipeline-app
Copy link

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️️✔️Breaking Change(Cross-Version) succeeded [Detail] The following breaking changes are detected by comparison with the latest preview version:
Rule Message
Runtime Exception "new":"https://github.com/Azure/azure-rest-api-specs/blob/c1e33fb32e20d4f9a4f5e061ef96c5160be3ae2b/specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/JavaComponents.json",
"old":"https://github.com/Azure/azure-rest-api-specs/blob/main/specification/app/resource-manager/Microsoft.App/preview/2024-02-02-preview/JavaComponents.json",
"details":"Breaking change detector (OAD) invoked AutoRest. AutoRest threw a runtime error. First 20 lines of stack trace follow,
indexed. First line should contain AutoRest command line invocation details. Remaining lines should contain the main message reported by AutoRest.
====================
1: Command failed: node "/mnt/vss/_work/_tasks/AzureApiValidation_5654d05d-82c1-48da-ad8f-161b817f6d41/0.0.107/common/temp/node_modules/.pnpm/@Azure+oad@0.10.12/node_modules/autorest/dist/app.js" --v2 --input-file=specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/JavaComponents.json --output-artifact=swagger-document.json --output-artifact=swagger-document.map --output-file=new --output-folder=/tmp/oad-mhJ1Ld
2: ERROR: Syntax error: unexpected end of the stream within a flow collection
3: - file:///mnt/vss/work/1/azure-rest-api-specs/specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/examples/JavaComponents_CreateOrUpdateSpringCloudGateway.json:120:4
4: FATAL: swagger-document/loader - FAILED
5: FATAL: Error: Syntax errors encountered.
6: Error: Syntax errors encountered."
️🔄LintDiff inProgress [Detail]
️❌Avocado: 1 Errors, 0 Warnings failed [Detail]
Rule Message
JSON_PARSE The file is not a valid JSON file.
json: [preview/2024-08-02-preview/examples/JavaComponents_CreateOrUpdate_SpringCloudGateway.json"}]({"kind":"structure","code":"unexpected end of file","position":{"line":1,"column":1},"token":"}","message":"unexpected end of file, token: }, line: 1, column: 1","url":"/mnt/vss/_work/1/c93b354fd9c14905bb574a8834c4d69b/specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/examples/JavaComponents_CreateOrUpdate_SpringCloudGateway.json"})
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️❌ModelValidation: 2 Errors, 0 Warnings failed [Detail]
Rule Message
unacceptable kind of an object to dump [object Error] "role":"Model Validation",
"url":"https://github.com/Azure/azure-rest-api-specs/blob/c1e33fb32e20d4f9a4f5e061ef96c5160be3ae2b/specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/JavaComponents.json"
unacceptable kind of an object to dump [object Error] "role":"Model Validation",
"url":"https://github.com/Azure/azure-rest-api-specs/blob/c1e33fb32e20d4f9a4f5e061ef96c5160be3ae2b/specification/app/resource-manager/Microsoft.App/preview/2024-08-02-preview/JavaComponents.json"
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️⌛PR Summary pending [Detail]
️⌛Automated merging requirements met pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

Swagger Generation Artifacts

️🔄ApiDocPreview inProgress [Detail]
️⌛ azure-sdk-for-python pending [Detail]
️⌛ azure-sdk-for-java pending [Detail]
️⌛ azure-sdk-for-go pending [Detail]
️⌛ azure-sdk-for-js pending [Detail]
Posted by Swagger Pipeline | How to fix these errors?

@ramoka178
Copy link
Contributor

Are all files committed as needed ? Only seeing 1 file which as new definitions that are not being used ?

Also, please put the first commit to have the latest swagger you have today. Subsequent commits to have the changes you want to make in this PR. This way, reviewers can check what is changing in this PR .

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2024
@Caoxuyang Caoxuyang force-pushed the xuyang/0802preview-scg branch from 9787a39 to ad234e3 Compare June 27, 2024 06:55
@Caoxuyang
Copy link
Contributor Author

Are all files committed as needed ? Only seeing 1 file which as new definitions that are not being used ?

Also, please put the first commit to have the latest swagger you have today. Subsequent commits to have the changes you want to make in this PR. This way, reviewers can check what is changing in this PR .

Okay. Squashed together.

@Juliehzl Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jun 27, 2024
@Caoxuyang
Copy link
Contributor Author

@ramoka178 It seems that I don't have the permission to edit the labels for my pr. Do you have any clue why this is happening? I used to be able to do so.

@Caoxuyang Caoxuyang force-pushed the xuyang/0802preview-scg branch from ad234e3 to b852ff2 Compare June 27, 2024 09:30
@Caoxuyang Caoxuyang force-pushed the xuyang/0802preview-scg branch from b852ff2 to 42c71b7 Compare June 27, 2024 09:37
Copy link
Contributor

@bowen5 bowen5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimLovellSmith TimLovellSmith added VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required labels Jul 3, 2024
"uri"
],
"properties": {
"id": {
Copy link
Member

@TimLovellSmith TimLovellSmith Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to check, is this an azure resource id or not?

Having a writable 'id' property in an Azure rest api is unusual, except in the context of adding references to other resources. In which case often there are few other properties to configure.

It could be confusing compared to Azure resource ids.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would there be a good alternative name for this property?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe I'll have more questions, like what 'scope' is it uniquely identifying things in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's not a Azure resource ID. It can be values like "route1".

The reason is that this spring cloud gateway is an open source middleware. We want to keep the naming convention with the open source configuration to let customers pick it up easier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sample configuration for oss scg:
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, probably the best approach is just to be very explicit in the documentation / description of the property as to what its expected to contain / look like, and e.g. explain what SCG configuration property you're exposing.

"type": "string"
},
"uri": {
"description": "Uri of the route",
Copy link
Member

@TimLovellSmith TimLovellSmith Jul 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Declare as "format": "uri" if its an uri, right

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can be some non url values like "lb:customer-service", which means the gateway will ask the real ip/uri from a service discovery service. So I think string can better surve the case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it maybe consist of other formated "uri"s that I'm not aware of, if the customer is using some other service discovery component to work with the gateway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Is "lb:customer-service" an URI? I guess the answer is maybe, 'lb' is not a well-known scheme. But... maybe its well known in SCG context? I have no idea! :-) (yet)

But more to the point, you now appear to be claiming that it is an URI (in the description) and yet also that its not an URI. Surely only one of these can be the truth?

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 3, 2024
@Caoxuyang Caoxuyang requested a review from jijohn14 as a code owner July 3, 2024 04:51
@Caoxuyang Caoxuyang added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jul 3, 2024
@Caoxuyang Caoxuyang requested a review from TimLovellSmith July 3, 2024 05:01
@TimLovellSmith TimLovellSmith added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 4, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 4, 2024
@Caoxuyang Caoxuyang merged commit e5f2a13 into Azure:release-app-Microsoft.App-2024-08-02-preview Jul 4, 2024
Juliehzl added a commit that referenced this pull request Sep 24, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
jijohn14 added a commit that referenced this pull request Oct 8, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Juliehzl added a commit that referenced this pull request Nov 18, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (#31100)

* update

* fix check

* Run prettier for json files (#31142)

* Move java component suppression to global position (#31165)

* FIx AppLogsConfiguration property description (#31185)

* [Microsoft.App] Add running status property for container apps (#31096)

* Add running status

* prettier fix

* fix pretier issues (#31196)

* Make duration a required property (#31164)

* Add jijohn14 as owner (#31183)

* Fix prettier issues (#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (#31389)

* [Microsoft.App] Add private link default domain for managed environment (#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (Azure#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (Azure#30700)

* Fix default value property error for keda properties - 08.2024 release (Azure#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (Azure#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…1066)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (Azure#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (Azure#30700)

* Fix default value property error for keda properties - 08.2024 release (Azure#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (Azure#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (Azure#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (Azure#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (Azure#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (Azure#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (Azure#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (Azure#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (Azure#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (Azure#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (Azure#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (Azure#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (Azure#31100)

* update

* fix check

* Run prettier for json files (Azure#31142)

* Move java component suppression to global position (Azure#31165)

* FIx AppLogsConfiguration property description (Azure#31185)

* [Microsoft.App] Add running status property for container apps (Azure#31096)

* Add running status

* prettier fix

* fix pretier issues (Azure#31196)

* Make duration a required property (Azure#31164)

* Add jijohn14 as owner (Azure#31183)

* Fix prettier issues (Azure#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (Azure#31389)

* [Microsoft.App] Add private link default domain for managed environment (Azure#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(Azure#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants