Skip to content

Update header and query parameter for source control#29536

Merged
ms-bogdan-rotaru merged 8 commits intoAzure:release-app-Microsoft.App-2024-08-02-previewfrom
Juliehzl:user/zuh/fix-header
Jul 31, 2024
Merged

Update header and query parameter for source control#29536
ms-bogdan-rotaru merged 8 commits intoAzure:release-app-Microsoft.App-2024-08-02-previewfrom
Juliehzl:user/zuh/fix-header

Conversation

@Juliehzl
Copy link
Contributor

@Juliehzl Juliehzl commented Jun 21, 2024

ARM (Control Plane) API Specification Update Pull Request

Tip

Overwhelmed by all this guidance? See the Getting help section at the bottom of this PR description.

PR review workflow diagram

Please understand this diagram before proceeding. It explains how to get your PR approved & merged.

spec_pr_review_workflow_diagram

Purpose of this PR

What's the purpose of this PR? Check the specific option that applies. This is mandatory!

  • New resource provider.
  • New API version for an existing resource provider. (If API spec is not defined in TypeSpec, the PR should have been created in adherence to OpenAPI specs PR creation guidance).
  • Update existing version for a new feature. (This is applicable only when you are revising a private preview API version.)
  • Update existing version to fix OpenAPI spec quality issues in S360.
  • Other, please clarify:
    • edit this with your clarification

Due diligence checklist

To merge this PR, you must go through the following checklist and confirm you understood
and followed the instructions by checking all the boxes:

  • I confirm this PR is modifying Azure Resource Manager (ARM) related specifications, and not data plane related specifications.
  • I have reviewed following Resource Provider guidelines, including
    ARM resource provider contract and
    REST guidelines (estimated time: 4 hours).
    I understand this is required before I can proceed to the diagram Step 2, "ARM API changes review", for this PR.

Additional information

Viewing API changes

For convenient view of the API changes made by this PR, refer to the URLs provided in the table
in the Generated ApiView comment added to this PR. You can use ApiView to show API versions diff.

Suppressing failures

If one or multiple validation error/warning suppression(s) is detected in your PR, please follow the
suppressions guide to get approval.

Getting help

  • First, please carefully read through this PR description, from top to bottom. Please fill out the Purpose of this PR and Due diligence checklist.
  • If you don't have permissions to remove or add labels to the PR, request write access per aka.ms/azsdk/access#request-access-to-rest-api-or-sdk-repositories
  • To understand what you must do next to merge this PR, see the Next Steps to Merge comment. It will appear within few minutes of submitting this PR and will continue to be up-to-date with current PR state.
  • For guidance on fixing this PR CI check failures, see the hyperlinks provided in given failure
    and https://aka.ms/ci-fix.
  • For help with ARM review (PR workflow diagram Step 2), see https://aka.ms/azsdk/pr-arm-review.
  • If the PR CI checks appear to be stuck in queued state, please add a comment with contents /azp run.
    This should result in a new comment denoting a PR validation pipeline has started and the checks should be updated after few minutes.
  • If the help provided by the previous points is not enough, post to https://aka.ms/azsdk/support/specreview-channel and link to this PR.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 21, 2024

Next Steps to Merge

✅ All automated merging requirements have been met! To get your PR merged, see aka.ms/azsdk/specreview/merge.

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 21, 2024

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]
There are no breaking changes.
️❌Breaking Change(Cross-Version): 10 Errors, 2 Warnings failed [Detail]
Compared specs (v0.10.12) new version base version
SourceControls.json 2024-08-02-preview(f140c31) 2024-03-01(main)
SourceControls.json 2024-08-02-preview(f140c31) 2024-02-02-preview(main)

The following breaking changes are detected by comparison with the latest stable version:

Rule Message
1010 - AddingRequiredParameter The required parameter 'x-ms-github-auxiliary' was added in the new version.
New: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L174:11
1010 - AddingRequiredParameter The required parameter 'x-ms-github-auxiliary' was added in the new version.
New: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L240:11
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L204:9
Old: common-types/resource-management/v3/types.json#L204:9
1023 - TypeFormatChanged The new version has a different format 'uuid' than the previous one ''.
New: common-types/resource-management/v5/types.json#L210:9
Old: common-types/resource-management/v3/types.json#L209:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9
1023 - TypeFormatChanged The new version has a different format 'arm-id' than the previous one ''.
New: common-types/resource-management/v5/types.json#L14:9
Old: common-types/resource-management/v3/types.json#L14:9


The following breaking changes are detected by comparison with the latest preview version:

Rule Message
⚠️ 1010 - AddingRequiredParameter The required parameter 'x-ms-github-auxiliary' was added in the new version.
New: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L174:11
⚠️ 1010 - AddingRequiredParameter The required parameter 'x-ms-github-auxiliary' was added in the new version.
New: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L240:11
️⚠️LintDiff: 2 Warnings warning [Detail]
Compared specs (v2.2.2) new version base version
package-preview-2024-08 package-preview-2024-08(f140c31) package-preview-2024-08(release-app-Microsoft.App-2024-08-02-preview)

[must fix]The following errors/warnings are introduced by current PR:

Rule Message Related RPC [For API reviewers]
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L247
⚠️ EnumInsteadOfBoolean Booleans properties are not descriptive in all cases and can make them to use, evaluate whether is makes sense to keep the property as boolean or turn it into an enum.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L254


The following errors/warnings exist before current PR submission:

Rule Message
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L36
ResourceNameRestriction The resource name parameter 'containerAppName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L85
ResourceNameRestriction The resource name parameter 'sourceControlName' should be defined with a 'pattern' restriction.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L85
ProvisioningStateSpecifiedForLROPut 200 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L137
ProvisioningStateSpecifiedForLROPut 201 response schema in long running PUT operation is missing ProvisioningState property. A LRO PUT operations response schema must have ProvisioningState specified for the 200 and 201 status codes.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L137
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L201
DeleteResponseCodes Long-running delete operations must have responses with 202, 204 and default return codes. They also must have no other response codes.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L212
LroLocationHeader A 202 response should include an Location response header.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L269
LroErrorContent Error response content of long running operations must follow the error schema provided in the common types v2 and above.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L278
⚠️ MissingSegmentsInNestedResourceListOperation A nested resource type's List operation must include all the parent segments in its api path.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L36
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L45
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L48
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L58
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L94
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L97
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L114
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L137
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L146
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L149
⚠️ SummaryAndDescriptionMustNotBeSame The summary and description values should not be same.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L212
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L221
⚠️ LatestVersionOfCommonTypesMustBeUsed Use the latest version v5 of types.json.
Location: Microsoft.App/preview/2024-08-02-preview/SourceControls.json#L224
️️✔️Avocado succeeded [Detail] [Expand]
Validation passes for Avocado.
️️✔️SwaggerAPIView succeeded [Detail] [Expand]
️️✔️TypeSpecAPIView succeeded [Detail] [Expand]
️️✔️ModelValidation succeeded [Detail] [Expand]
Validation passes for ModelValidation.
️️✔️SemanticValidation succeeded [Detail] [Expand]
Validation passes for SemanticValidation.
️️✔️SpellCheck succeeded [Detail] [Expand]
Validation passes for SpellCheck.
️️✔️PR Summary succeeded [Detail] [Expand]
Validation passes for Summary.
️️✔️Automated merging requirements met succeeded [Detail] [Expand]
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 21, 2024

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]
 Please click here to preview with your @microsoft account. 
️⚠️ azure-sdk-for-python warning [Detail]
    For more instructions, please refer to the FAQ .
  • ⚠️Warning in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. SDK Automation 14.0.0
    command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-amd64/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Packages (main/binary-all/Packages) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target Translations (main/i18n/Translation-en) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-amd64) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] W: Target CNF (main/cnf/Commands-all) is configured multiple times in /etc/apt/sources.list.d/azure-cli.list:1 and /etc/apt/sources.list.d/azure-cli.sources:1
    cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
    cmderr	[automation_init.sh] npm notice
    cmderr	[automation_init.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[automation_init.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[automation_init.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[automation_init.sh] npm notice
    command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
  • ️✔️azure-mgmt-appcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-java succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. SDK Automation 14.0.0
    command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
    command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
  • ️✔️azure-resourcemanager-appcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-go succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. SDK Automation 14.0.0
    command	sh ./eng/scripts/automation_init.sh ../../../../../azure-sdk-for-go_tmp/initInput.json ../../../../../azure-sdk-for-go_tmp/initOutput.json
    command	generator automation-v2 ../../../../../azure-sdk-for-go_tmp/generateInput.json ../../../../../azure-sdk-for-go_tmp/generateOutput.json
  • ️✔️sdk/resourcemanager/appcontainers/armappcontainers [Preview SDK Changes]
️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]
    For more instructions, please refer to the FAQ .
  • ️✔️Succeeded in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. SDK Automation 14.0.0
    command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
    warn	Warning: File azure-sdk-for-js_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
  • ️✔️@azure/arm-appcontainers [Preview SDK Changes]
️❌ azure-resource-manager-schemas failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. Schema Automation 14.0.0
    command	.sdkauto/initScript.sh ../azure-resource-manager-schemas_tmp/initInput.json ../azure-resource-manager-schemas_tmp/initOutput.json
    cmderr	[initScript.sh] Submodule 'bicep-types-az' (https://github.com/Azure/bicep-types-az) registered for path 'bicep-types-az'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az'...
    cmderr	[initScript.sh] Submodule 'bicep-types' (https://github.com/Azure/bicep-types) registered for path 'bicep-types-az/bicep-types'
    cmderr	[initScript.sh] Cloning into '/mnt/vss/_work/1/s/azure-resource-manager-schemas/bicep-types-az/bicep-types'...
    cmderr	[initScript.sh] npm notice
    cmderr	[initScript.sh] npm notice New minor version of npm available! 10.7.0 -> 10.8.1
    cmderr	[initScript.sh] npm notice Changelog: https://github.com/npm/cli/releases/tag/v10.8.1
    cmderr	[initScript.sh] npm notice To update run: npm install -g npm@10.8.1
    cmderr	[initScript.sh] npm notice
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/initScript.sh
    warn	Warning: File azure-resource-manager-schemas_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    command	.sdkauto/generateScript.sh ../azure-resource-manager-schemas_tmp/generateInput.json ../azure-resource-manager-schemas_tmp/generateOutput.json
    cmderr	[generateScript.sh] /mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500
    cmderr	[generateScript.sh]     return new TSError(diagnosticText, diagnosticCodes)
    cmderr	[generateScript.sh]            ^
    cmderr	[generateScript.sh] TSError: ⨯ Unable to compile TypeScript:
    cmderr	[generateScript.sh] cmd/generateall.ts(6,20): error TS2307: Cannot find module 'colors' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(10,19): error TS2307: Cannot find module 'yargs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(11,18): error TS2307: Cannot find module 'path' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(13,35): error TS2307: Cannot find module 'fs' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(14,23): error TS2307: Cannot find module 'strip-ansi' or its corresponding type declarations.
    cmderr	[generateScript.sh] cmd/generateall.ts(42,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(53,9): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(69,67): error TS7006: Parameter 'x' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(70,49): error TS7006: Parameter 'f' implicitly has an 'any' type.
    cmderr	[generateScript.sh] cmd/generateall.ts(94,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(105,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(106,21): error TS2584: Cannot find name 'console'. Do you need to change your target library? Try changing the 'lib' compiler option to include 'dom'.
    cmderr	[generateScript.sh] cmd/generateall.ts(157,13): error TS2591: Cannot find name 'process'. Do you need to install type definitions for node? Try `npm i --save-dev @types/node` and then add 'node' to the types field in your tsconfig.
    cmderr	[generateScript.sh]     at createTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:500:12)
    cmderr	[generateScript.sh]     at reportTSError (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:504:19)
    cmderr	[generateScript.sh]     at getOutput (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:739:36)
    cmderr	[generateScript.sh]     at Object.compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:955:32)
    cmderr	[generateScript.sh]     at Module.m._compile (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1043:43)
    cmderr	[generateScript.sh]     at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    cmderr	[generateScript.sh]     at Object.require.extensions.<computed> [as .ts] (/mnt/vss/_work/1/a/unified-pipeline-runtime/common/temp/node_modules/.pnpm/ts-node@9.0.0_typescript@5.3.3/node_modules/ts-node/src/index.ts:1046:12)
    cmderr	[generateScript.sh]     at Module.load (node:internal/modules/cjs/loader:1203:32)
    cmderr	[generateScript.sh]     at Function.Module._load (node:internal/modules/cjs/loader:1019:12)
    cmderr	[generateScript.sh]     at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    error	Script return with result [failed] code [1] signal [null] cwd [azure-resource-manager-schemas]: .sdkauto/generateScript.sh
    warn	Warning: Package processing is skipped as the SDK generation fails. Please look into the above generation errors or report this issue through https://aka.ms/azsdk/support/specreview-channel.
️❌ azure-powershell failed [Detail]
    For more instructions, please refer to the FAQ .
  • Code Generator Failed in generating from d63d0970a1933ab52997e7d5c4703fb860ea8d6c. SDK Automation 14.0.0
    command	sh ./tools/SwaggerCI/init.sh ../azure-powershell_tmp/initInput.json ../azure-powershell_tmp/initOutput.json
    error	Script return with result [failed] code [2] signal [null] cwd [azure-powershell]: sh ./tools/SwaggerCI/init.sh
    warn	Warning: File azure-powershell_tmp/initOutput.json not found to read. Please re-run the pipeline if the error is transitient error or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    error	FatalError: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'. Please refer to the inner logs for details or report this issue through https://aka.ms/azsdk/support/specreview-channel.
    ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'
    error	ErrorStack: Error: ENOENT: no such file or directory, open 'azure-powershell_tmp/generateInput.json'    at Object.openSync (node:fs:596:3)    at Object.writeFileSync (node:fs:2322:35)    at writeTmpJsonFile (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/utils/fsUtils.js:125:18)    at workflowCallGenerateScript (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:593:36)    at workflowHandleReadmeMdOrTypeSpecProject (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:239:46)    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)    at async workflowMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/workflow.js:107:9)    at async sdkAutoMain (/mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/automation/entrypoint.js:217:13)    at async /mnt/vss/_work/1/a/unified-pipeline-runtime/private/openapi-sdk-automation/lib/cli/cli.js:20:18.
Posted by Swagger Pipeline | How to fix these errors?

@openapi-pipeline-app
Copy link

openapi-pipeline-app bot commented Jun 21, 2024

"description": "Delete workflow.",
"required": false,
"type": "boolean"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please explain on what are these ?

If the API is deleting sourcecontrol resource, why are these needed ?
Can it be a different API to delete workflows ?

Copy link
Contributor Author

@Juliehzl Juliehzl Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When creating source control resource, we will create a github workflow for customer. When deleting source control, we give customer the option to only delete source control resource or delete source control and created workflow together.

There is no need to delete workflows because it is a backend resource and not exposed to customer directly, which is also the design from day one. Here is to fix swagger mismatch.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, are these working APIs today that the customers are using with ignoreWorkflowDeletionFailure and deleteWorkflow query params ?

Delete is supposed to delete only a single resource.

Could you post any approval that these query parameters could be used ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, we're deleting single resource (which is the SourceControl proxy resource). The option to delete the GH workflow file is just a consolidated option for convenience for the user to cleanup any leftover files.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ARMBlockingComment] If GH work flow is implicitly created on a source control creation, the deletion of source control resource should also result in deleting GH workflow . There should not be an extra query param for user to pass to clean up GH workflow.

Please schedule a slot in ARM API Review office hours that happens every day to discuss further on this.
https://eng.ms/docs/products/arm/introduction/office_hours

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you get a review for this matter?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 25, 2024
@Juliehzl Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jun 26, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jun 26, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the no-recent-activity There has been no recent activity on this issue. label Jul 15, 2024
@Juliehzl Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jul 19, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 22, 2024
@Juliehzl Juliehzl requested a review from jijohn14 as a code owner July 30, 2024 08:30
@Juliehzl Juliehzl added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed ARMChangesRequested labels Jul 30, 2024
@Juliehzl
Copy link
Contributor Author

same change with #29570. please signoff

@ms-bogdan-rotaru ms-bogdan-rotaru added the ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review label Jul 30, 2024
@openapi-pipeline-app openapi-pipeline-app bot removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jul 30, 2024
@Juliehzl
Copy link
Contributor Author

/pr RequestMerge

@ms-bogdan-rotaru ms-bogdan-rotaru merged commit 0263161 into Azure:release-app-Microsoft.App-2024-08-02-preview Jul 31, 2024
Juliehzl added a commit that referenced this pull request Sep 24, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
jijohn14 added a commit that referenced this pull request Oct 8, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Juliehzl added a commit that referenced this pull request Nov 18, 2024
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (#31100)

* update

* fix check

* Run prettier for json files (#31142)

* Move java component suppression to global position (#31165)

* FIx AppLogsConfiguration property description (#31185)

* [Microsoft.App] Add running status property for container apps (#31096)

* Add running status

* prettier fix

* fix pretier issues (#31196)

* Make duration a required property (#31164)

* Add jijohn14 as owner (#31183)

* Fix prettier issues (#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (#31389)

* [Microsoft.App] Add private link default domain for managed environment (#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (#30627)

* Fix CI check for 2024-08-02-preview (#30641)

* add suppression for patch java component (#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (#30700)

* Fix default value property error for keda properties - 08.2024 release (#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (Azure#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (Azure#30700)

* Fix default value property error for keda properties - 08.2024 release (Azure#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Add Identity to session pool registry (Azure#30748)

* Add Identity to session pool registry

* update examples

* fix

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
pjpatel12 pushed a commit to pjpatel12/azure-rest-api-specs that referenced this pull request Apr 29, 2025
…1066)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix Swagger PrettierCheck for examples (Azure#30674)

* Copy files from preview/2024-02-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-08-02-preview

Updated the API version from preview/2024-02-02-preview to preview/2024-08-02-preview.

* Added tag for 2024-08-02-preview in readme file

* Support spring cloud gateway (Azure#29591)

* support scg in 0802preview

* fix lint issue

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Add scale property to java component (Azure#29801)

* add scale property for jc

* swagger prettiercheck

* prettier check

* the prettier check has a bug

* edit description

* refine description

---------

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* [Microsoft.App] add debug endpoint on replica container (Azure#29778)

* add debug endpoint on replica container

* fix code style errors

* add example debug endpoint

* Update header and query parameter for source control (Azure#29536)

* update

* fix example

* fix

* fix

* fix

* update examples

* use v5

* Enable DeploymentErrors for ContainerApps (Azure#29822)

* Enable DeploymentErrors for ContainerApps

* Add example

* Fix format

---------

Co-authored-by: layliu <layliu@microsoft.com>

* Add dockerfile path argument (Azure#30156)

* Add dockerfile path argument

* Fix example

* Fix example

* Fix linting errors

* Modify example

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* Add KEDA cooldownPeriod/pollingInterval property for Container App & Jobs (Azure#30154)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Make the header optional for source control (Azure#30232)

* Add includeDapr in traces and include keda in metrics for container app environment (Azure#29987)

* Add includeDapr in traces and include keda in metrics

* pretty

* Fix sessionpool name parameter location (Azure#30231)

* Fix sessionpool name parameter location

* Prettier

* Add job suspend resume (Azure#30304)

* add fields

* add

* Update Jobs.json

fix runningState and add azure-asyncoperation

* Update Jobs_Resume.json

* Update Jobs_Suspend.json

* add azure-asyncoperation

* fix lintdiff

* fix

* fix

* fix

* add

* reopen PR & add runningState states

---------

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* add runningState change (Azure#30464)

Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>

* [Microsoft.App] Add enableFips property for dedicated workload profiles (Azure#30418)

* enableFips Property for workload profile

* Fix description

* Add default value for property

* run prettier

* More prettier fixes

* Add system data back for billingMeter (Azure#30627)

* Fix CI check for 2024-08-02-preview (Azure#30641)

* add suppression for patch java component (Azure#30644)

Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>

* Fix session pool error response (Azure#30647)

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* update

---------

Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: Jitin John <jijohn@microsoft.com>

* revert change (Azure#30700)

* Fix default value property error for keda properties - 08.2024 release (Azure#30691)

* Add cooldownPeriod property to Jobs.json and Job_CreateorUpdate_EventTrigger.json-TEW

* PR Feedback: Run prettier on json file for PR check-TEW

* PR Feedback: Update ARM for Container Apps with both cooldown and polling properties; Update jobs.json with missing cooldown Period reference-TEW

* PR Feedback: Update ContainerApp examples with KEDA properties cooldownPeriod/pollingInterval-TEW"

* PR Feedback: Re-ran prettier on files noted in PR Check-TEW

* Removing cooldownPeriod from Jobs.json and Jobs examples-TEW

* Remove default for polling and cooldown to fix error-TEW

* Copy files from preview/2024-08-02-preview

Copied the files in a separate commit.
This allows reviewers to easily diff subsequent changes against the previous spec.

* Update version to preview/2024-10-02-preview

Updated the API version from preview/2024-08-02-preview to preview/2024-10-02-preview.

* Added tag for 2024-10-02-preview in readme file

* Add Identity to session pool 2024-08-02-preview (Azure#30770)

* Add Identity to session pool registry

* update examples

* fix

* Easyauth blob token store support msi to auth (Azure#30923)

* easyauth blob token store support msi to auth

* update examples

* update

* update

* lint

* lint

* add examples

* Enable Async Operation for ConnectedEnvironment SubResources (Azure#30782)

* Enable Async Operation for ConnectedEnvironment SubResources

* Fixes

* Fixes for comments

* Fix DaprComponentDefinition

* Fixes for comments

---------

Co-authored-by: layliu <layliu@microsoft.com>

* [Microsoft.App] Add gpu property to container resource (Azure#30852)

* Add GPU property to container resources

* Update example

* Fix linting

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/CommonDefinitions.json

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Update example

* Fix linting

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* revision transition threshold (Azure#30978)

* add revisionTransitionThreshold

* run npx prettier

* npx prettier second time

* run npx prettier

* switch from DaprComponent to DaprComponentProperties

* run npx prettier

* add min and max to description

* add minumum and maximum

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] targetLabel and Labels revision mode (Azure#30802)

* copy over changes to 10-02

* add targetLabel

* ran npx prettier

* ran npx prettier

* update examples

* add patterns to parameter defns

* add x-ms-pageable to label history required for all list api

* fix next link properties

* add null next link

* fix wrong label history ref

* update readme file to correct alphabetical order

* fix npx prettier

* fix examples

* run npx prettier

* fix get object reference

* fix label history structure

* fix label history item schema

* fix examples

* fix label history list

* fix label history record item properties

* fix label history model

* add resource id to labels history

* fix resource id

* run npx prettier

* fix resource id

* fix labels example

* fix label history json

* fix label history uri

* rename containerapp name example and remove from container app create

* move containerappname parameter to common defns

* Trigger checks

* Update sdk-suppressions.yaml

---------

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>

* [Microsoft.App] Add availabilityZones property to managed environment (Azure#30781)

* Add availabilityZones

* Fix prettier

* Fix prettier part 2

* prettier-3

* Rename to zones

* zones must be a top level property

* Switch property to availabilityZones

* Add auto bind as an option for custom domain cert binding (Azure#30993)

* Add auto bind as an option for custom domain cert binding

* fix prettier ci

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* add ManagedIdentitySettings to session pool 2024-10-02-preview (Azure#30771)

* add ManagedIdentitySettings to session pool 2024-10-02-preview

* fix

* fix prettier

* fix

* add identity to sessionpool

* fix PatchIdentityProperty

* fix description

* fix lint

* fix patch error

* fix prettier

* fix model

* fix comments

* revert useless change

---------

Co-authored-by: Nan Jiang <naji@microsoft.com>

* [Microsoft.App] Planned Maintenance feature for managed environment (Azure#30769)

* first iteration

* Fix and update example

* prettier fix

* Update parameter references

* Fix list reference

* Add definitions

* Update reference to scheduled entries

* Use ScheduleEntries

* Another attempt

* Fix typo

* Update readme

* Remove ManagedEnvironmentScheduleList

* Remove location and unwanted tags

* Remove un-needed code

* Make it a proxy resource

* Fix lint errors

* Use v5 type

* Fix json

* Fix sub example

* Rename envelope variable

* Fix name in example

* Use weekday

* Use scheduledEntries

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Update specification/app/resource-manager/Microsoft.App/preview/2024-10-02-preview/MaintenanceConfigurations.json

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Rename file

* Add main file

---------

Co-authored-by: Zunli Hu <zuh@microsoft.com>

* [Microsoft.App] Advanced Ingress ACA - 2024-10-02-preview (Azure#30862)

* Advanced Ingress ACA - 2024-10-02-preview

* use existing custom domain reference

* make containerAppName required

* Resolve comments

* fix prettier check. update patch to allow more prop updates

* update patch

* fix ci, add patch envelope

* add description field to route rules

* update examples

* remove long running operation reference

* mark put as non long running

* resolve comments, refactor

* separet PATCH out again

* add 201 back due to arm validations requirement, rename to `containerApp` && `revision` under targets

* rename

* prettier ci fix

* fix pretty ci

* change to proxy resource, resolve comments, rename, fix merge conflict

* remove tag support, patch same as create/update

---------

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Co-authored-by: Zunli Hu <zuh@microsoft.com>

* Fix managed service identity duplicated schema issue (Azure#31100)

* update

* fix check

* Run prettier for json files (Azure#31142)

* Move java component suppression to global position (Azure#31165)

* FIx AppLogsConfiguration property description (Azure#31185)

* [Microsoft.App] Add running status property for container apps (Azure#31096)

* Add running status

* prettier fix

* fix pretier issues (Azure#31196)

* Make duration a required property (Azure#31164)

* Add jijohn14 as owner (Azure#31183)

* Fix prettier issues (Azure#31226)

* Ran prettier command for all examples

* Add back x-ms-client-flatten to ConnectedEnvironmentsDaprComponents.json (Azure#31389)

* [Microsoft.App] Add private link default domain for managed environment (Azure#31216)

* update

* add example

* fix prettier

* fix example

---------

Co-authored-by: Jitin John <jijohn@microsoft.com>

* Use v5 resource types(Azure#31545)

---------

Co-authored-by: Juliehzl <zuh@microsoft.com>
Co-authored-by: Xuyang Cao <Elvis_caoxy@163.com>
Co-authored-by: Xuyang Cao <Xuyang.Cao@microsoft.com>
Co-authored-by: Yi Liu <yiliu6@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: layliu <layliu@microsoft.com>
Co-authored-by: snehapar9 <108305436+snehapar9@users.noreply.github.com>
Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Co-authored-by: Tara W <tawalke@users.noreply.github.com>
Co-authored-by: Michael Dai <michaelkira@live.cn>
Co-authored-by: yitaopan <yitaopan@microsoft.com>
Co-authored-by: bgashirabake <85650284+bgashirabake@users.noreply.github.com>
Co-authored-by: bgashirabake@gmail.com <bgashirabake@microsoft.com>
Co-authored-by: najian <jiangnan8924@gmail.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: Stacy Zeng <42949747+smzeng@users.noreply.github.com>
Co-authored-by: Taher Darolywala <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: Nan Jiang <naji@microsoft.com>
Co-authored-by: Taher Huzefa <taherhuzefa@Tahers-MacBook-Pro-2.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMReview ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review resource-manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants