chore: Feedback from 8/9#30187
Merged
nonsocode merged 21 commits intoAzure:release/0.7.0-previewfrom Aug 13, 2024
Merged
Conversation
Next Steps to MergeNext steps that must be taken to merge this PR:
|
Generated ApiView
|
AzureRestAPISpecReview
added
ARMReview
resource-manager
RPaaS
WaitForARMFeedback
chgennar
reviewed
Aug 13, 2024
specification/iotoperations/IoTOperations.Management/models/broker/authentications.tsp
Outdated
Show resolved
Hide resolved
chgennar
reviewed
Aug 13, 2024
|
|
||
| @doc("Resource identifier (application ID URI) of the resource, affixed with the .default suffix.") | ||
| scope: string; | ||
| audience?: string; |
Contributor
There was a problem hiding this comment.
John Lian has asked to keep this as scope
Member
Author
There was a problem hiding this comment.
Is this just for User assigned idenity?
chgennar
reviewed
Aug 13, 2024
|
|
||
| @doc("X.509 authentication configuration.") | ||
| x509Certificate: "x509Certificate", | ||
| x509: "X509", |
Contributor
There was a problem hiding this comment.
key should probably X509 as well
chgennar
reviewed
Aug 13, 2024
| @@ -117,12 +114,6 @@ model DataFlowInstanceProperties { | |||
| enabled: boolean; | |||
Contributor
There was a problem hiding this comment.
we should decorate all these enabled fields with @visibility("create", "read")
https://typespec.io/docs/standard-library/built-in-decorators#@visibility
Contributor
There was a problem hiding this comment.
also, should we consider having these also use the OperationalMode enum instead of being boolean type?
Member
Author
There was a problem hiding this comment.
I'll bring this up with Ro, but I agree. we should align with the rest of the RP
hmmorales
added a commit
that referenced
this pull request
Aug 15, 2024
* init PR * remove placeholder * Revert "remove placeholder" This reverts commit 8a31865. * init 2024-08-15-preview * enforce only latest version gets changed * remove placeholder * Release/0.7.0 preview (#30109) * Some changes * DataFlow -> Dataflow * More updates * Ran Henry's Build Tool * revert old examples * remaining files * Updating secret ref (#30113) * Release/0.7.0 preview (#30114) * Update schema registry ref based on review * More updates... * Schema Registry Regex * Update examples * identity update * Update examples * Update examples * Update examples * feat: Add support for Identity and service accounts in instance (#30127) * add readonly service account fields * sap * generate examples * bring auth into props (#30121) * changes to dataflowendpoint and auth to bring authentication properties to each setting * ran script * endpointType and revert for secretRef * clean up description, make authentication required, remove accesstokensetting from onelake * add auth to each method * scope down each auth method * scope down unions * remove general auth object * organization * ran tool * sasl to sat * ran examples * examples * service account x-ms-identifiers * examples * tsv * Add clientId (#30130) * Add clientId * ... * Rm @disciminator (#30131) * Bring back examples (#30132) * add example file back (#30134) * Make auth required (#30136) * make auth required in mqtt and kafka methods * rename certificatesettings * examples * feat: add flags for aio services (#30135) * commit flags * commit examples * Merge upstream * examples * examples (#30139) * spell check * spellcheck * feat: Add identity support to patch operation (#30145) * support_identity * lint * patch MI * should work * lint * Patch Fix & Update ClientId Doc (#30140) * fix * fix * patch fix and clientid fix * examples * tsv * x509CertificateSettings in BrokerAuth (#30146) * fix: revert brokerauth x509 changes (#30149) * Add examples for Broker (#30152) * Add Broker examples * Fix typo * Better listener example * fix up examples and remove example gen (#30171) * Remove reference to orchestrator * chore: Feedback from 8/9 (#30187) * Audience, SecretRef, TLS * CloudEventAttributeType * x509 * update schema * PR feedback * schema update * key as well * remove MQ disable/enable * bring back broker * generate schema * format * make props read-only * remove mq * schema update * make togles read write * schema update * use mode flags * new line * switch to state * state * Add dataflow examples (#30192) * fix examples (#30195) * fix examples * fix * typo * instance examples * another typo * fix: Remove service accounts from instance (#30198) * remove Service accounts * update instance defintion * sync changes * fix: re-add Instance examples to (#30199) * remove Service accounts * update instance defintion * sync changes * examples * examples * update second example * Instance schema and example update * chore: Fix typos in Aio types (#30205) * fix: Rename secretName to secretRef (#30208) * suppression (#30209) * fix secretName (#30211) * fix: update examples (#30212) * update examples * push other examples * typo (#30213) * fix: Adressed half of the issues (#30216) * Adressed half * gen * model validation pass * model validation (#30218) * 201 (#30219) * fix * Model validation pass 4 (#30220) * update batching * example gen * Model validation pass 5 (#30221) * Revert "Model validation pass 4 (#30220)" This reverts commit d73c5c8. * ... * fix: lower case d (#30236) * fix: Lowercase d in dataflow * uncomment supression * supress path * schema * drill down * stop at identity * run gen --------- Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com> Co-authored-by: Chinonso Chukwuogor <nonsochukwuogor@gmail.com> Co-authored-by: John Lian <jlian@users.noreply.github.com>
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
* init PR * remove placeholder * Revert "remove placeholder" This reverts commit 8a31865. * init 2024-08-15-preview * enforce only latest version gets changed * remove placeholder * Release/0.7.0 preview (#30109) * Some changes * DataFlow -> Dataflow * More updates * Ran Henry's Build Tool * revert old examples * remaining files * Updating secret ref (#30113) * Release/0.7.0 preview (#30114) * Update schema registry ref based on review * More updates... * Schema Registry Regex * Update examples * identity update * Update examples * Update examples * Update examples * feat: Add support for Identity and service accounts in instance (#30127) * add readonly service account fields * sap * generate examples * bring auth into props (#30121) * changes to dataflowendpoint and auth to bring authentication properties to each setting * ran script * endpointType and revert for secretRef * clean up description, make authentication required, remove accesstokensetting from onelake * add auth to each method * scope down each auth method * scope down unions * remove general auth object * organization * ran tool * sasl to sat * ran examples * examples * service account x-ms-identifiers * examples * tsv * Add clientId (#30130) * Add clientId * ... * Rm @disciminator (#30131) * Bring back examples (#30132) * add example file back (#30134) * Make auth required (#30136) * make auth required in mqtt and kafka methods * rename certificatesettings * examples * feat: add flags for aio services (#30135) * commit flags * commit examples * Merge upstream * examples * examples (#30139) * spell check * spellcheck * feat: Add identity support to patch operation (#30145) * support_identity * lint * patch MI * should work * lint * Patch Fix & Update ClientId Doc (#30140) * fix * fix * patch fix and clientid fix * examples * tsv * x509CertificateSettings in BrokerAuth (#30146) * fix: revert brokerauth x509 changes (#30149) * Add examples for Broker (#30152) * Add Broker examples * Fix typo * Better listener example * fix up examples and remove example gen (#30171) * Remove reference to orchestrator * chore: Feedback from 8/9 (#30187) * Audience, SecretRef, TLS * CloudEventAttributeType * x509 * update schema * PR feedback * schema update * key as well * remove MQ disable/enable * bring back broker * generate schema * format * make props read-only * remove mq * schema update * make togles read write * schema update * use mode flags * new line * switch to state * state * Add dataflow examples (#30192) * fix examples (#30195) * fix examples * fix * typo * instance examples * another typo * fix: Remove service accounts from instance (#30198) * remove Service accounts * update instance defintion * sync changes * fix: re-add Instance examples to (#30199) * remove Service accounts * update instance defintion * sync changes * examples * examples * update second example * Instance schema and example update * chore: Fix typos in Aio types (#30205) * fix: Rename secretName to secretRef (#30208) * suppression (#30209) * fix secretName (#30211) * fix: update examples (#30212) * update examples * push other examples * typo (#30213) * fix: Adressed half of the issues (#30216) * Adressed half * gen * model validation pass * model validation (#30218) * 201 (#30219) * fix * Model validation pass 4 (#30220) * update batching * example gen * Model validation pass 5 (#30221) * Revert "Model validation pass 4 (#30220)" This reverts commit d73c5c8. * ... * fix: lower case d (#30236) * fix: Lowercase d in dataflow * uncomment supression * supress path * schema * drill down * stop at identity * run gen --------- Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com> Co-authored-by: Chinonso Chukwuogor <nonsochukwuogor@gmail.com> Co-authored-by: John Lian <jlian@users.noreply.github.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Choose a PR Template
Switch to "Preview" on this description then select one of the choices below.
Click here to open a PR for a Data Plane API.
Click here to open a PR for a Control Plane (ARM) API.