chore: Feedback from 8/9

specification/iotoperations/IoTOperations.Management/models/auth.tsp

@@ -11,7 +11,7 @@ namespace Microsoft.IoTOperations;
 @doc("DataflowEndpoint Authentication SystemAssignedManagedIdentity properties")
 model DataflowEndpointAuthenticationSystemAssignedManagedIdentity {
   @doc("Audience of the service to authenticate against. Optional; defaults to the audience for Service host configuration.")
-  audience: string;
+  audience?: string;
 }
 
 @doc("DataflowEndpoint Authentication UserAssignedManagedIdentity properties")
@@ -20,7 +20,7 @@ model DataflowEndpointAuthenticationUserAssignedManagedIdentity {
   clientId: string;
 
   @doc("Resource identifier (application ID URI) of the resource, affixed with the .default suffix.")
-  scope: string;
+  scope?: string;
 
   @doc("Tenant ID.")
   tenantId: string;
@@ -103,7 +103,7 @@ model BrokerAuthenticatorCustomAuth {
 @doc("X509 Certificate Authentication properties.")
 model X509ManualCertificate {
   @doc("Kubernetes secret containing an X.509 client certificate. This is a reference to the secret through an identifying name, not the secret itself.")
-  secretRef: KubernetesReferenceKnownType;
+  secretRef: string;
 }
 
 @doc("X509 for BrokerAuthentication.")

specification/iotoperations/IoTOperations.Management/models/base.tsp

@@ -142,15 +142,6 @@ union BrokerProtocolType {
   WebSockets: "WebSockets",
 }
 
-@doc("Kubernetes reference with known type")
-model KubernetesReferenceKnownType {
-  @doc("Name is the name of resource being referenced")
-  name: string;
-
-  @doc("Namespace is the namespace of the resource being referenced. This field is required when the resource has a namespace.")
-  `namespace`?: string;
-}
-
 @doc("Kubernetes reference")
 model KubernetesReference {
   ...LocalKubernetesReference;

specification/iotoperations/IoTOperations.Management/models/broker/authentications.tsp

@@ -69,5 +69,5 @@ union BrokerAuthenticationMethod {
   ServiceAccountToken: "ServiceAccountToken",
 
   @doc("X.509 authentication configuration.")
-  x509Certificate: "x509Certificate",
+  X509: "X509",
 }

specification/iotoperations/IoTOperations.Management/models/dataflows/dataflowEndpoints.tsp

@@ -224,10 +224,10 @@ model DataflowEndpointKafka {
   partitionStrategy?: DataflowEndpointKafkaPartitionStrategy = DataflowEndpointKafkaPartitionStrategy.Default;
 
   @doc("TLS configuration.")
-  tls: TlsProperties;
+  tls?: TlsProperties = #{ mode: OperationalMode.Enabled };
 
   @doc("Cloud event mapping config.")
-  cloudEventMapping?: CloudEventMappingType;
+  cloudEventAttributes?: CloudEventAttributeType;
 }
 
 @doc("Kafka endpoint Authentication properties. NOTE - only authentication property is allowed per entry")
@@ -365,7 +365,7 @@ model DataflowEndpointMqtt {
   tls?: TlsProperties = #{ mode: OperationalMode.Enabled };
 
   @doc("Cloud event mapping config.")
-  cloudEventMapping?: CloudEventMappingType;
+  cloudEventAttributes?: CloudEventAttributeType;
 }
 
 @doc("Mqtt endpoint Authentication properties. NOTE - only authentication property is allowed per entry.")
@@ -402,15 +402,12 @@ union MqttRetainType {
 }
 
 @doc("How to map events to the cloud.")
-union CloudEventMappingType {
+union CloudEventAttributeType {
   string,
 
-  @doc("PassThrough type")
-  PassThrough: "PassThrough",
-
-  @doc("Always type")
-  Always: "Always",
+  @doc("Propagate type")
+  Propagate: "Propagate",
 
-  @doc("Never type")
-  Never: "Never",
+  @doc("CreateOrRemap type")
+  CreateOrRemap: "CreateOrRemap",
 }

specification/iotoperations/IoTOperations.Management/models/instance.tsp

@@ -67,22 +67,23 @@ model InstanceProperties {
 @doc("The configuration for components of the AIO Instance.")
 model Components {
   @doc("The properties of the ADR instance.")
-  adr?: AdrProperties = #{ enabled: true };
+  adr?: AdrProperties = #{ state: OperationalMode.Enabled };
 
   @doc("The properties of the AKRI instance.")
-  akri?: AkriInstanceProperties = #{ enabled: true };
+  akri?: AkriInstanceProperties = #{ state: OperationalMode.Enabled };
 
   @doc("The properties of the connectors instance.")
-  connectors?: ConnectorInstanceProperties = #{ enabled: true };
+  connectors?: ConnectorInstanceProperties = #{
+    state: OperationalMode.Enabled,
+  };
 
   @doc("The properties of the dataflows instance.")
-  dataflows?: DataFlowInstanceProperties = #{ enabled: true };
+  dataflows?: DataFlowInstanceProperties = #{ state: OperationalMode.Enabled };
 
   @doc("The properties of the device provisioning instance.")
-  mqttbroker?: MqttBrokerInstanceProperties = #{ enabled: true };
-
-  @doc("The properties of the device provisioning instance.")
-  schemaregistry?: SchemaRegistryInstanceProperties = #{ enabled: true };
+  schemaRegistry?: SchemaRegistryInstanceProperties = #{
+    state: OperationalMode.Enabled,
+  };
 }
 
 @doc("The properties of a Service Account.")
@@ -97,34 +98,33 @@ model ServiceAccountProperties {
 @doc("The properties of an ADR instance.")
 model AdrProperties {
   @doc("This determines if the ADR service is enabled.")
-  enabled: boolean;
+  @visibility("create", "read")
+  state: OperationalMode;
 }
 @doc("The properties of an AKRI instance.")
 model AkriInstanceProperties {
   @doc("This determines if the AKRI service is enabled.")
-  enabled: boolean;
+  @visibility("create", "read")
+  state: OperationalMode;
 }
 
 @doc("The properties of a  Connector instance.")
 model ConnectorInstanceProperties {
   @doc("This determines if the Connector service is enabled.")
-  enabled: boolean;
+  @visibility("create", "read")
+  state: OperationalMode;
 }
 
 @doc("The properties of an DataFlow instance.")
 model DataFlowInstanceProperties {
-  @doc("This determines if the DataFlow service is enabled.")
-  enabled: boolean;
-}
-
-@doc("The properties of an MQTT Broker instance.")
-model MqttBrokerInstanceProperties {
-  @doc("This determines if the MQTT Broker service is enabled.")
-  enabled: boolean;
+  @doc("This determines if the Dataflow service is enabled.")
+  @visibility("create", "read")
+  state: OperationalMode;
 }
 
 @doc("The properties of a Schema Registry instance.")
 model SchemaRegistryInstanceProperties {
   @doc("This determines if the Schema Registry service is enabled.")
-  enabled: boolean;
+  @visibility("create", "read")
+  state: OperationalMode;
 }