Skip to content

fix: re-add Instance examples to #30199

Merged
nonsocode merged 7 commits intoAzure:release/0.7.0-previewfrom
nonsocode:nchukwuogor/no-service-accounts
Aug 14, 2024
Merged

fix: re-add Instance examples to #30199
nonsocode merged 7 commits intoAzure:release/0.7.0-previewfrom
nonsocode:nchukwuogor/no-service-accounts

Conversation

@nonsocode
Copy link
Copy Markdown
Member

@nonsocode nonsocode commented Aug 14, 2024

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Aug 14, 2024 •
edited
Loading

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review

@openapi-pipeline-app
Copy link
Copy Markdown

openapi-pipeline-app bot commented Aug 14, 2024 •
edited
Loading

PR validation pipeline restarted successfully. If there is ApiView generated, it will be updated in this comment.

@AzureRestAPISpecReview AzureRestAPISpecReview added ARMReview resource-manager RPaaS TypeSpec Authored with TypeSpec WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2024
hmmorales
hmmorales reviewed Aug 14, 2024
View reviewed changes
...perations.Management/examples/2024-08-15-preview/Instance_CreateOrUpdate_MaximumSet_Gen.json Outdated
"subscriptionId": "F8C729F9-DF9C-4743-848F-96EE433D8E53",
"resourceGroupName": "rgiotoperations",
"instanceName": "aio-instance",
"instanceName": "Replace this value with a string matching RegExp ^[a-z0-9][a-z0-9-]*[a-z0-9]$",
Copy link
Copy Markdown
Member

@hmmorales hmmorales Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you revert this back to aio-instance

...oTOperations/preview/2024-08-15-preview/examples/Instance_CreateOrUpdate_MaximumSet_Gen.json
@@ -1,11 +1,11 @@
{
Copy link
Copy Markdown
Member

@hmmorales hmmorales Aug 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after making the changes to the other example file, delete this one and then re-run the open api script

@AzureRestAPISpecReview AzureRestAPISpecReview removed RPaaS TypeSpec Authored with TypeSpec labels Aug 14, 2024
@nonsocode nonsocode merged commit 23df743 into Azure:release/0.7.0-preview Aug 14, 2024
hmmorales added a commit that referenced this pull request Aug 15, 2024
@hmmorales @chgennar
@nonsocode @jlian
AIO M2 Spec Updates (#30039)
a980daf 
* init PR

* remove placeholder

* Revert "remove placeholder"

This reverts commit 8a31865.

* init 2024-08-15-preview

* enforce only latest version gets changed

* remove placeholder

* Release/0.7.0 preview (#30109)

* Some changes

* DataFlow -> Dataflow

* More updates

* Ran Henry's Build Tool

* revert old examples

* remaining files

* Updating secret ref (#30113)

* Release/0.7.0 preview (#30114)

* Update schema registry ref based on review

* More updates...

* Schema Registry Regex

* Update examples

* identity update

* Update examples

* Update examples

* Update examples

* feat: Add support for Identity and service accounts in instance (#30127)

* add readonly service account fields

* sap

* generate examples

* bring auth into props (#30121)

* changes to dataflowendpoint and auth to bring authentication properties to each setting

* ran script

* endpointType and revert for secretRef

* clean up description, make authentication required, remove accesstokensetting from onelake

* add auth to each method

* scope down each auth method

* scope down unions

* remove general auth object

* organization

* ran tool

* sasl to sat

* ran examples

* examples

* service account x-ms-identifiers

* examples

* tsv

* Add clientId (#30130)

* Add clientId

* ...

* Rm @disciminator (#30131)

* Bring back examples (#30132)

* add example file back (#30134)

* Make auth required (#30136)

* make auth required in mqtt and kafka methods

* rename certificatesettings

* examples

* feat: add flags for aio services (#30135)

* commit flags

* commit examples

* Merge upstream

* examples

* examples (#30139)

* spell check

* spellcheck

* feat: Add identity support to patch operation (#30145)

* support_identity

* lint

* patch MI

* should work

* lint

* Patch Fix & Update ClientId Doc (#30140)

* fix

* fix

* patch fix and clientid fix

* examples

* tsv

* x509CertificateSettings in BrokerAuth (#30146)

* fix: revert brokerauth x509 changes (#30149)

* Add examples for Broker (#30152)

* Add Broker examples

* Fix typo

* Better listener example

* fix up examples and remove example gen (#30171)

* Remove reference to orchestrator

* chore: Feedback from 8/9 (#30187)

* Audience, SecretRef, TLS

* CloudEventAttributeType

* x509

* update schema

* PR feedback

* schema update

* key as well

* remove MQ disable/enable

* bring back broker

* generate schema

* format

* make props read-only

* remove mq

* schema update

* make togles read write

* schema update

* use mode flags

* new line

* switch to state

* state

* Add dataflow examples (#30192)

* fix examples (#30195)

* fix examples

* fix

* typo

* instance examples

* another typo

* fix: Remove service accounts from instance (#30198)

* remove Service accounts

* update instance defintion

* sync changes

* fix: re-add Instance examples to  (#30199)

* remove Service accounts

* update instance defintion

* sync changes

* examples

* examples

* update second example

* Instance schema and example update

* chore: Fix typos in Aio types (#30205)

* fix: Rename secretName to secretRef (#30208)

* suppression (#30209)

* fix secretName (#30211)

* fix: update examples (#30212)

* update examples

* push other examples

* typo (#30213)

* fix: Adressed half of the issues (#30216)

* Adressed half

* gen

* model validation pass

* model validation (#30218)

* 201 (#30219)

* fix

* Model validation pass 4 (#30220)

* update batching

* example gen

* Model validation pass 5 (#30221)

* Revert "Model validation pass 4 (#30220)"

This reverts commit d73c5c8.

* ...

* fix: lower case d (#30236)

* fix: Lowercase d in dataflow

* uncomment supression

* supress path

* schema

* drill down

* stop at identity

* run gen

---------

Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com>
Co-authored-by: Chinonso Chukwuogor <nonsochukwuogor@gmail.com>
Co-authored-by: John Lian <jlian@users.noreply.github.com>
cheukchuen pushed a commit that referenced this pull request Jan 24, 2025
@hmmorales @chgennar
@nonsocode @jlian @cheukchuen
AIO M2 Spec Updates (#30039)
a0a4448 
* init PR

* remove placeholder

* Revert "remove placeholder"

This reverts commit 8a31865.

* init 2024-08-15-preview

* enforce only latest version gets changed

* remove placeholder

* Release/0.7.0 preview (#30109)

* Some changes

* DataFlow -> Dataflow

* More updates

* Ran Henry's Build Tool

* revert old examples

* remaining files

* Updating secret ref (#30113)

* Release/0.7.0 preview (#30114)

* Update schema registry ref based on review

* More updates...

* Schema Registry Regex

* Update examples

* identity update

* Update examples

* Update examples

* Update examples

* feat: Add support for Identity and service accounts in instance (#30127)

* add readonly service account fields

* sap

* generate examples

* bring auth into props (#30121)

* changes to dataflowendpoint and auth to bring authentication properties to each setting

* ran script

* endpointType and revert for secretRef

* clean up description, make authentication required, remove accesstokensetting from onelake

* add auth to each method

* scope down each auth method

* scope down unions

* remove general auth object

* organization

* ran tool

* sasl to sat

* ran examples

* examples

* service account x-ms-identifiers

* examples

* tsv

* Add clientId (#30130)

* Add clientId

* ...

* Rm @disciminator (#30131)

* Bring back examples (#30132)

* add example file back (#30134)

* Make auth required (#30136)

* make auth required in mqtt and kafka methods

* rename certificatesettings

* examples

* feat: add flags for aio services (#30135)

* commit flags

* commit examples

* Merge upstream

* examples

* examples (#30139)

* spell check

* spellcheck

* feat: Add identity support to patch operation (#30145)

* support_identity

* lint

* patch MI

* should work

* lint

* Patch Fix & Update ClientId Doc (#30140)

* fix

* fix

* patch fix and clientid fix

* examples

* tsv

* x509CertificateSettings in BrokerAuth (#30146)

* fix: revert brokerauth x509 changes (#30149)

* Add examples for Broker (#30152)

* Add Broker examples

* Fix typo

* Better listener example

* fix up examples and remove example gen (#30171)

* Remove reference to orchestrator

* chore: Feedback from 8/9 (#30187)

* Audience, SecretRef, TLS

* CloudEventAttributeType

* x509

* update schema

* PR feedback

* schema update

* key as well

* remove MQ disable/enable

* bring back broker

* generate schema

* format

* make props read-only

* remove mq

* schema update

* make togles read write

* schema update

* use mode flags

* new line

* switch to state

* state

* Add dataflow examples (#30192)

* fix examples (#30195)

* fix examples

* fix

* typo

* instance examples

* another typo

* fix: Remove service accounts from instance (#30198)

* remove Service accounts

* update instance defintion

* sync changes

* fix: re-add Instance examples to  (#30199)

* remove Service accounts

* update instance defintion

* sync changes

* examples

* examples

* update second example

* Instance schema and example update

* chore: Fix typos in Aio types (#30205)

* fix: Rename secretName to secretRef (#30208)

* suppression (#30209)

* fix secretName (#30211)

* fix: update examples (#30212)

* update examples

* push other examples

* typo (#30213)

* fix: Adressed half of the issues (#30216)

* Adressed half

* gen

* model validation pass

* model validation (#30218)

* 201 (#30219)

* fix

* Model validation pass 4 (#30220)

* update batching

* example gen

* Model validation pass 5 (#30221)

* Revert "Model validation pass 4 (#30220)"

This reverts commit d73c5c8.

* ...

* fix: lower case d (#30236)

* fix: Lowercase d in dataflow

* uncomment supression

* supress path

* schema

* drill down

* stop at identity

* run gen

---------

Co-authored-by: chgennar <56695749+chgennar@users.noreply.github.com>
Co-authored-by: Chinonso Chukwuogor <nonsochukwuogor@gmail.com>
Co-authored-by: John Lian <jlian@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hmmorales hmmorales hmmorales approved these changes

Assignees

No one assigned

Labels

ARMReview resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nonsocode @hmmorales @AzureRestAPISpecReview