Add List and Delete Subscription Changed Directory for new version 2024-08-01-preview.#30257
Merged
abhaygill338 merged 37 commits intoAzure:mainfrom Sep 4, 2024
Conversation
…ectory existing behavior swagger.
…tiate and accept change directory.
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
|
Azure Pipelines successfully started running 3 pipeline(s). |
AzureRestAPISpecReview
added
WaitForARMFeedback
abhaygill338
force-pushed
the
users/abhaypratap/new-version-list-del-change-dir
branch
from
457fbee to
aef63c5
Compare
|
PR validation pipeline can not start as the pull request is not merged or mergeable - most likely it has merge conflicts. |
Member
|
Approving suppression based on office hours discussion. These APIs are already published with the non-RPC delete behavior, but there is no previous spec for the earlier API version, so they need to be suppressed in the current API version. |
mentat9
added
ARMSignedOff
openapi-pipeline-app
bot
removed
the
WaitForARMFeedback
Member
|
Bypassing remaining linter checks due to false positive BodyTopLevelProperties errors. |
Member
|
@abhaygill338 - Next Steps to Merge: #30257 (comment). |
abhaygill338
added
the
PublishToCustomers
Contributor
Author
|
@mentat9 , can you please help in approving and merging this swagger PR. |
mentat9
approved these changes
Sep 3, 2024
Contributor
Author
|
/pr RequestMerge |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
AzureRestAPISpecReview
added
the
ReadyForApiTest
cheukchuen
pushed a commit
that referenced
this pull request
Jan 24, 2025
…24-08-01-preview. (#30257) * Resolving S320 Item - Missing Get SubscriptionOperations for 2021-10-01 version. * Fix pipeline suggestions. * Minor fix. * Make Get Subscription operations sync in this version. * Added suppress rules for failing lint errors. * Fix suppression Issues. * Minor fix suppression GetOperation200. * Address minor fixes. * Address GetOperation200 changes. * Update readme.md: attempt suppression fix by adding ["202"] to "responses" to path * Add Initiate, Get and Accept Subscription Change Directory Api with new version. * Cleaning up the changes in the add-ons inside swagger files. * Add or modified readme file. * Fix pipeline issues. * Fixes on lint errors, model errors. * Address PR changes. * Address swagger PR fixes. * Fixing swagger changes. * Fix breaking changes paths to include into this new version. * Fix Prettier Checks. * Add or Update the parameter location in the swagger. * Add suppressions for the lint errors + plus request schema changes. * Suppress lint errors. * Adding changes to revert initiate and accept subscription changed directory existing behavior swagger. * Add new version, destination tenant and owner id for subscription initiate and accept change directory. * Reorder new preview version changes with the latest GA version. * Adding v5 type error response body. * Add List and Delete Subscription Changed Directory for new version 2024-08-01. * Fix prettier checks. * Fix Lint Errors. * Address Lint errors fix. * Add Suppression, for Delete Response Codes and Delete Operation Responses. * Address Fix in suppression. * Update reasons on Suppresions - DeleteResponseCodes, DeleteOperationResponse. --------- Co-authored-by: Abhay Pratap <abhaypratap@microsoft.com> Co-authored-by: Konrad Jamrozik <kojamroz@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two new api paths list and delete subscription changed directory into the swagger, missed adding it for reference merged in swagger PR, #29912