[OpenAI] Modes required to be public in Java SDK by mssfang · Pull Request #26651 · Azure/azure-rest-api-specs

mssfang · 2023-11-09T22:39:42Z

These classes are already in the public /model folder, we should keep them out in Java at least.

openapi-pipeline-app · 2023-11-09T22:39:50Z

Automatic PR validation restarted. This comment will be populated with next steps to merge this PR once validation is completed. Please wait ⌛.

openapi-pipeline-app · 2023-11-09T22:39:51Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

️️✔️Automated merging requirements met succeeded [Detail] [Expand]

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-09T22:39:52Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8178614. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.AI.OpenAI [View full logs] [Release SDK Changes]
- Azure.AI.OpenAI.1.0.0-alpha.20231114.1.nupkg
```
info	[Changelog]
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 8178614. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.3.1
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/compiler@0.50.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/rest@0.50.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/http@0.50.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/openapi@0.50.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@typespec/versioning@0.50.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-azure-core@0.36.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm WARN EBADENGINE Unsupported engine {
cmderr	[generate.py] npm WARN EBADENGINE   package: '@azure-tools/typespec-client-generator-core@0.36.0',
cmderr	[generate.py] npm WARN EBADENGINE   required: { node: '>=18.0.0' },
cmderr	[generate.py] npm WARN EBADENGINE   current: { node: 'v16.20.2', npm: '8.19.4' }
cmderr	[generate.py] npm WARN EBADENGINE }
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 10.2.3
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v10.2.3>
cmderr	[generate.py] npm notice Run `npm install -g npm@10.2.3` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-openai [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 8178614. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json

️✔️@azure/openai [View full logs] [Release SDK Changes]

info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-11-09T22:39:53Z

Generated ApiView

Language	Package Name	ApiView Link
.Net	Azure.AI.OpenAI	https://apiview.dev/Assemblies/Review/808be497f8c4462d901e7796fe5d268f
JavaScript	@azure/openai	There is no API change compared with the previous version
Java	azure-ai-openai	https://apiview.dev/Assemblies/Review/72b9f299298446a3bcdf83ca13ed169d

specification/cognitiveservices/OpenAI.Inference/client.tsp

weidongxu-microsoft

I will see if we can release the "Union as BinaryData" typespec-java next week.

Code is merged, pending for me to test it on the OpenAI tsp and configure (safer to do this before release of emitter).

openapi-pipeline-app · 2023-11-10T05:03:14Z

Next Steps to Merge

✔️ All automated merging requirements have been met! Refer to step 4 in the PR workflow diagram (even if your PR is for data plane, not ARM).

weidongxu-microsoft · 2023-11-13T12:12:09Z

I am updating typespec-java to 0.11.0 (which include Union as BinaryData) Azure/azure-sdk-for-java#37629

I will try to see if I need some change to client.tsp, built upon this PR.

Feel free to merge, if this already work well with 0.10.0

mssfang · 2023-11-13T18:17:07Z

@lmazuel Can I merge this PR? @joseharriaga opened a PR in .NET side to fix the failure in .net.

openapi-pipeline-app · 2023-11-13T23:53:04Z

Swagger pipeline restarted successfully, please wait for status update in this comment.

Java will need those class to be expored

e9caf2d

mssfang requested a review from yangyuan as a code owner November 9, 2023 22:39

openapi-assignment-bot bot assigned lmazuel Nov 9, 2023

mssfang assigned mssfang and unassigned lmazuel Nov 9, 2023

microsoft-github-policy-service bot added the TypeSpec Authored with TypeSpec label Nov 9, 2023

mssfang added the OpenAI OpenAI service label Nov 9, 2023

mssfang requested review from jpalvarezl, mikeharder and weidongxu-microsoft November 9, 2023 22:41

trrwilson approved these changes Nov 9, 2023

View reviewed changes

This was referenced Nov 9, 2023

[AutoPR azure-ai-openai] [OpenAI] Modes required to be public in Java SDK azure-sdk/azure-sdk-for-java#8459

Closed

[AutoPR Azure.AI.OpenAI] [OpenAI] Modes required to be public in Java SDK azure-sdk/azure-sdk-for-net#6174

Closed

mssfang commented Nov 9, 2023

View reviewed changes

specification/cognitiveservices/OpenAI.Inference/client.tsp Show resolved Hide resolved

azure-sdk mentioned this pull request Nov 9, 2023

[AutoPR @azure/openai] [OpenAI] Modes required to be public in Java SDK azure-sdk/azure-sdk-for-js#7628

Closed

mssfang changed the title ~~[OpenAI] Java will need this class to be public.~~ [OpenAI] Modes required to be public in Java SDK Nov 9, 2023

mssfang mentioned this pull request Nov 9, 2023

[OpenAI] Regenerate Code with later changes in typespec definition Azure/azure-sdk-for-java#37604

Merged

weidongxu-microsoft approved these changes Nov 10, 2023

View reviewed changes

mssfang added 3 commits November 9, 2023 19:43

resolve conflict

762f50e

keep ImageGenerations access

9efd3a3

only make a few images class public is enough

bd663ca

jpalvarezl approved these changes Nov 10, 2023

View reviewed changes

keep original pullic constructor

03bef7f

mssfang merged commit 8178614 into Azure:main Nov 13, 2023

mssfang deleted the OpenAI-Java-ExporedPublicClass branch November 13, 2023 23:53

zman-ms pushed a commit that referenced this pull request Jan 10, 2024

[OpenAI] Modes required to be public in Java SDK (#26651)

86ff319

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[OpenAI] Modes required to be public in Java SDK#26651

[OpenAI] Modes required to be public in Java SDK#26651
mssfang merged 5 commits intoAzure:mainfrom
mssfang:OpenAI-Java-ExporedPublicClass

mssfang commented Nov 9, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

Uh oh!

Uh oh!

weidongxu-microsoft left a comment

Uh oh!

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

Uh oh!

weidongxu-microsoft commented Nov 13, 2023 •

edited

Loading

Uh oh!

mssfang commented Nov 13, 2023

Uh oh!

openapi-pipeline-app bot commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mssfang commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented Nov 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Uh oh!

weidongxu-microsoft left a comment

Choose a reason for hiding this comment

Uh oh!

openapi-pipeline-app bot commented Nov 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Next Steps to Merge

Uh oh!

weidongxu-microsoft commented Nov 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mssfang commented Nov 13, 2023

Uh oh!

openapi-pipeline-app bot commented Nov 13, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

mssfang commented Nov 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 9, 2023 •

edited

Loading

openapi-pipeline-app bot commented Nov 10, 2023 •

edited

Loading

weidongxu-microsoft commented Nov 13, 2023 •

edited

Loading