[Azure OpenAI] Re-generate based on latest TypeSpec with @access and @usage decorators#39909
Merged
joseharriaga merged 2 commits intoAzure:mainfrom Nov 13, 2023
Merged
Conversation
joseharriaga
requested review from
jpalvarezl,
m-nash and
trrwilson
as code owners
Collaborator
|
API change check API changes are not detected in this pull request. |
trrwilson
approved these changes
Nov 10, 2023
pshao25
reviewed
Nov 13, 2023
...i/Azure.AI.OpenAI/src/Custom/AzureCognitiveSearchChatExtensionConfiguration.Serialization.cs
Show resolved
Hide resolved
pshao25
reviewed
Nov 13, 2023
...i/Azure.AI.OpenAI/src/Custom/AzureCognitiveSearchChatExtensionConfiguration.Serialization.cs
Outdated
Show resolved
Hide resolved
pshao25
reviewed
Nov 13, 2023
sdk/openai/Azure.AI.OpenAI/src/Generated/AzureCognitiveSearchChatExtensionConfiguration.cs
Show resolved
Hide resolved
pshao25
reviewed
Nov 13, 2023
sdk/openai/Azure.AI.OpenAI/src/Custom/AzureCognitiveSearchChatExtensionConfiguration.cs
Show resolved
Hide resolved
pshao25
reviewed
Nov 13, 2023
...i/Azure.AI.OpenAI/src/Custom/AzureCognitiveSearchChatExtensionConfiguration.Serialization.cs
Show resolved
Hide resolved
haiyuazhang
pushed a commit
to haiyuazhang/azure-sdk-for-net
that referenced
this pull request
Mar 9, 2026
* add stackhcivm 2026-02-01-preview api * fix snapshotstatus comments * Add examples for stackhcivm 2026-02-01-preview * address review comments regarding the header * revert package-lock.json change * revert package-lock.json change --------- Co-authored-by: James Gu <gujames@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writemethod ofAzureCognitiveSearchIndexFieldMappingOptionsnow that it is auto-generated.Writemethod ofAzureCognitiveSearchChatExtensionConfigurationhad a property called "fieldMappings", but it was supposed to be "fieldsMapping" according to the TypeSpec. I'm fixing this as part of this change.AzureCognitiveSearchChatExtensionConfigurationgoing frominternaltopublic, which would normally be okay except that this constructor contains thesearchKeyparameter. In the pattern that we adopted, users call theSetSearchKeymethod separately instead. I'm customizing this constructor to keep itinternal.AzureCognitiveSearchChatExtensionConfigurationnow has aToRequestContentmethod. The code breaks with a compile time error saying that this hides theToRequestContentmethod of its base class (i.e.,AzureChatExtensionConfiguration). "To make the current member override that implementation, add the override keyword. Otherwise use the new keyword." I'm suppressing this generation.