[TypeSpec-Clean]: Updates for AnomalyDetector by markcowl · Pull Request #23972 · Azure/azure-rest-api-specs

markcowl · 2023-05-12T22:30:20Z

Passing CI pipeline: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2772571&view=logs&j=9cd39ef8-47c1-5b58-08db-8c3708712f1b&t=46aa8e9f-34a9-5191-842b-906b756357f0

openapi-workflow-bot · 2023-05-12T22:30:23Z

Hi, @markcowl Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-12T22:30:24Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-12T22:30:25Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️⚠️ azure-sdk-for-python warning [Detail]

⚠️Warning [Logs]Release - Generate from 18a9e6d. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh]
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice

️✔️azure-ai-anomalydetector [View full logs] [Release SDK Changes]
- azure-ai-anomalydetector-3.0.0.zip
- azure_ai_anomalydetector-3.0.0-py3-none-any.whl
```
info	[Changelog] data-plan skip changelog generation temporarily
```

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs]Release - Generate from 18a9e6d. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.6.6
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-anomalydetector [View full logs] [Release SDK Changes]

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 18a9e6d. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.AI.AnomalyDetector [View full logs] [Release SDK Changes]
- Azure.AI.AnomalyDetector.3.0.0-alpha.20230515.1.nupkg
```
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs]Release - Generate from 18a9e6d. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/anomalydetector/ai-anomaly-detector-rest/changelog-temp/package/CHANGELOG.md'

️✔️@azure-rest/ai-anomaly-detector [View full logs] [Release SDK Changes]
- azure-rest-ai-anomaly-detector-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-12T22:30:26Z

Generated ApiView

Language	Package Name	ApiView Link
Python	azure-ai-anomalydetector	https://apiview.dev/Assemblies/Review/28b8213945014a51abebfe70b31d6b56
Java	azure-ai-anomalydetector	https://apiview.dev/Assemblies/Review/c39ae64687b14f63993332da2c58a0d2
.Net	Azure.AI.AnomalyDetector	There is no API change compared with the previous version
JavaScript	@azure-rest/ai-anomaly-detector	https://apiview.dev/Assemblies/Review/e3412d34466e4020a9a01d017101aac4

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml

weshaggard · 2023-05-15T20:57:52Z

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml

 ]
 options:
  "@azure-tools/typespec-autorest":
+    azure-resource-provider-folder: "./data-plane"


@markcowl do you know why this property is needed explicitly? I tried to just hardcode it in the output-file path directly but when I did the output didn't go to the correct place because it seems as though service-name, version, version-status were all null.

Yes, it is essentially a toggle switch that is necessary for example inclusion to work correctly with versioning. We should make it unnecessary.

Updates for AnomalyDetector

f6b2b2b

markcowl requested a review from yangyuan as a code owner May 12, 2023 22:30

openapi-assignment-bot bot assigned Wzb123456789 May 12, 2023

ghost added the Cognitive Services label May 12, 2023

mikeharder mentioned this pull request May 12, 2023

[AnomalyDetector] Fix output path #23963

Closed

mikeharder requested changes May 12, 2023

View reviewed changes

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml Outdated Show resolved Hide resolved

mikeharder requested changes May 13, 2023

View reviewed changes

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml Outdated Show resolved Hide resolved

mikeharder mentioned this pull request May 13, 2023

Cleaning build for TypeSpec data plane services #23940

Closed

3 tasks

Updating config to match template

f9e8822

azure-sdk mentioned this pull request May 13, 2023

[AutoPR azure-ai-anomalydetector] [TypeSpec-Clean]: Updates for AnomalyDetector azure-sdk/azure-sdk-for-python#3557

Closed

mikeharder approved these changes May 15, 2023

View reviewed changes

weshaggard reviewed May 15, 2023

View reviewed changes

markcowl merged commit 18a9e6d into Azure:main May 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TypeSpec-Clean]: Updates for AnomalyDetector#23972

[TypeSpec-Clean]: Updates for AnomalyDetector#23972
markcowl merged 2 commits intoAzure:mainfrom
markcowl:tsp-clean-ad

markcowl commented May 12, 2023 •

edited by mikeharder

Loading

Uh oh!

openapi-workflow-bot bot commented May 12, 2023

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

weshaggard May 15, 2023

Uh oh!

markcowl May 15, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

markcowl commented May 12, 2023 • edited by mikeharder Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented May 12, 2023

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

Uh oh!

Uh oh!

weshaggard May 15, 2023

Choose a reason for hiding this comment

Uh oh!

markcowl May 15, 2023

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

markcowl commented May 12, 2023 •

edited by mikeharder

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading