[AnomalyDetector] Fix output path by mikeharder · Pull Request #23963 · Azure/azure-rest-api-specs

mikeharder · 2023-05-12T21:33:10Z

Subset of #23940

Passing CI pipeline: https://dev.azure.com/azure-sdk/public/_build/results?buildId=2772527&view=logs&j=9cd39ef8-47c1-5b58-08db-8c3708712f1b&t=46aa8e9f-34a9-5191-842b-906b756357f0

openapi-workflow-bot · 2023-05-12T21:33:13Z

Hi, @mikeharder Thanks for your PR. I am workflow bot for review process. Here are some small tips.

Please ensure to do self-check against checklists in first PR comment.

PR assignee is the person auto-assigned and responsible for your current PR reviewing and merging.

For specs comparison cross API versions, Use API Specs Comparison Report Generator

If there is CI failure(s), to fix CI error(s) is mandatory for PR merging; or you need to provide justification in PR comment for explanation. How to fix?

Any feedback about review process or workflow bot, pls contact swagger and tools team. vscswagger@microsoft.com

openapi-pipeline-app · 2023-05-12T21:33:13Z

Swagger Validation Report

️️✔️BreakingChange succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️Breaking Change(Cross-Version) succeeded [Detail] [Expand]

There are no breaking changes.

️️✔️CredScan succeeded [Detail] [Expand]

There is no credential detected.

️️✔️LintDiff succeeded [Detail] [Expand]

Validation passes for LintDiff.

️️✔️Avocado succeeded [Detail] [Expand]

Validation passes for Avocado.

️️✔️ApiReadinessCheck succeeded [Detail] [Expand]

️️✔️~[Staging] ServiceAPIReadinessTest succeeded [Detail] [Expand]

Validation passes for ServiceAPIReadinessTest.

️️✔️SwaggerAPIView succeeded [Detail] [Expand]

️️✔️CadlAPIView succeeded [Detail] [Expand]

️️✔️TypeSpecAPIView succeeded [Detail] [Expand]

️️✔️ModelValidation succeeded [Detail] [Expand]

Validation passes for ModelValidation.

️️✔️SemanticValidation succeeded [Detail] [Expand]

Validation passes for SemanticValidation.

️️✔️PoliCheck succeeded [Detail] [Expand]

Validation passed for PoliCheck.

️️✔️PrettierCheck succeeded [Detail] [Expand]

Validation passes for PrettierCheck.

️️✔️SpellCheck succeeded [Detail] [Expand]

Validation passes for SpellCheck.

️️✔️Lint(RPaaS) succeeded [Detail] [Expand]

Validation passes for Lint(RPaaS).

️️✔️CadlValidation succeeded [Detail] [Expand]

Validation passes for CadlValidation.

️️✔️TypeSpec Validation succeeded [Detail] [Expand]

Validation passes for TypeSpec Validation.

️️✔️PR Summary succeeded [Detail] [Expand]

Validation passes for Summary.

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-12T21:33:14Z

Swagger Generation Artifacts

️️✔️ApiDocPreview succeeded [Detail] [Expand]

️️✔️SDK Breaking Change Tracking succeeded [Detail] [Expand]

Breaking Changes Tracking

️❌ azure-sdk-for-python failed [Detail]

❌Code Generator Failed [Logs] Generate from 6ec6b9f9697b72706e08846dbef362103338083c. SDK Automation 14.0.0

command	sh scripts/automation_init.sh ../azure-sdk-for-python_tmp/initInput.json ../azure-sdk-for-python_tmp/initOutput.json
cmderr	[automation_init.sh] WARNING: Skipping azure-nspkg as it is not installed.
command	sh scripts/automation_generate.sh ../azure-sdk-for-python_tmp/generateInput.json ../azure-sdk-for-python_tmp/generateOutput.json
cmderr	[automation_generate.sh] npm notice
cmderr	[automation_generate.sh] npm notice New minor version of npm available! 9.5.1 -> 9.6.6
cmderr	[automation_generate.sh] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[automation_generate.sh] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[automation_generate.sh] npm notice
cmdout	[automation_generate.sh] [Autorest]/mnt/vss/_work/1/s/azure-sdk-for-python_tmp/venv-sdk/auto_temp.json does not exist!!!Error happened during codegen
error	Script return with result [failed] code [1] signal [null] cwd [azure-sdk-for-python]: sh scripts/automation_generate.sh
warn	Skip package processing as generation is failed

️⚠️ azure-sdk-for-java warning [Detail]

⚠️Warning [Logs] Generate from 6ec6b9f9697b72706e08846dbef362103338083c. SDK Automation 14.0.0

command	./eng/mgmt/automation/init.sh ../azure-sdk-for-java_tmp/initInput.json ../azure-sdk-for-java_tmp/initOutput.json
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
cmderr	[init.sh] [notice] A new release of pip is available: 23.0.1 -> 23.1.2
cmderr	[init.sh] [notice] To update, run: pip install --upgrade pip
command	./eng/mgmt/automation/generate.py ../azure-sdk-for-java_tmp/generateInput.json ../azure-sdk-for-java_tmp/generateOutput.json
cmderr	[generate.py] npm notice
cmderr	[generate.py] npm notice New major version of npm available! 8.19.4 -> 9.6.6
cmderr	[generate.py] npm notice Changelog: <https://github.com/npm/cli/releases/tag/v9.6.6>
cmderr	[generate.py] npm notice Run `npm install -g npm@9.6.6` to update!
cmderr	[generate.py] npm notice

️✔️azure-ai-anomalydetector [View full logs] [Preview SDK Changes]

️️✔️ azure-sdk-for-net-track2 succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6ec6b9f9697b72706e08846dbef362103338083c. SDK Automation 14.0.0

command	pwsh ./eng/scripts/Automation-Sdk-Init.ps1 ../azure-sdk-for-net_tmp/initInput.json ../azure-sdk-for-net_tmp/initOutput.json
command	pwsh ./eng/scripts/Invoke-GenerateAndBuildV2.ps1 ../azure-sdk-for-net_tmp/generateInput.json ../azure-sdk-for-net_tmp/generateOutput.json

️✔️Azure.AI.AnomalyDetector [View full logs] [Preview SDK Changes]
- Azure.AI.AnomalyDetector.3.0.0-alpha.20230512.1.nupkg
```
info	[Changelog]
```

️️✔️ azure-sdk-for-js succeeded [Detail] [Expand]

️✔️Succeeded [Logs] Generate from 6ec6b9f9697b72706e08846dbef362103338083c. SDK Automation 14.0.0

command	sh .scripts/automation_init.sh ../azure-sdk-for-js_tmp/initInput.json ../azure-sdk-for-js_tmp/initOutput.json
warn	File azure-sdk-for-js_tmp/initOutput.json not found to read
command	sh .scripts/automation_generate.sh ../azure-sdk-for-js_tmp/generateInput.json ../azure-sdk-for-js_tmp/generateOutput.json
cmderr	[automation_generate.sh] [ERROR] Generate changelog failed: ENOENT: no such file or directory, open '/mnt/vss/_work/1/s/azure-sdk-for-js/sdk/anomalydetector/ai-anomaly-detector-rest/changelog-temp/package/CHANGELOG.md'

️✔️@azure-rest/ai-anomaly-detector [View full logs] [Preview SDK Changes]
- azure-rest-ai-anomaly-detector-1.0.0-beta.1.tgz
```
info	[Changelog]
error	breakingChangeTracking is enabled, but version or changelogItem is not found in output.
```

_{Posted by Swagger Pipeline | How to fix these errors?}

openapi-pipeline-app · 2023-05-12T21:33:15Z

Generated ApiView

Language	Package Name	ApiView Link
Java	azure-ai-anomalydetector	https://apiview.dev/Assemblies/Review/37d6e801fa2941b09460d23f6ac830f4
.Net	Azure.AI.AnomalyDetector	There is no API change compared with the previous version
JavaScript	@azure-rest/ai-anomaly-detector	https://apiview.dev/Assemblies/Review/862769420d0d49129014c180bc56377a

mikeharder · 2023-05-12T21:39:29Z

specification/cognitiveservices/AnomalyDetector/tspconfig.yaml

    omit-unreachable-types: true
    output-file: openapi.json
-    emitter-output-dir: "{project-root}/../data-plane/AnomalyDetector/stable"
+    emitter-output-dir: "{project-root}/../data-plane/AnomalyDetector/stable/v1.1"


@markcowl: Should output-file and emitter-output-dir be changed to align with the sample? Something like this:

emitter-output-dir: "{project-root}/.." output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/openapi.json"

In particular, I thought output-file is supposed to use a template expression after the recent breaking change:

https://azure.github.io/typespec-azure/docs/release-notes/release-2023-04-11#azure-toolstypespec-autorest-config-interpolation

Also, why is the version v1.1 instead of a date-based version like 2022-11-01-preview?

mikeharder · 2023-05-12T23:08:16Z

Dup of #23972

Anomaly Detector changes

76f61b1

mikeharder requested a review from yangyuan as a code owner May 12, 2023 21:33

openapi-assignment-bot bot assigned v-jiaodi May 12, 2023

ghost added the Cognitive Services label May 12, 2023

mikeharder commented May 12, 2023

View reviewed changes

mikeharder requested review from markcowl and weshaggard May 12, 2023 21:40

ckairen mentioned this pull request May 12, 2023

[TypeSpec Validation] TypeSpec Validation doesn't run if only a tspconfig.yaml is changed Azure/azure-sdk-tools#6170

Closed

mikeharder closed this May 12, 2023

mikeharder deleted the anomaly-detector branch June 9, 2023 21:34

mikeharder restored the anomaly-detector branch June 9, 2023 21:57

mikeharder deleted the anomaly-detector branch June 30, 2023 07:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[AnomalyDetector] Fix output path#23963

[AnomalyDetector] Fix output path#23963
mikeharder wants to merge 1 commit intoAzure:mainfrom
mikeharder:anomaly-detector

mikeharder commented May 12, 2023 •

edited

Loading

Uh oh!

openapi-workflow-bot bot commented May 12, 2023

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

Uh oh!

mikeharder May 12, 2023

Uh oh!

mikeharder May 12, 2023

Uh oh!

mikeharder commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mikeharder commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openapi-workflow-bot bot commented May 12, 2023

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Validation Report

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Swagger Generation Artifacts

Breaking Changes Tracking

Uh oh!

openapi-pipeline-app bot commented May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Generated ApiView

Uh oh!

mikeharder May 12, 2023

Choose a reason for hiding this comment

Uh oh!

mikeharder May 12, 2023

Choose a reason for hiding this comment

Uh oh!

mikeharder commented May 12, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mikeharder commented May 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading

openapi-pipeline-app bot commented May 12, 2023 •

edited

Loading