Skip to content

[TypeSpec-Clean]: Updates for AnomalyDetector #23972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markcowl merged 2 commits into from
May 15, 2023
Merged

[TypeSpec-Clean]: Updates for AnomalyDetector #23972

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6b2b2b
Updates for AnomalyDetector
markcowl May 12, 2023
f9e8822
Updating config to match template
markcowl May 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions specification/cognitiveservices/AnomalyDetector/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,11 @@ emit: [
]
options:
"@azure-tools/typespec-autorest":
azure-resource-provider-folder: "./data-plane"
Copy link
Member

@weshaggard weshaggard May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl do you know why this property is needed explicitly? I tried to just hardcode it in the output-file path directly but when I did the output didn't go to the correct place because it seems as though service-name, version, version-status were all null.

Copy link
Member Author

@markcowl markcowl May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is essentially a toggle switch that is necessary for example inclusion to work correctly with versioning. We should make it unnecessary.

examples-directory: ./examples
omit-unreachable-types: true
output-file: openapi.json
emitter-output-dir: "{project-root}/../data-plane/AnomalyDetector/stable"
output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/openapi.json"
emitter-output-dir: "{project-root}/../"
"@azure-tools/typespec-python":
"package-pprint-name": "\"Cognitive Services Anomaly Detector\""
"package-mode": "dataplane"
Expand Down