Skip to content

[AnomalyDetector] Fix output path #23963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikeharder wants to merge 1 commit into from
Closed

[AnomalyDetector] Fix output path #23963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion specification/cognitiveservices/AnomalyDetector/tspconfig.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ options:
examples-directory: ./examples
omit-unreachable-types: true
output-file: openapi.json
emitter-output-dir: "{project-root}/../data-plane/AnomalyDetector/stable"
emitter-output-dir: "{project-root}/../data-plane/AnomalyDetector/stable/v1.1"
Copy link
Member Author

@mikeharder mikeharder May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@markcowl: Should output-file and emitter-output-dir be changed to align with the sample? Something like this:

    emitter-output-dir: "{project-root}/.."
    output-file: "{azure-resource-provider-folder}/{service-name}/{version-status}/{version}/openapi.json"

In particular, I thought output-file is supposed to use a template expression after the recent breaking change:

https://azure.github.io/typespec-azure/docs/release-notes/release-2023-04-11#azure-toolstypespec-autorest-config-interpolation

Copy link
Member Author

@mikeharder mikeharder May 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, why is the version v1.1 instead of a date-based version like 2022-11-01-preview?

"@azure-tools/typespec-python":
"package-pprint-name": "\"Cognitive Services Anomaly Detector\""
"package-mode": "dataplane"
Expand Down