Skip to content

Performed changes according to feedback on Azure/azure-rest-api-specs/pull/1833#1

Closed
stevengum wants to merge 19 commits intoomarelhariry137:luis/luisSwaggerFilesfrom
stevengum:luis/luisSwaggerFiles
Closed

Performed changes according to feedback on Azure/azure-rest-api-specs/pull/1833#1
stevengum wants to merge 19 commits intoomarelhariry137:luis/luisSwaggerFilesfrom
stevengum:luis/luisSwaggerFiles

Conversation

@stevengum
Copy link
Copy Markdown

@stevengum stevengum commented Nov 2, 2017

Changes to LUIS Endpoint API.swagger.json

In reference to review from veronicagg.

  • Added periods to descriptions
  • Changed operationId names for both Programmatic and Endpoint Swagger Files
  • (Endpoint) Added additional definitions for results object from LUIS (required for next item)
  • Added response schemas to operations. Without schemas autorest does not properly handle 20X responses.
  • (Programmatic) Added additional definitions for results objects from LUIS (required for next item)
  • Added response schemas to operations. Without schemas autorest does not properly handle 20X responses.
  • Created globally defined parameters where applicable in both Programmatic and Endpoint Swagger Files
  • Default/Error Response implemented in Programmatic Swagger file
  • Default/Error Response implemented in Endpoint Swagger file

I performed some of the changes outlined in the original PR against azure-rest-api-specs and generated a working SDK using autorest before submitting this PR.

@v-geberr
Copy link
Copy Markdown

v-geberr commented Nov 7, 2017

Ignore this comment

@stevengum
Copy link
Copy Markdown
Author

Closing PR after handing off completed work to Southworks.

See PRs 2083 and 2051 against the Azure/azure-rest-api-specs repo.

@stevengum stevengum closed this Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants