[ADLS] - Adding existing Account APIs#3961
Merged
shahabhijeet merged 8 commits intoAzure:psSdkJson6from Jan 4, 2018
Merged
Conversation
9 tasks
12e29cc to
298bc3f
Compare
shahabhijeet
suggested changes
Jan 3, 2018
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
- Get latest updates from upstream (if you have not done so in last 3 weeks)
- Then execute msbuild build.proj to update your build tools
- Then regenerate your SDK using generate.cmd (this will regenerate couple of additional files)
- build you project (ether IDE or command line)
- Then update your PR
With the latest changes, every regeneration will generate couple of additional meta data files that are needed in each PR.
Contributor
Author
|
@shahabhijeet I followed those steps already as you noted them in my initial PR: #3954 I did notice one extra file being generated when I built the project using the IDE, which I did not include here |
Contributor
|
@ro-joowan please include all those files, they are required. |
Contributor
Author
|
@shahabhijeet Thank you pointing them out in detail! The process makes more sense now. I have updated this PR. |
shahabhijeet
approved these changes
Jan 4, 2018
Contributor
shahabhijeet
left a comment
There was a problem hiding this comment.
Once CI passes, this PR is ready to be merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
REST spec PR link to the SDK PR
[ADLS] Changes in 2.3.3-preview
Breaking changes
ODataQueryparameter type fromDataLakeAnalyticsAccounttoDataLakeAnalyticsAccountBasicfor these APIs:Notes
DataLakeStoreAccountStatusenum:UndeletingandCanceledDescription
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK.