Skip to content

[ADLS] - Adding existing Account APIs#3961

Merged
shahabhijeet merged 8 commits intoAzure:psSdkJson6from
ro-joowan:scope-adls
Jan 4, 2018
Merged

[ADLS] - Adding existing Account APIs#3961
shahabhijeet merged 8 commits intoAzure:psSdkJson6from
ro-joowan:scope-adls

Conversation

@ro-joowan
Copy link
Copy Markdown
Contributor

@ro-joowan ro-joowan commented Dec 18, 2017

REST spec PR link to the SDK PR

[ADLS] Changes in 2.3.3-preview

Breaking changes

  • Changed the ODataQuery parameter type from DataLakeAnalyticsAccount to DataLakeAnalyticsAccountBasic for these APIs:
    • Account_List
    • Account_ListByResourceGroup

Notes

  • Added two more states to DataLakeStoreAccountStatus enum: Undeleting and Canceled
  • Added new Account APIs:
    • Account_CheckNameAvailability
    • Location_GetCapability
    • Operation_List

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@ro-joowan ro-joowan changed the title [ADLS] - Bugfixes [ADLS] - Adding existing Account APIs and bugfixes Dec 21, 2017
@ro-joowan ro-joowan changed the title [ADLS] - Adding existing Account APIs and bugfixes [ADLS] - Adding existing Account APIs Dec 21, 2017
Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Get latest updates from upstream (if you have not done so in last 3 weeks)
  2. Then execute msbuild build.proj to update your build tools
  3. Then regenerate your SDK using generate.cmd (this will regenerate couple of additional files)
  4. build you project (ether IDE or command line)
  5. Then update your PR
    With the latest changes, every regeneration will generate couple of additional meta data files that are needed in each PR.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

ro-joowan commented Jan 3, 2018

@shahabhijeet I followed those steps already as you noted them in my initial PR: #3954

I did notice one extra file being generated when I built the project using the IDE, which I did not include here

@shahabhijeet
Copy link
Copy Markdown
Contributor

@ro-joowan please include all those files, they are required.

@ro-joowan
Copy link
Copy Markdown
Contributor Author

@shahabhijeet Thank you pointing them out in detail! The process makes more sense now. I have updated this PR.

Copy link
Copy Markdown
Contributor

@shahabhijeet shahabhijeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once CI passes, this PR is ready to be merged.

@shahabhijeet shahabhijeet merged commit 5f93417 into Azure:psSdkJson6 Jan 4, 2018
@ro-joowan ro-joowan deleted the scope-adls branch January 5, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants