Skip to content

[DNS] Add DNS 2017-09-01 Swagger for CAA Record Support#1528

Merged
lmazuel merged 3 commits intoAzure:masterfrom
AutorestCI:RestAPI-PR1835
Oct 26, 2017
Merged

[DNS] Add DNS 2017-09-01 Swagger for CAA Record Support#1528
lmazuel merged 3 commits intoAzure:masterfrom
AutorestCI:RestAPI-PR1835

Conversation

@AutorestCI
Copy link
Copy Markdown
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1835

@AutorestCI AutorestCI requested a review from lmazuel as a code owner October 12, 2017 17:56
@lmazuel lmazuel changed the title Automatic PR from RestAPI-PR1835 [DNS] Add DNS 2017-09-01 Swagger for CAA Record Support Oct 13, 2017
Copy link
Copy Markdown
Member

@lmazuel lmazuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but need new records

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 26, 2017

Codecov Report

Merging #1528 into master will decrease coverage by 4.27%.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   54.23%   49.96%   -4.28%     
==========================================
  Files        3584     3661      +77     
  Lines       88213   108101   +19888     
==========================================
+ Hits        47846    54011    +6165     
- Misses      40367    54090   +13723
Impacted Files Coverage Δ
azure-mgmt-dns/azure/mgmt/dns/models/resource.py 100% <ø> (ø) ⬆️
...zure/mgmt/dns/operations/record_sets_operations.py 90.78% <100%> (ø) ⬆️
azure-mgmt-dns/azure/mgmt/dns/models/record_set.py 100% <100%> (ø) ⬆️
azure-mgmt-dns/azure/mgmt/dns/models/__init__.py 100% <100%> (ø) ⬆️
...-dns/azure/mgmt/dns/operations/zones_operations.py 91.93% <100%> (-0.26%) ⬇️
azure-mgmt-dns/azure/mgmt/dns/models/zone.py 100% <100%> (ø) ⬆️
...e-mgmt-dns/azure/mgmt/dns/dns_management_client.py 100% <100%> (ø) ⬆️
...ure/mgmt/dns/models/dns_management_client_enums.py 100% <100%> (ø) ⬆️
azure-mgmt-dns/azure/mgmt/dns/version.py 100% <100%> (ø) ⬆️
azure-mgmt-dns/azure/mgmt/dns/models/caa_record.py 57.14% <57.14%> (ø)
... and 633 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ef9414...0d457f9. Read the comment docs.

@lmazuel lmazuel merged commit dad33a0 into Azure:master Oct 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants