Skip to content

Merge Networking v2017 09 01 into current#1661

Merged
veronicagg merged 8 commits intocurrentfrom
Networking-V2017-09-01
Sep 11, 2017
Merged

Merge Networking v2017 09 01 into current#1661
veronicagg merged 8 commits intocurrentfrom
Networking-V2017-09-01

Conversation

@ajinkyapotdarvjti
Copy link
Copy Markdown
Contributor

@ajinkyapotdarvjti ajinkyapotdarvjti commented Sep 11, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

ajinkyapotdarvjti and others added 7 commits August 31, 2017 11:56
@ajinkyapotdarvjti @veronicagg
Copying networking files under 2017-08-01 to 2017-09-01 (#1618)
238bfb1 
* Copying networking files under 2017-08-01 to 2017-09-01

* Updated api-version to 2017-09-01 for examples
@ajinkyapotdarvjti @sergey-shandar
Common specs fixes (#1638)
be90ad3
@EvgenyAgafonchikov @sarangan12
Removed icorrect vnet test; Added new one (#1643)
2417e2e
@ajinkyapotdarvjti @olydis
Added enableDDoSProtection and enableVmProtection feature params (#1639)
068c13d
@murilogiacometti @veronicagg
Add new paths and definitions for application security groups (ASGs) (#…
a73e404 
…1616)

* Add new paths and definitions for application security groups (ASGs)

* Add IPConfiguration-ApplicationSecurityGroup relationship

* Add SecurityRule-ApplicationSecurityGroup relationship

* Revert "Add IPConfiguration-ApplicationSecurityGroup relationship"

This reverts commit ebe9e74.

* Revert "Add SecurityRule-ApplicationSecurityGroup relationship"

This reverts commit ab48476.

* Revert "Add new paths and definitions for application security groups (ASGs)"

This reverts commit 20be954.

* Create new folder for 09-01

* Add new paths and definitions for application security groups (ASGs)

* Add IPConfiguration-ApplicationSecurityGroup relationship

* Add SecurityRule-ApplicationSecurityGroup relationship

* Add new tag in readme.md

* Change version in json files

* Fix readme.md

* Change name of the relationship to security rules

* Fix security rule relationship to be many-to-many

* Change returning type for collections (to references)

* Remove useless  parameter

* Add  to the end of the paths

* Remove expand from get

* Add collections API

* Add examples

* Fix operation name

* Mark resource ID as a read-only property

* Fix SDK generation issue

* Fix model validation errors

* Add readOnly flags to application security group properties

* Add missing provisioning state in the docs

* Add missing field to Resource

* Reposition 'location' in the example

* Fix missing 'id' field in collections

* Update ResourceGUID message

* Remove text/json

* Remove ref from paths

* Remove unnecessary file

* Remove paths

* Remove definitions
@ajinkyapotdarvjti @sergey-shandar
Add protocol All support for ILB HA (#1647)
298b9e9
@murilogiacometti @jianghaolu
Remove readOnly for 'id' (to keep backwards compatible) (#1652)
b1614a3
@msftclas
Copy link
Copy Markdown

msftclas commented Sep 11, 2017

@ajinkyapotdarvjti,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-ruby#966

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI AutorestCI mentioned this pull request Sep 11, 2017
Closed
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

Build Status Azure/azure-sdk-for-python#1429

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 11, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 83
After the PR: Warning(s): 156 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

@veronicagg veronicagg self-assigned this Sep 11, 2017
@murilogiacometti @veronicagg
Add missing List API for ASGs (#1651)
9bb5faa 
* Add List API

* Remove whitespace
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-node

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Sep 11, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 151 Error(s): 83
After the PR: Warning(s): 156 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

veronicagg
veronicagg approved these changes Sep 11, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@veronicagg veronicagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is merging the branch created specifically for Network team, which contains commits that were merged to that branch and reviewed by SDK team and ARM team already.

@veronicagg veronicagg merged commit ec9a037 into current Sep 11, 2017
@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

AutorestCI commented Sep 11, 2017

No modification for AutorestCI/azure-sdk-for-ruby

@salameer salameer deleted the Networking-V2017-09-01 branch September 15, 2017 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@veronicagg veronicagg veronicagg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@veronicagg veronicagg

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@ajinkyapotdarvjti @msftclas @AutorestCI @azuresdkciprbot @veronicagg @EvgenyAgafonchikov @murilogiacometti