Skip to content

Added enableDDoSProtection and enableVmProtection feature params#1639

Merged
olydis merged 1 commit intoAzure:Networking-V2017-09-01from
ajinkyapotdarvjti:Networking-V2017-Sept-01
Sep 8, 2017
Merged

Added enableDDoSProtection and enableVmProtection feature params#1639
olydis merged 1 commit intoAzure:Networking-V2017-09-01from
ajinkyapotdarvjti:Networking-V2017-Sept-01

Conversation

@ajinkyapotdarvjti
Copy link
Copy Markdown
Contributor

@ajinkyapotdarvjti ajinkyapotdarvjti commented Sep 6, 2017

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

msftclas commented Sep 6, 2017

@ajinkyapotdarvjti,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@olydis
Copy link
Copy Markdown
Contributor

olydis commented Sep 6, 2017

@ravbhatnagar SDK breaking change; new properties

@olydis olydis added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Sep 6, 2017
@ravbhatnagar ravbhatnagar added ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Sep 8, 2017
@ravbhatnagar
Copy link
Copy Markdown
Contributor

Looks good. ARM signOff. New api-version so adding new properties is fine (unless SDK has already been generated for this api-version)

@olydis olydis merged commit 068c13d into Azure:Networking-V2017-09-01 Sep 8, 2017
@AutorestCI
Copy link
Copy Markdown

No modification for AutorestCI/azure-sdk-for-node

@AutorestCI
Copy link
Copy Markdown

@AutorestCI
Copy link
Copy Markdown

veronicagg pushed a commit that referenced this pull request Sep 11, 2017
* Copying networking files under 2017-08-01 to 2017-09-01 (#1618)

* Copying networking files under 2017-08-01 to 2017-09-01

* Updated api-version to 2017-09-01 for examples

* Common specs fixes (#1638)

* Removed icorrect vnet test; Added new one (#1643)

* Added enableDDoSProtection and enableVmProtection feature params (#1639)

* Add new paths and definitions for application security groups (ASGs) (#1616)

* Add new paths and definitions for application security groups (ASGs)

* Add IPConfiguration-ApplicationSecurityGroup relationship

* Add SecurityRule-ApplicationSecurityGroup relationship

* Revert "Add IPConfiguration-ApplicationSecurityGroup relationship"

This reverts commit ebe9e74.

* Revert "Add SecurityRule-ApplicationSecurityGroup relationship"

This reverts commit ab48476.

* Revert "Add new paths and definitions for application security groups (ASGs)"

This reverts commit 20be954.

* Create new folder for 09-01

* Add new paths and definitions for application security groups (ASGs)

* Add IPConfiguration-ApplicationSecurityGroup relationship

* Add SecurityRule-ApplicationSecurityGroup relationship

* Add new tag in readme.md

* Change version in json files

* Fix readme.md

* Change name of the relationship to security rules

* Fix security rule relationship to be many-to-many

* Change returning type for collections (to references)

* Remove useless  parameter

* Add  to the end of the paths

* Remove expand from get

* Add collections API

* Add examples

* Fix operation name

* Mark resource ID as a read-only property

* Fix SDK generation issue

* Fix model validation errors

* Add readOnly flags to application security group properties

* Add missing provisioning state in the docs

* Add missing field to Resource

* Reposition 'location' in the example

* Fix missing 'id' field in collections

* Update ResourceGUID message

* Remove text/json

* Remove ref from paths

* Remove unnecessary file

* Remove paths

* Remove definitions

* Add protocol All support for ILB HA (#1647)

* Remove readOnly for 'id' (to keep backwards compatible) (#1652)

* Add missing List API for ASGs (#1651)

* Add List API

* Remove whitespace
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ARMSignedOff <valid label in PR review process>add this label when ARM approve updates after review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants