Add protocol All support for ILB HA#1647
Merged
sergey-shandar merged 1 commit intoAzure:Networking-V2017-09-01from Sep 8, 2017
Merged
Add protocol All support for ILB HA#1647sergey-shandar merged 1 commit intoAzure:Networking-V2017-09-01from
sergey-shandar merged 1 commit intoAzure:Networking-V2017-09-01from
Conversation
|
@ajinkyapotdarvjti, |
sergey-shandar
suggested changes
Sep 8, 2017
Contributor
There was a problem hiding this comment.
There are two more definitions of TransportProtocol enums. The new All value makes this definition different from others. I would suggest to use one common definition of TransportProtocol. Something like #/definitions/TransportProtocol.
ajinkyapotdarvjti
force-pushed
the
ilb_ha
branch
from
b172358 to
a64f35c
Compare
ajinkyapotdarvjti
force-pushed
the
ilb_ha
branch
from
a64f35c to
bf9609c
Compare
Contributor
Author
|
addressed Sergey's comments |
sergey-shandar
approved these changes
Sep 8, 2017
|
No modification for AutorestCI/azure-sdk-for-node |
veronicagg
pushed a commit
that referenced
this pull request
Sep 11, 2017
* Copying networking files under 2017-08-01 to 2017-09-01 (#1618) * Copying networking files under 2017-08-01 to 2017-09-01 * Updated api-version to 2017-09-01 for examples * Common specs fixes (#1638) * Removed icorrect vnet test; Added new one (#1643) * Added enableDDoSProtection and enableVmProtection feature params (#1639) * Add new paths and definitions for application security groups (ASGs) (#1616) * Add new paths and definitions for application security groups (ASGs) * Add IPConfiguration-ApplicationSecurityGroup relationship * Add SecurityRule-ApplicationSecurityGroup relationship * Revert "Add IPConfiguration-ApplicationSecurityGroup relationship" This reverts commit ebe9e74. * Revert "Add SecurityRule-ApplicationSecurityGroup relationship" This reverts commit ab48476. * Revert "Add new paths and definitions for application security groups (ASGs)" This reverts commit 20be954. * Create new folder for 09-01 * Add new paths and definitions for application security groups (ASGs) * Add IPConfiguration-ApplicationSecurityGroup relationship * Add SecurityRule-ApplicationSecurityGroup relationship * Add new tag in readme.md * Change version in json files * Fix readme.md * Change name of the relationship to security rules * Fix security rule relationship to be many-to-many * Change returning type for collections (to references) * Remove useless parameter * Add to the end of the paths * Remove expand from get * Add collections API * Add examples * Fix operation name * Mark resource ID as a read-only property * Fix SDK generation issue * Fix model validation errors * Add readOnly flags to application security group properties * Add missing provisioning state in the docs * Add missing field to Resource * Reposition 'location' in the example * Fix missing 'id' field in collections * Update ResourceGUID message * Remove text/json * Remove ref from paths * Remove unnecessary file * Remove paths * Remove definitions * Add protocol All support for ILB HA (#1647) * Remove readOnly for 'id' (to keep backwards compatible) (#1652) * Add missing List API for ASGs (#1651) * Add List API * Remove whitespace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-versionin the path should match theapi-versionin the spec).Quality of Swagger