Skip to content

Content moderator data plane swagger#1540

Closed
alvadb wants to merge 5 commits intoAzure:currentfrom
alvadb:current1
Closed

Content moderator data plane swagger#1540
alvadb wants to merge 5 commits intoAzure:currentfrom
alvadb:current1

Conversation

@alvadb
Copy link
Copy Markdown

@alvadb alvadb commented Aug 14, 2017 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@msftclas
Copy link
Copy Markdown

msftclas commented Aug 14, 2017

@alvadb,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@alvadb alvadb changed the title Current1 Content moderator data plane swagger Aug 14, 2017
vishrutshah
vishrutshah suggested changes Aug 15, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alvadb Let's make sure that CI is green first and also let me know if you have any questions.

Also, curious to know whether you are doing this on behalf of service team?

Thanks!

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 15, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/Content Moderator/ImageTextReadme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/Content Moderator/ReviewJobWorkflowReadme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

vishrutshah
vishrutshah suggested changes Aug 16, 2017
View reviewed changes
...n/cognitiveservices/data-plane/Content Moderator/v1.0/contentmoderatorImageText.swagger.json Outdated
"$ref": "#/parameters/ocpApimSubscriptionKeyParameter"
},
{
"$ref": "#/parameters/ocpApimSubscriptionKeyParameter"
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah Aug 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI seems to be failing due to the duplicate parameters.

https://travis-ci.org/Azure/azure-rest-api-specs/jobs/264921311#L3501

vishrutshah
vishrutshah suggested changes Aug 18, 2017
View reviewed changes
...n/cognitiveservices/data-plane/Content Moderator/v1.0/contentmoderatorImageText.swagger.json Outdated
"in": "body",
"required": true,
"schema": {
"type": "file"
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be non-confimant to the swagger 2.0 schema. Please use

"schema" : {
  "type": "object",
  "format": "file"
}

Reference: #1544

...n/cognitiveservices/data-plane/Content Moderator/v1.0/contentmoderatorImageText.swagger.json Outdated
"in": "body",
"required": true,
"schema": {
"type": "file"
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here as well

...n/cognitiveservices/data-plane/Content Moderator/v1.0/contentmoderatorImageText.swagger.json Outdated
"in": "body",
"required": true,
"schema": {
"type": "file"
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

...n/cognitiveservices/data-plane/Content Moderator/v1.0/contentmoderatorImageText.swagger.json Outdated
"in": "body",
"required": true,
"schema": {
"type": "file"
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah Aug 18, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here as well

@azuresdkciprbot
Copy link
Copy Markdown

azuresdkciprbot commented Aug 22, 2017

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/cognitiveservices/data-plane/Content Moderator/ImageTextReadme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

File: specification/cognitiveservices/data-plane/Content Moderator/ReviewJobWorkflowReadme.md
Before the PR: Warning(s): 0 Error(s): 0
After the PR: Warning(s): 0 Error(s): 0

AutoRest Linter Guidelines | AutoRest Linter Issues

Send feedback and make AutoRest Linter Azure Bot smarter day by day!

Thanks for your co-operation.

vishrutshah
vishrutshah suggested changes Aug 22, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@vishrutshah vishrutshah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review the syntax failures on CI https://travis-ci.org/Azure/azure-rest-api-specs/jobs/267346600#L3521 Thanks!

@veronicagg
Copy link
Copy Markdown
Contributor

veronicagg commented Sep 5, 2017

@alvadb are there updates on this one?

@salameer
Copy link
Copy Markdown
Member

salameer commented Sep 15, 2017

@alvab what are the next steps here on this PR?

@vishrutshah
Copy link
Copy Markdown
Contributor

vishrutshah commented Sep 25, 2017

Closing this as service team is working on improvements in their fork. Once completed, they'll send a new PR for review. Thanks@

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@vishrutshah vishrutshah vishrutshah requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vishrutshah vishrutshah

Labels

Cognitive - Content Moderator DataPlane

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@alvadb @msftclas @azuresdkciprbot @veronicagg @salameer @vishrutshah @kaerm @alvabandy