Expose new SKUs for zone-redundant VirtualNetworkGateways #6539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New VPN Client Protocol
Updated Azure Networking SDK version to 19.1.0
Contributor
Author
|
This is a retake from #6277 which was dependent on SDK version update for Network |
Contributor
|
@ritwikbasu please cover these properties by unit tests |
Contributor
Author
|
@MikhailTryakhov - Since these are new values added to existing enums, the existing scenario tests already present still hold. There is no change in any business logic or commandlet design. |
Contributor
|
LGTM, @praries880 could you please help to merge? |
praries880
changed the base branch from
Network-2018-06-01
to
release-2018-06-29
Contributor
|
@ritwikbasu kindly take care of the merge conflicts |
Contributor
|
@ritwikbasu the changes look good to me, just take care of the merge conflicts n we'r good to go |
…owershell into Network-2018-06-01
Contributor
Author
|
@praries880 - I have resolved the merge conflicts. Please let me know if everything looks good. |
praries880
approved these changes
Jun 27, 2018
Contributor
praries880
added
Waiting for On Demand
Waiting for CI 
and removed
Merge Conflicts
needs-review
Waiting for CI
labels
Contributor
|
@praries880 can we merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
CONTRIBUTING.mdplatyPSmodule