New VPN Client Protocol

[henry416]

Description

Checklist

• I have read the Submitting Changes section of CONTRIBUTING.md
• The title of the PR is clear and informative
• The appropriate change log has been updated
• The PR does not introduce breaking changes
• If applicable, the changes made in the PR have proper test coverage
• For public API changes to cmdlets:
  • the changes have gone through a cmdlet design review
  • the cmdlet markdown files were generated using the platyPS module

[henry416]

@markcowl As discussed with @MikhailTryakhov, I am to push the changes to this Network-2018-06-01 branch which will be later updated with generated SDK and merged into preview branch for the June 29th Powershell release.

#6418

[praries880]

@henry416 The Jenkins build is breaking because of the following compilation error :

VirtualNetworkGateway\UpdateAzureVirtualNetworkGatewayCommand.cs(82,35): error CS0117: 'VpnClientProtocol' does not contain a definition for 'OpenVPN' [c:\workspace\powershell\src\ResourceManager\Network\Commands.Network\Commands.Network.csproj]
16:17:22 VirtualNetworkGateway\NewAzureVirtualNetworkGatewayCommand.cs(153,35): error CS0117: 'VpnClientProtocol' does not contain a definition for 'OpenVPN' [c:\workspace\powershell\src\ResourceManager\Network\Commands.Network\Commands.Network.csproj]

Are you missing a library reference?

[praries880]

@henry416
@markcowl had the following comment in the related PR : "Change this from a ValidateSet to an ArgumentCompleter" . Kindly address it.

[praries880]

@henry416
@markcowl had the following comment in the related PR : "Change this from a ValidateSet to an ArgumentCompleter" . Kindly address it.

[henry416]

@praries880 Will not change, as described in the previous PR. This breaks the existing powershell inputs.

[praries880]

It seems the Models do not have the value OpenVPN, is this something that is not currently released?

[henry416]

@praries880 This is why we are merging to this particular branch instead of preview branch. @MikhailTryakhov will eventually import the updated nuget network SDK into this, which will contain the updated model.

[MikhailTryakhov]

@henry416 to do it we need to push SDK nuget package to local feed not receive broken build.
Again, use documentation I shared, add local SDK to PowerShell and test it in this PR. No need to push untested code here

Link to docs

[henry416]

@MikhailTryakhov Generated the nuget and put it in LocalFeed.

[praries880]

@henry416 you need to add the library version in the netcore csproj as well...

the netcore build is broken :
https://travis-ci.org/Azure/azure-powershell/builds/394784341#L1315

[henry416]

@praries880 Netcore build has been fixed

[henry416]

@praries880 Local build works, not sure why automation is failing...

[praries880]

@henry416 The netcore build/test fail seems to be because the new library you added is not getting loaded

I will check to see if you need to modify some other file to get it to work.

I am looking into what caused the Jenkins tests to fail.

[praries880]

@henry416 for the Jenkins failure, you need to update the reference to the network dll in these projects as well : https://github.com/Azure/azure-powershell/blob/preview/TestMappings.json#L119-L126

[MikhailTryakhov]

@henry416 did you use my scipt? It's described in docs I shared.. It'll cutomize config as it's needed

[henry416]

@MikhailTryakhov script doesn't work, but I have fixed it. I'm looking into why the UT didn't get picked up.

[henry416]

@praries880 @MikhailTryakhov Pushed a test case placement fix, should be green now

[henry416]

@praries880 RepoTasks.Cmdlets.Tests.NewFormatPs1XmlCommandShould.SaveOnlyMarkedPropertiesInSpecifiedViews
What exactly is this test case?

[henry416]

@praries880 @markcowl Could you assist with this error? Local build shows UTs to be fine. Cut off is today.

[maddieclayton]

@azuresdkci Test this please

[henry416]

@markcowl @praries880 @MikhailTryakhov Ready to merge for June 29th release

[MikhailTryakhov]

LGTM

[praries880]

on demand : https://azuresdkci.westus2.cloudapp.azure.com/job/powershell-demand/954/
sign job : https://azuresdkci.westus2.cloudapp.azure.com/job/ps-sign/789/