Skip to content

Conversation

@ritwikbasu
Copy link
Contributor

@ritwikbasu ritwikbasu commented May 23, 2018

Expose new SKUs for VMSS Vpn gateways

Description

Checklist

Expose new SKUs for VMSS Vpn gateways
Update changelog for Network
@maddieclayton
Copy link
Contributor

@ritwikbasu You will need to rerecord the Network tests, and bump the network version for all dependent modules (see here for an example and here for the instructions on how to rerecord all tests).

@maddieclayton
Copy link
Contributor

@ritwikbasu Please resolve merge conflicts.

@ritwikbasu
Copy link
Contributor Author

Waiting on NRP104 manifest update to happen before merging this change.

@maddieclayton - Please do not close this PR. I will update this when NRP has completely rolled out. This has the same issue has #6317

@maddieclayton maddieclayton self-assigned this Jun 4, 2018
@maddieclayton
Copy link
Contributor

@ritwikbasu I will close this PR, as the merge conflicts are building and the Network api has not yet been updated. It will be easier to get more eyes on this review by opening a new PR when it is ready to go, rather than just updating the current PR. Let me know if you have issues opening a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants